From patchwork Tue Jan 14 13:14:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "mrbff (Code Review)" X-Patchwork-Id: 4053 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:b7cb:b0:5e7:b9eb:58e8 with SMTP id en11csp2231583mab; Tue, 14 Jan 2025 05:14:30 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWU0gTIw3FYjgPlxCCPYXD9VbB42CQx7OPiUrwbW4zjPODD8YoaYyZBKnCzUiZ5+CTgse3CXyr8SKY=@openvpn.net X-Google-Smtp-Source: AGHT+IGoRWzZGph1vFgluFW4TE29X8/dXA0y480gKoFa0WMFoclQ9YRtCYQf7P4iilV0xPP7P6br X-Received: by 2002:a05:6808:ecd:b0:3e6:4ae:a91e with SMTP id 5614622812f47-3ef2eddb343mr15947570b6e.36.1736860470351; Tue, 14 Jan 2025 05:14:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1736860470; cv=none; d=google.com; s=arc-20240605; b=QKHZA5t16naup+3FbJFVxwcFsla/ZGraauca7LyGbBk0gd8OfaXnVdZ7/kvcoQjOqJ 9ifzSqECLTpITuBieyOj3BUARCj6ThK0FiPG1wrRhCp/lLtrYxdYhrODXJB+1lMG4x/f hCXRCcmETwft6VgqTzkxmyVlU1meK8hvv1BBLiatsBgyvn0g73uQ7zW4Ec3wrqTT0qwi 24j0XwmUezoa0Wjs/ApE++Nh78AS1tXl9QM6ml+h9Hl2Eiiq++wTz7k5w3ArRiqByces aDM8ZncKlPzKiwKEJNr74iYuf5tLzuH5QohKJlI3dDvFenGAmmmpcG1eFxfgZuruNA2/ +cPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=ohNHAQcC/a5xfuOVRW1YcLKSLAiCByg69/2wylxh1NA=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=NlvNpfLJamgAP9ykpu2X1w09CqRjanbzIq/wbsu5hSuBmpyArkZimQ3j4zkIu3QdYh zY+Cp8f8gPMdhUeOrI6dkoBNBhZ1/lsmZxuw3juGO+lkIBTBM5YvWpQV0Rp++ZjwPmLW tJ5vNRIYpx5wMapE6AH0UYYlM2O4VfXsOTuNK58dBL9XrDjqjwvPtz7qK/CFMej1Yz2d sMzHxMnX+3DjjDtnaJppwjx50QISwnOehbzaU1GTaGya+EPerdcSg7y/e/u6GcOcrCpZ lRui1TBVILwOqJzQeIVp4hy0cdyj9xlqfFbn9CjBaLUExtYj5h1aFHwqIwAipObs3McI Oq0Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ilmU6zPb; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=MEVUAt96; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=DUyNuaEl; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7231865e025si9120120a34.257.2025.01.14.05.14.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jan 2025 05:14:30 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ilmU6zPb; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=MEVUAt96; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=DUyNuaEl; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tXgkS-0001Ep-Qv; Tue, 14 Jan 2025 13:14:24 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tXgkQ-0001Ee-ND for openvpn-devel@lists.sourceforge.net; Tue, 14 Jan 2025 13:14:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HvR+FqcwP/0ZScdG9sc/8MojdmrrVPU9M5wXxaJCY/A=; b=ilmU6zPbNmTBbG69YcIsJXDqAH zteLb3xNcXgS4tF0p5s09S1ehtul0oRC8YVq6VQFro6pRx3vNeNHanjMIt+pz8I5duRYWS6/XVTKM gC2t+qN0NqrlmGcsezG6PCaEe4PLJaCZtoaDNyANQj/6YPIJ7yfz1g0hBDw4OTUiIgOE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=HvR+FqcwP/0ZScdG9sc/8MojdmrrVPU9M5wXxaJCY/A=; b=M EVUAt96EzECPxV0lcvNNTKQoxgZnSSLXe1fbEs29FimMUaZSP5+yZKV5z7/iUiF3p7ODzc7OyOAnX +b8zT9ITCk22z1FKWK26sWYj0N+LD+1UgDGzCzLA8jZDG9f2lxIwGX51U55EyemwIEYbZ01Z4TVLk KcyIu1hc5JBZmHbI=; Received: from mail-wm1-f41.google.com ([209.85.128.41]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tXgkP-0003iz-2l for openvpn-devel@lists.sourceforge.net; Tue, 14 Jan 2025 13:14:22 +0000 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43675b1155bso62274075e9.2 for ; Tue, 14 Jan 2025 05:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1736860454; x=1737465254; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=HvR+FqcwP/0ZScdG9sc/8MojdmrrVPU9M5wXxaJCY/A=; b=DUyNuaEl13T8aaVyy7Nk5Zq3efqpFaHtXqwKGh/f1970t8SpvWv3ejnG9zEhqfRU0e Y0tryAxxP+kUCX33WFG8WbaR18KcUj7sP2AnmQPqQd5KWYghPv7cke+uTcO30GXP4V3f qriDGXYPgLirpewgw+bFyybXT65QvFmb+a0N6eKrIAhlnj8uefAXq/uvs6STjCzYVEBo QuTjyMlNRF6hrGMjjye09ubcK+Lfq71vewmEmHabulzKxj95QsXjg/xelQS9FlULPQvq RDUw5/9nL4zR6hT7sjxRC7o5rJr2lBNdI6Gzq7X7dz/giR8wZJmwUW+6pdO3iB91zUG0 ZL+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736860454; x=1737465254; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HvR+FqcwP/0ZScdG9sc/8MojdmrrVPU9M5wXxaJCY/A=; b=iwD4D5Eu5+DlGQTbsTiFw3aiH9s1dItNdj3wRubsdOLcF0MiD91HUo9qT11Oqw6ddw Abx6VVuD4l7cyKV14QBHcXH7aR1z7nIuYU9XOKeYp3ktXJ5JoVL66dpNkYphpods5Y70 o9jd1YYkAawGsUmUWmFibVN0n1ROMgqLtKj9HvAAVT0g39GmqlXjAruJCgZU+pdx+QEq QmaZ/o9b7vLXI7avoOI9tBJwI6VUllTNdlgivvLzbl0eg9mPq/Z05ZhmfiVzqOl2fekq zrex1Zr8hmjmF+RTy3JkQQI7fmZPRMsWGObygixpasf3iFruQ34BiAUg+P58gxvTnGiF tcXw== X-Gm-Message-State: AOJu0Yza5ROg5r6ClnX0aZ5Pcdg1uZWB6lH0tOkoHTprdt0muNhoCYkp lzGDJ/LW/L+BVS9MqsKecJanq/+TIbBmham3KcmU727ZZ1RwqqlGoFMTp0HFsB/yK8ruqd29Fy5 S X-Gm-Gg: ASbGnctOIdMOu7F28O6KgL4PXlsmSpoDhfR5YK8utERN5dqBlnJ86pRTbpnzw3y1JJO TzvJ1BgkEKTcvOOW3u5isYtS6N23tTwjCYFrYtyzGNb7V5f/GgzVSkhHXF2+a/UbCGZQvoXQtQ5 /gUZIjrkzj5bLvov3IvpZN3+dGSZV2YVTFGkAQVsUSHbRXUuateflXRldCY7H7+U7abed6/5VJt aX2e9nZ6Ifc7a5IF2BJj++RG4OawFSHp/85ja+YM/MvbnwothTgNEyHYAb2q9AXprJ1h8SU4QXW xm7+gN0HxcylhB3OLW6Y23JzxA80cFatV1u/C9dfBwqNWA6b X-Received: by 2002:a05:600c:138a:b0:434:a781:f5d5 with SMTP id 5b1f17b1804b1-436e271bcb3mr248891275e9.30.1736860454369; Tue, 14 Jan 2025 05:14:14 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4b81ccsm15020240f8f.65.2025.01.14.05.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 05:14:14 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 14 Jan 2025 13:14:13 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I1146da697adb8a200df0507dc7ec931c36738ffa X-Gerrit-Change-Number: 861 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 6da66e94634b3cdd17453b388378dbc5f665129f References: Message-ID: <3dd4f4c4f8c718798acd83a4828c4db01ea68bd1-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -2.0 (--) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-2.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.41 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.41 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.41 listed in sa-trusted.bondedsender.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.41 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tXgkP-0003iz-2l Subject: [Openvpn-devel] [M] Change in openvpn[master]: Fix various compiler warnings for intentionally unused parameters X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1821230204573883503?= X-GMAIL-MSGID: =?utf-8?q?1821230204573883503?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/861?usp=email to review the following change. Change subject: Fix various compiler warnings for intentionally unused parameters ...................................................................... Fix various compiler warnings for intentionally unused parameters Change-Id: I1146da697adb8a200df0507dc7ec931c36738ffa Signed-off-by: Frank Lichtenheld --- M src/openvpn/dco_win.h M src/openvpn/event.h M src/openvpn/multi.c M src/openvpn/perf.h M src/openvpn/route.c M src/openvpn/route.h M src/openvpn/ssl.c M src/openvpn/tun.h M src/openvpn/xkey_provider.c M src/plugins/auth-pam/auth-pam.c M src/plugins/down-root/down-root.c 11 files changed, 30 insertions(+), 30 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/861/1 diff --git a/src/openvpn/dco_win.h b/src/openvpn/dco_win.h index 7688516..99c9252 100644 --- a/src/openvpn/dco_win.h +++ b/src/openvpn/dco_win.h @@ -54,7 +54,7 @@ #else /* if defined(ENABLE_DCO) && defined(_WIN32) */ static inline void -dco_start_tun(struct tuntap *tt) +dco_start_tun(struct tuntap *) { ASSERT(false); } diff --git a/src/openvpn/event.h b/src/openvpn/event.h index c212e07..d792145 100644 --- a/src/openvpn/event.h +++ b/src/openvpn/event.h @@ -214,7 +214,7 @@ #else /* ifdef _WIN32 */ static inline void -wait_signal(struct event_set *es, void *arg) +wait_signal(struct event_set *, void *) { } diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index f426b46..7fa3b43 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -252,7 +252,7 @@ #ifdef ENABLE_MANAGEMENT static uint32_t -cid_hash_function(const void *key, uint32_t iv) +cid_hash_function(const void *key, uint32_t /*iv*/) { const unsigned long *k = (const unsigned long *)key; return (uint32_t) *k; @@ -273,7 +273,7 @@ /* * inotify watcher descriptors are used as hash value */ -int_hash_function(const void *key, uint32_t iv) +int_hash_function(const void *key, uint32_t /*iv*/) { return (unsigned long)key; } diff --git a/src/openvpn/perf.h b/src/openvpn/perf.h index 04abe89..d394347 100644 --- a/src/openvpn/perf.h +++ b/src/openvpn/perf.h @@ -75,7 +75,7 @@ #else /* ifdef ENABLE_PERFORMANCE_METRICS */ static inline void -perf_push(int type) +perf_push(int) { } static inline void diff --git a/src/openvpn/route.c b/src/openvpn/route.c index d17b285..2aa33d0 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -4181,7 +4181,7 @@ #else /* if defined(_WIN32) */ static void -get_bypass_addresses(struct route_bypass *rb, const unsigned int flags) /* PLATFORM-SPECIFIC */ +get_bypass_addresses(struct route_bypass *, const unsigned int) /* PLATFORM-SPECIFIC */ { } diff --git a/src/openvpn/route.h b/src/openvpn/route.h index 421e7d2..e605d8b 100644 --- a/src/openvpn/route.h +++ b/src/openvpn/route.h @@ -365,7 +365,7 @@ #else /* ifdef _WIN32 */ static inline bool -test_routes(const struct route_list *rl, const struct tuntap *tt) +test_routes(const struct route_list *, const struct tuntap *) { return true; } diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index e4a7b57..631e547 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -257,7 +257,7 @@ } int -pem_password_callback(char *buf, int size, int rwflag, void *u) +pem_password_callback(char *buf, int size, int /*rwflag*/, void */*u*/) { if (buf) { diff --git a/src/openvpn/tun.h b/src/openvpn/tun.h index ccba0bc..a5b9a48 100644 --- a/src/openvpn/tun.h +++ b/src/openvpn/tun.h @@ -698,37 +698,37 @@ #else /* ifdef _WIN32 */ static inline bool -tuntap_stop(int status) +tuntap_stop(int) { return false; } static inline bool -tuntap_abort(int status) +tuntap_abort(int) { return false; } static inline void -tun_standby_init(struct tuntap *tt) +tun_standby_init(struct tuntap *) { } static inline bool -tun_standby(struct tuntap *tt) +tun_standby(struct tuntap *) { return true; } static inline bool -tuntap_is_dco_win(struct tuntap *tt) +tuntap_is_dco_win(struct tuntap *) { return false; } static inline bool -tuntap_is_dco_win_timeout(struct tuntap *tt, int status) +tuntap_is_dco_win_timeout(struct tuntap *, int) { return false; } diff --git a/src/openvpn/xkey_provider.c b/src/openvpn/xkey_provider.c index 964d2eb..8efcd9e 100644 --- a/src/openvpn/xkey_provider.c +++ b/src/openvpn/xkey_provider.c @@ -204,7 +204,7 @@ } static void * -keymgmt_load(const void *reference, size_t reference_sz) +keymgmt_load(const void */*reference*/, size_t /*reference_sz*/) { xkey_dmsg(D_XKEY, "entry"); @@ -416,7 +416,7 @@ /* A minimal set of key params that we can return */ static const OSSL_PARAM * -keymgmt_gettable_params(void *provctx) +keymgmt_gettable_params(void */*provctx*/) { xkey_dmsg(D_XKEY, "entry"); @@ -558,7 +558,7 @@ } static const char * -rsa_keymgmt_name(int id) +rsa_keymgmt_name(int /*id*/) { xkey_dmsg(D_XKEY, "entry"); @@ -761,7 +761,7 @@ } static const OSSL_PARAM * -signature_settable_ctx_params(void *ctx, void *provctx) +signature_settable_ctx_params(void */*ctx*/, void */*provctx*/) { xkey_dmsg(D_XKEY, "entry"); @@ -874,7 +874,7 @@ } static const OSSL_PARAM * -signature_gettable_ctx_params(void *ctx, void *provctx) +signature_gettable_ctx_params(void */*ctx*/, void */*provctx*/) { xkey_dmsg(D_XKEY, "entry"); @@ -884,7 +884,7 @@ } static int -signature_get_ctx_params(void *ctx, OSSL_PARAM params[]) +signature_get_ctx_params(void */*ctx*/, OSSL_PARAM */*params[]*/) { xkey_dmsg(D_XKEY, "not implemented"); return 0; @@ -936,7 +936,7 @@ } static int -signature_sign(void *ctx, unsigned char *sig, size_t *siglen, size_t sigsize, +signature_sign(void *ctx, unsigned char *sig, size_t *siglen, size_t /*sigsize*/, const unsigned char *tbs, size_t tbslen) { xkey_dmsg(D_XKEY, "entry with siglen = %zu\n", *siglen); @@ -956,8 +956,8 @@ } static int -signature_digest_verify_init(void *ctx, const char *mdname, void *provkey, - const OSSL_PARAM params[]) +signature_digest_verify_init(void */*ctx*/, const char *mdname, void */*provkey*/, + const OSSL_PARAM */*params[]*/) { xkey_dmsg(D_XKEY, "mdname <%s>", mdname); @@ -970,8 +970,8 @@ * for debugging purposes. */ static int -signature_digest_verify(void *ctx, const unsigned char *sig, size_t siglen, - const unsigned char *tbs, size_t tbslen) +signature_digest_verify(void */*ctx*/, const unsigned char */*sig*/, size_t /*siglen*/, + const unsigned char */*tbs*/, size_t /*tbslen*/) { xkey_dmsg(D_XKEY, "entry"); @@ -1166,7 +1166,7 @@ static OSSL_FUNC_provider_teardown_fn teardown; static const OSSL_ALGORITHM * -query_operation(void *provctx, int op, int *no_store) +query_operation(void */*provctx*/, int op, int *no_store) { xkey_dmsg(D_XKEY, "op = %d", op); @@ -1188,7 +1188,7 @@ } static const OSSL_PARAM * -gettable_params(void *provctx) +gettable_params(void */*provctx*/) { xkey_dmsg(D_XKEY, "entry"); @@ -1200,7 +1200,7 @@ return param_types; } static int -get_params(void *provctx, OSSL_PARAM params[]) +get_params(void */*provctx*/, OSSL_PARAM params[]) { OSSL_PARAM *p; diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c index 54cab33..7aa477c 100644 --- a/src/plugins/auth-pam/auth-pam.c +++ b/src/plugins/auth-pam/auth-pam.c @@ -520,7 +520,7 @@ } OPENVPN_EXPORT int -openvpn_plugin_func_v1(openvpn_plugin_handle_t handle, const int type, const char *argv[], const char *envp[]) +openvpn_plugin_func_v1(openvpn_plugin_handle_t handle, const int type, const char **/*argv[]*/, const char *envp[]) { struct auth_pam_context *context = (struct auth_pam_context *) handle; diff --git a/src/plugins/down-root/down-root.c b/src/plugins/down-root/down-root.c index 384bc81..3a152b1 100644 --- a/src/plugins/down-root/down-root.c +++ b/src/plugins/down-root/down-root.c @@ -344,7 +344,7 @@ } OPENVPN_EXPORT int -openvpn_plugin_func_v1(openvpn_plugin_handle_t handle, const int type, const char *argv[], const char *envp[]) +openvpn_plugin_func_v1(openvpn_plugin_handle_t handle, const int type, const char **/*argv[]*/, const char *envp[]) { struct down_root_context *context = (struct down_root_context *) handle;