From patchwork Wed Feb 19 07:06:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "stipa (Code Review)" X-Patchwork-Id: 4149 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9b51:b0:5e7:b9eb:58e8 with SMTP id b17csp2789684max; Tue, 18 Feb 2025 23:06:48 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVofN+HjS3YiM7XYBgUVaWuv3QqUESKGPzCCc8EKo4JSRjXGyR1Uawq1z1rT9eF3Tw7Qtw2xZStY6E=@openvpn.net X-Google-Smtp-Source: AGHT+IH6b58qStOjIvaoBiHY3S5X8S9KpU9jaqV5TneE9l6VE5Gw5phQnNhYzeBoVJQaadvpWHgI X-Received: by 2002:a6b:3c14:0:b0:855:9c88:78a0 with SMTP id ca18e2360f4ac-8559c887d4amr751535939f.9.1739948808197; Tue, 18 Feb 2025 23:06:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739948808; cv=none; d=google.com; s=arc-20240605; b=N/uSq4aAO6kZOdFcjYvyoN+CfFh4a9tz2Fyjlkb0/2daxL4DnyMfDy6v2o9ynt7sp6 0RsPSUWHDFQfF9k0DCfBxYzTj+pwh/TbSXUCABTVwJTHWinSSIS/i7AELSnl6a8V3r+z 0uQaC70n6v1Cqi+Vo3rxRynzceJ5QicxApJukZKsZCHfopc7/OBuj3/hF6j82/D1VvnZ fY/IdlEE/WWauYUglzMc6oA8/Nke7acrxjBHX9fVqT+pU6lAxPTkO9ujQ53yyzzw/+C1 zu2FGtyy2gyo5zoQuKFHU/lfuTXFZFcIG5RhaUzueEUDnwdXJRaFJ32/oSEYfh0upAtH fSNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=2ZwoD4vWPEYi95GNSmWu5aRo4LSzOKMx4amjnrldVWE=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=QQ3RIDmWlObp5A0U/2iIaN+Tu8XcjQJF9IqKsEoxxcspebinwW2aLXIvQPPUoOg6bi hgjh2gHRsC+7DhR1WMBOPbvxuSCDu9weEEZ3ZDcpuTVbj6sHym5V0MC41EXoIfztbVWY XP9ostmfC1MLi5CQB7cGfJs7pOkEfihPrUm+uc8ojuJoOEJvEmn4D3o1OShs2+7Arfcb um3hzHQcMgPWflJ1/Ij3UwKTk9f2zv+O9dYyMjZLKO9TV4OGbjJFDj87wPjdNC0grKZE JBrkvpH1b0xj7CShs+pDf9Lf3ZqZAjrLnq7gmbl2JDuXvn0K5A97gJYcZt0jjxBtvgRf Ybeg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=KtsOwhw5; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ZAMOwPMF; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=UxvSQRCO; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ca18e2360f4ac-855a7338c03si366929339f.44.2025.02.18.23.06.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Feb 2025 23:06:48 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=KtsOwhw5; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ZAMOwPMF; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=UxvSQRCO; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tkeAN-0002d6-IE; Wed, 19 Feb 2025 07:06:43 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tkeAL-0002d0-Nq for openvpn-devel@lists.sourceforge.net; Wed, 19 Feb 2025 07:06:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Atz8vtJwUhzfOzjNf+kv4/+e0p7PtVkaDeC/MozSE0I=; b=KtsOwhw5yL7zDCpldu8PepWOeU e1L9opYb9+usmPFQbYDM34cBRIs5HD+v/S/CfTljQujxas6jQI1DouJEEMGdFaPO+Pqxo//mWUZhd nmk4No96Xhol3m2XGguhzqbIw4TMPSvgVLAaX9oPNOOQXsNkT5v3ntdLaREz7nuzcEG4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=Atz8vtJwUhzfOzjNf+kv4/+e0p7PtVkaDeC/MozSE0I=; b=Z AMOwPMFhA7/8W87pFm/QRP1Qq3xHUYV48Pnn+tlnX6pYQ+qEYJ/ZDch00DQ4UiZCIkfvOLeIP945M ZydE3SXmIr0mTV3bzRFIOAZhhWjJ+d02mttspQlt6cMtg/Ms3m2NQrPdOqjxdeIg7xO3pd6tufY4e XS7/mksHsQsYwIyM=; Received: from mail-wm1-f42.google.com ([209.85.128.42]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tkeAK-0000XN-Ic for openvpn-devel@lists.sourceforge.net; Wed, 19 Feb 2025 07:06:41 +0000 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4399a1eada3so5727415e9.2 for ; Tue, 18 Feb 2025 23:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1739948789; x=1740553589; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=Atz8vtJwUhzfOzjNf+kv4/+e0p7PtVkaDeC/MozSE0I=; b=UxvSQRCOYEB8XF6X2FewiKvOwItQe4kpBmfZbZXtpXYelOa5z7/G1K+/VcauftrEtI pmXSLBUHb5qMG/wY7dnZAOREfigFVWVTed5lwsLqui55ycfhJ5q8LIphYoCsdTOotSO9 +ffymjp16Okw9Y/2heSDp8Jpuj4vGGrzRYZL99FmwOwkQyoVzXTmY6EqJ0G3s5iwLkmu WhOwgO/3PUSNWgCjb888S2K8A6o2mrCOX9SqbI2kq3eIUWF1M4pdRwHlbV8QzGDjHcgR lW4Ho0IMlKangA9ksmpqJB0Z3dL65DSfm4Djrn7svKVPJJLXT/Mvvo0yV8QxdNoxeadQ DhtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739948789; x=1740553589; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Atz8vtJwUhzfOzjNf+kv4/+e0p7PtVkaDeC/MozSE0I=; b=t+amx/7srGjpq6YQTzT1j0M2qtf7tkmvXeiqEHyEVfViWLB6vH8CdmzjVU/gpzbpVB 484Bio4b0sQ4oSlZrX+5sllNUMqqnln9QINR5D2BCaIoJ3ngAjWjRAEgNsxMBaspWdOP vnWBOg6Rq+zLqX8i7qh3Gr/1dhg9sgDmpueJGAH3HK0x+6hGE3WMgrHMtueg61kU9JFd bqMNe1xo6Nt7yLBdKgDroDg0UeHJLEHSTSHtnXe7lkviN2DJnIRcsFiSReJNihzs2YFI tNtDK0sqlX7fqm8oRxjtgGtoZv7lEvV9Ghq1BryYTVEsezchcJzXQf4NpknBKWnq3+Es 2Tkw== X-Gm-Message-State: AOJu0YzcEDyYyPquBJnS0SC0ZpHSva005Ikw9+8F/oyookwSN7LCwHkQ ZpQHDe+cvi97EiBX6JHXZP4EbhUW1GFUA1Cy/OeJif5/AKVcBJ7tZLdqJUpOxIBe8qFQMhpIO7F B X-Gm-Gg: ASbGncuDLVR83M0XS5k+3bJoYCJxY0L9JqkKDa02DxYCK6lI1w3o0rLMNqjPJ86tLlo PFEBXGyTZB0a4e5GiqX++5Qwi+Ak/wsDGMJC8zhI7ohdsqzksHC4JBqayMXvRn4DmjB/7CgCD1p d9LF6VmDQ1L5lpxw817Csg/4EtvgkRH7HM50uFZLUhNUhNFdoJDNxTAvPGeGgwQBTYCKsbKD6kP NhTgEhdaTZWq56uG37PgCByuBw45t0OBm/GBjSJITTMn9/a9cBfsv3+Qtlb7G7fqwLgafdPU1mz O+gmzK/zPQQeBKP/QzguZ1h1d9q6yvDjYNhL4GESak8sMJzh/z/lVhk0vSWIRPsreCDOmsCH+3+ fcu6U9KU= X-Received: by 2002:a05:600c:1c18:b0:439:6d7c:48fd with SMTP id 5b1f17b1804b1-43999d755acmr21330575e9.4.1739948788858; Tue, 18 Feb 2025 23:06:28 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43986320899sm74258225e9.38.2025.02.18.23.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 23:06:28 -0800 (PST) From: "cron2 (Code Review)" X-Google-Original-From: "cron2 (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 19 Feb 2025 07:06:27 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I1a9738ad73c79661a8beb4d9881eba0b4d3aea53 X-Gerrit-Change-Number: 899 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 20d4dbfc88d4e6d90697054f01d16aa104b4ed7e References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.42 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.42 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.42 listed in bl.score.senderscore.com] 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.42 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tkeAK-0000XN-Ic Subject: [Openvpn-devel] [S] Change in openvpn[master]: add more (void) to windows specific function prototypes and declarations X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: gert@greenie.muc.de, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1824468561348314674?= X-GMAIL-MSGID: =?utf-8?q?1824468561348314674?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/899?usp=email to review the following change. Change subject: add more (void) to windows specific function prototypes and declarations ...................................................................... add more (void) to windows specific function prototypes and declarations Change-Id: I1a9738ad73c79661a8beb4d9881eba0b4d3aea53 Signed-off-by: Gert Doering --- M src/openvpn/win32.c M src/openvpnserv/common.c M src/openvpnserv/service.c M src/openvpnserv/service.h 4 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/899/1 diff --git a/src/openvpn/win32.c b/src/openvpn/win32.c index 86556a8..edac71e 100644 --- a/src/openvpn/win32.c +++ b/src/openvpn/win32.c @@ -103,7 +103,7 @@ * Set OpenSSL environment variables to a safe directory */ static void -set_openssl_env_vars(); +set_openssl_env_vars(void); void init_win32(void) @@ -1518,7 +1518,7 @@ } static void -set_openssl_env_vars() +set_openssl_env_vars(void) { const WCHAR *ssl_fallback_dir = L"C:\\Windows\\System32"; diff --git a/src/openvpnserv/common.c b/src/openvpnserv/common.c index a88a724..74bec6e 100644 --- a/src/openvpnserv/common.c +++ b/src/openvpnserv/common.c @@ -181,7 +181,7 @@ LPCTSTR -GetLastErrorText() +GetLastErrorText(void) { DWORD error; static TCHAR buf[256]; diff --git a/src/openvpnserv/service.c b/src/openvpnserv/service.c index 054fc5f..84fd11a 100644 --- a/src/openvpnserv/service.c +++ b/src/openvpnserv/service.c @@ -54,7 +54,7 @@ } static int -CmdInstallServices() +CmdInstallServices(void) { SC_HANDLE service; SC_HANDLE svc_ctl_mgr; @@ -146,7 +146,7 @@ static int -CmdRemoveServices() +CmdRemoveServices(void) { SC_HANDLE service; SC_HANDLE svc_ctl_mgr; diff --git a/src/openvpnserv/service.h b/src/openvpnserv/service.h index da20433..c5f587b 100644 --- a/src/openvpnserv/service.h +++ b/src/openvpnserv/service.h @@ -86,7 +86,7 @@ BOOL ReportStatusToSCMgr(SERVICE_STATUS_HANDLE service, SERVICE_STATUS *status); -LPCTSTR GetLastErrorText(); +LPCTSTR GetLastErrorText(void); DWORD MsgToEventLog(DWORD flags, LPCTSTR lpszMsg, ...);