From patchwork Sun May 18 17:23:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4257 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:16c2:b0:662:a395:de2b with SMTP id bp2csp262529mac; Sun, 18 May 2025 10:23:49 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUyP8oPeezr4KThbpp7yHPNgDRVlVwF3ZKrrmXbJbhz/33oSDD8VOP1bu42wD+A7zzDY3njj4oBjHM=@openvpn.net X-Google-Smtp-Source: AGHT+IEd0SoUHtxXojqA837UHUeSQ5TNINmQPAwM1LipqOImynPYIK8b+Ov3vYv4Qo9TFK1N4h7P X-Received: by 2002:a05:6870:4593:b0:29e:671b:6003 with SMTP id 586e51a60fabf-2e3c85db32amr5337947fac.32.1747589028820; Sun, 18 May 2025 10:23:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1747589028; cv=none; d=google.com; s=arc-20240605; b=Xg0ugsAfU5SIJ30ZQLoZODhiK9VKlc4mxHnk/6psOQTSRQgTXDmMpyEgjAlGhapXlO InWK5VC47mIBkf5S0wOvfQwtHK4tbBDCEcWjngHEWL9ts5ri1B203ImcCmCg0OmxltpM tjENtCYp1OPlC5g178+1B/cvMiX2Jair6df3gfNTg7DYhvCAIkJaB+adEgJ14vPbkmdR XXX3Dsk8jMBUXVRLBQx0/D9hotFlFfkglnxGPHz8rUDrjD+LI9VWZur6JjQYYF4ArEBT 4meOfvLgeLkybE9nh7AAn759hbBUPyIROAuKfOHI3OU5Wf0I+6ugnWulrNZnMLVmtz8g BjjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=wTs5L55mA7ZDPb1HfqUVV4mFpSlL2L05zLwlB51Px9E=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=D7rbQqcXnw/DJcIOOuTFkVDWHsSWD6K2V3kENUJFX8mXCuDbyLj5LIKWh7Ci/Hg63D z9d4ScflF6IKyXBSVQyrFC0I4SUGj5yLUEw7ku2Z76pNxMcvfna42IonSqXDGLS6EvFK pc4kZsKQL/m8eIvuum+0NJwld4/qQaljvBeOscKMXH+LZq8i0pGFFxEfYjWAfUTzlbEE MlXk4j2onh/ePvnsuUQAiSMxr4Q/U9fXFaDpW7NUEZP5VxuOvsBf2MqG2fCFPNFRFA+o E0GQpxt4xdKQDir83dAokVAQvJa1YHO8AAMJj3wlUatJPiY5/q7xIVe+Yzs8QquiQ9R8 v4Qg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ULWhLAxd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="Axuv/HSN"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bgyGhneK; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-2e3c0c27c3esi3490348fac.281.2025.05.18.10.23.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 May 2025 10:23:48 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ULWhLAxd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="Axuv/HSN"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bgyGhneK; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wTs5L55mA7ZDPb1HfqUVV4mFpSlL2L05zLwlB51Px9E=; b=ULWhLAxdQKcQVoqLucIQWyQror tqsBjR5ybZ9/pXcH8765KscpXnJrdqbt52UwXvBPbbJh2EgFtgfUjHiMBmA3XDBlJEgNkmAgs/KV1 7aorFslSjMlH9n0xswmetXahJjG+asdBmcmybsL/WcdP+XFXvKPq6YaKJf5IBqaVeLpc=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uGhjl-0005pc-RS; Sun, 18 May 2025 17:23:45 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uGhjk-0005pP-6L for openvpn-devel@lists.sourceforge.net; Sun, 18 May 2025 17:23:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8L9+QYeMkUbO1evMmp12BDJc19KpkTQPjjQp2U7OcAE=; b=Axuv/HSNAL68KYBclbnTCudO/w C43eB3oCDAaQzXRmcZYL1kbs3i5R2lRbBOq/H4N3a9a8tqTNBNiH6fQAHccfHMe9sHfmkyysPirNt AyvTMBRk7sEVxa++qReUb7SL82zEmDJULWc/fIm+1JFSCYQygOe/PqtiMWeL720eHkh8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8L9+QYeMkUbO1evMmp12BDJc19KpkTQPjjQp2U7OcAE=; b=bgyGhneKm4DFnEGHqfQwcpdhyO FOfGjfEp5h3+7QN7uygyqRdXV6O4Qi0qfjMmKhPFGrc3cIdCuyWtC7nOvU8OgqnICFmq+KGbNxw3x 1kQeK9Cz9n+YPVXUBmeXvSBagJf/KjLt9i43Vi0uChIN2YVi2peHaxWX1cH1sfTRQhI0=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uGhji-0004wY-Cv for openvpn-devel@lists.sourceforge.net; Sun, 18 May 2025 17:23:44 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 54IHNUEA021265 for ; Sun, 18 May 2025 19:23:30 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 54IHNUKH021264 for openvpn-devel@lists.sourceforge.net; Sun, 18 May 2025 19:23:30 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 18 May 2025 19:23:23 +0200 Message-ID: <20250518172329.21239-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Gianmarco De Gregori Check signals after timeout handling to avoid unusual delay when using explicit-exit-notify. Github: fixes OpenVPN/openvpn#702 Content analysis details: (1.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.143 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.143 listed in sa-accredit.habeas.com] 0.4 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Rejected by SPF record] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1uGhji-0004wY-Cv Subject: [Openvpn-devel] [PATCH v2] Explicit-exit-notify and multisocket interaction X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1832479913322023752?= X-GMAIL-MSGID: =?utf-8?q?1832479913322023752?= From: Gianmarco De Gregori Check signals after timeout handling to avoid unusual delay when using explicit-exit-notify. Github: fixes OpenVPN/openvpn#702 Change-Id: Id9dbb4d3c550bd4c13f6ee97e67749686457d9fc Signed-off-by: Gianmarco De Gregori Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/917 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index a673ec1..8e2c4d4 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -4265,13 +4265,13 @@ { /* process the I/O which triggered select */ multi_io_process_io(multi); - MULTI_CHECK_SIG(multi); } else if (status == 0) { multi_io_action(multi, NULL, TA_TIMEOUT, false); } + MULTI_CHECK_SIG(multi); perf_pop(); } }