From patchwork Sat May 31 20:47:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4271 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9994:b0:667:60b:5921 with SMTP id d20csp1755784mav; Sat, 31 May 2025 13:47:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXJgbACptqF9bkw46rXcd2OA7MutDOJPN6WqDwqQz6aNPASzLz4EmlyL47g0cxgwW9stDGXWL/Z2ME=@openvpn.net X-Google-Smtp-Source: AGHT+IHUgGQFaIZIYf7+m9gPvB/YHPkiNpi5qz7svnV/IdfzaclGed1TUwWvlWhzfilNmNyk5oR/ X-Received: by 2002:a6b:7f0c:0:b0:85e:73da:c56a with SMTP id ca18e2360f4ac-86cf2aa6d00mr1058402339f.3.1748724458608; Sat, 31 May 2025 13:47:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1748724458; cv=none; d=google.com; s=arc-20240605; b=jzB58KPviTz/ZICwWjk0jGRMFPojvX7J0J8HEKwNUPl5Fsl25HaSXPvpSCBU+ccRAl W/XwBpAmFoELsy4Pt6jAF9UND8LX+tBm1n84+83S3iuBEdkRPRW8cBeBGjH9lRS44OWv lD7I8kTQDhDX0pJZPT9xDWY9840e22Sw0bKVZqIH3EGDrvjxdPqkFUN04ig7ugxtEI8O QVDhJuoxuxen9cYwCnyEQk8wZWdDDj5yQCNOlHnJBe+pP1A5n8WCnRGaRvzyezc4Hl5N 2WJT41aKfETAIYgbx3M3wkd9Gzpnp08bp1ePVCAT7dElvzJ9EQIVM3t+6i1/hJhyWKW5 Vfgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=wfBzu5IyplpnmjbcO3QmultDuuKtr5sbOspEnIEzC60=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=HQK9Rbu7ZZxlv7uBrftPGBcu0F+MTUuSFfcf4S5ZgS97D3EywpiXgxp8RjTdgZHyOw vsWIxN9VkKStPZE09BJej/JJNFxtSa3jtbrn8cYdz0wmPJHk12oWCuHDQcuG6m0SRwDB JNaM7sE/csWAaaFPZWqmROnERhbm5xkyZMZGdj73j2IWS+CiesUT2jJ0s4IICcmW30T1 KJ9t7ala3oySuBj04t0xfj312bv6LXW3eh0oVsjSH2qoUuVUF91lHxx4wCzsVMaxIkkc 2e8zvljrwT4NTKcPz6+AMEh3EdwpL/5ef3XckwSwSNcUgI/qdLNpFDb8yVeWqCo0gyAn YbyQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=LrOzup0R; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jEOukcEP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=LhCGRcbj; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 8926c6da1cb9f-4fdd7f2a352si5621352173.139.2025.05.31.13.47.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 May 2025 13:47:38 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=LrOzup0R; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jEOukcEP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=LhCGRcbj; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wfBzu5IyplpnmjbcO3QmultDuuKtr5sbOspEnIEzC60=; b=LrOzup0Rpdxy26Ae3aYF9BRI4d TGdm0JiLOpMGXLnl9+Nh76N0j/CcptXRIM2Vx7t6imavNL1HlS79A4dxjqg/q59LnhuGcKP58W5ie kqGMf9YCzhcrU2Nbv9lEvPyz1Ph9pLpcwMe/WvFgTNkWcNgo1jP3Q+8+rpdy7wLo89eg=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uLT79-0003D6-TZ; Sat, 31 May 2025 20:47:35 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uLT78-0003Cz-4A for openvpn-devel@lists.sourceforge.net; Sat, 31 May 2025 20:47:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FncrtW3Omofcjla3B/UvzbDH0qP2OH0yjpCgfZNQmis=; b=jEOukcEPJWkau/khDnF9zEoq43 VDpz1BnDP6PwG6aKyRhE6ZgeQSwTA6e05jLWpUNH8EqySvCCzm6CHR1pZjFSlrnzXJ3Vi5XZhGOBz r6ONUa0Fdw1Cmxu21/3F59d1Sy95267UPXXBkAgIP5N0xmLyQIy56ZZ1LOj3/4UW4wBg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FncrtW3Omofcjla3B/UvzbDH0qP2OH0yjpCgfZNQmis=; b=LhCGRcbjWKD2xWSPcyvXi7Lsfh p5hHS3+h1EP95jQvg7Z2/29g2Qdb+3oPfQPh09pEPIoq7+OMEgbYDCf99k2lM6Z0koakkR357+dB/ GV7xXVeYO7HVkctMboWNINXw5KjtbhN+SBpKv17fOSYpUoWFdxLoD8W4qc0SJs+Kmosg=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uLT77-0002o1-0k for openvpn-devel@lists.sourceforge.net; Sat, 31 May 2025 20:47:34 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 54VKlLCx028181 for ; Sat, 31 May 2025 22:47:21 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 54VKlLiV028180 for openvpn-devel@lists.sourceforge.net; Sat, 31 May 2025 22:47:21 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 31 May 2025 22:47:14 +0200 Message-ID: <20250531204720.28156-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe make distcheck fails since we are not listing all headers that are used by the unit tests. Change-Id: I674af04e1a6449544b7def0725337c3b353ea276 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- Content analysis details: (1.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.4 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.143 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.143 listed in sa-trusted.bondedsender.org] 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Rejected by SPF record] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1uLT77-0002o1-0k Subject: [Openvpn-devel] [PATCH v4] Add missing header in unit tests Makefile.am X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1833365516351589185?= X-GMAIL-MSGID: =?utf-8?q?1833670498095335581?= From: Arne Schwabe make distcheck fails since we are not listing all headers that are used by the unit tests. Change-Id: I674af04e1a6449544b7def0725337c3b353ea276 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1033 This mail reflects revision 4 of this Change. Signed-off-by line for the author was added as per our policy. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/tests/unit_tests/openvpn/Makefile.am b/tests/unit_tests/openvpn/Makefile.am index fc47287..b47b495 100644 --- a/tests/unit_tests/openvpn/Makefile.am +++ b/tests/unit_tests/openvpn/Makefile.am @@ -43,7 +43,8 @@ argv_testdriver_CFLAGS = -I$(top_srcdir)/src/openvpn -I$(top_srcdir)/src/compat @TEST_CFLAGS@ argv_testdriver_LDFLAGS = @TEST_LDFLAGS@ -L$(top_srcdir)/src/openvpn -Wl,--wrap=parse_line -argv_testdriver_SOURCES = test_argv.c mock_msg.c mock_msg.h test_common.h \ +argv_testdriver_SOURCES = test_argv.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/platform.c \ $(top_srcdir)/src/openvpn/buffer.c \ @@ -52,7 +53,8 @@ buffer_testdriver_CFLAGS = -I$(top_srcdir)/src/openvpn -I$(top_srcdir)/src/compat @TEST_CFLAGS@ buffer_testdriver_LDFLAGS = @TEST_LDFLAGS@ -L$(top_srcdir)/src/openvpn -Wl,--wrap=parse_line -buffer_testdriver_SOURCES = test_buffer.c mock_msg.c mock_msg.h test_common.h \ +buffer_testdriver_SOURCES = test_buffer.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/win32-util.c \ $(top_srcdir)/src/openvpn/platform.c @@ -61,7 +63,8 @@ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \ @TEST_CFLAGS@ crypto_testdriver_LDFLAGS = @TEST_LDFLAGS@ -crypto_testdriver_SOURCES = test_crypto.c mock_msg.c mock_msg.h test_common.h \ +crypto_testdriver_SOURCES = test_crypto.c \ + mock_msg.c mock_msg.h test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_mbedtls.c \ @@ -78,8 +81,10 @@ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \ @TEST_CFLAGS@ ssl_testdriver_LDFLAGS = @TEST_LDFLAGS@ $(OPTIONAL_CRYPTO_LIBS) -ssl_testdriver_SOURCES = test_ssl.c mock_msg.c mock_msg.h test_common.h \ - mock_management.c mock_ssl_dependencies.c mock_win32_execve.c \ +ssl_testdriver_SOURCES = test_ssl.c \ + mock_msg.c mock_msg.h test_common.h \ + mock_management.c \ + mock_ssl_dependencies.c mock_win32_execve.c \ $(top_srcdir)/src/openvpn/argv.c \ $(top_srcdir)/src/openvpn/base64.c \ $(top_srcdir)/src/openvpn/buffer.c \ @@ -114,7 +119,8 @@ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \ @TEST_CFLAGS@ packet_id_testdriver_LDFLAGS = @TEST_LDFLAGS@ -packet_id_testdriver_SOURCES = test_packet_id.c mock_msg.c mock_msg.h test_common.h \ +packet_id_testdriver_SOURCES = test_packet_id.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/otime.c \ @@ -156,7 +162,8 @@ -Wl,--wrap=buffer_write_file \ -Wl,--wrap=parse_line \ -Wl,--wrap=rand_bytes -tls_crypt_testdriver_SOURCES = test_tls_crypt.c mock_msg.c mock_msg.h test_common.h \ +tls_crypt_testdriver_SOURCES = test_tls_crypt.c \ + mock_msg.c mock_msg.h test_common.h \ mock_win32_execve.c \ $(top_srcdir)/src/openvpn/argv.c \ $(top_srcdir)/src/openvpn/base64.c \ @@ -229,7 +236,8 @@ @TEST_CFLAGS@ $(OPTIONAL_CRYPTO_CFLAGS) pkcs11_testdriver_LDFLAGS = @TEST_LDFLAGS@ \ $(OPTIONAL_CRYPTO_LIBS) -pkcs11_testdriver_SOURCES = test_pkcs11.c mock_msg.c \ +pkcs11_testdriver_SOURCES = test_pkcs11.c \ + mock_msg.c test_common.h \ pkey_test_utils.c cert_data.h mock_get_random.c \ $(top_srcdir)/src/openvpn/xkey_helper.c \ $(top_srcdir)/src/openvpn/xkey_provider.c \ @@ -251,7 +259,8 @@ auth_token_testdriver_LDFLAGS = @TEST_LDFLAGS@ \ $(OPTIONAL_CRYPTO_LIBS) -auth_token_testdriver_SOURCES = test_auth_token.c mock_msg.c \ +auth_token_testdriver_SOURCES = test_auth_token.c \ + mock_msg.c test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_epoch.c \ @@ -269,7 +278,8 @@ @TEST_CFLAGS@ user_pass_testdriver_LDFLAGS = @TEST_LDFLAGS@ -user_pass_testdriver_SOURCES = test_user_pass.c mock_msg.c \ +user_pass_testdriver_SOURCES = test_user_pass.c \ + mock_msg.c test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/console.c \ $(top_srcdir)/src/openvpn/env_set.c \ @@ -287,7 +297,8 @@ ncp_testdriver_LDFLAGS = @TEST_LDFLAGS@ \ $(OPTIONAL_CRYPTO_LIBS) -ncp_testdriver_SOURCES = test_ncp.c mock_msg.c \ +ncp_testdriver_SOURCES = test_ncp.c \ + mock_msg.c test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_epoch.c \ @@ -306,7 +317,8 @@ misc_testdriver_LDFLAGS = @TEST_LDFLAGS@ -misc_testdriver_SOURCES = test_misc.c mock_msg.c \ +misc_testdriver_SOURCES = test_misc.c \ + mock_msg.c test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/options_util.c \