From patchwork Wed Jul 16 15:18:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 4311 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:d91b:b0:671:5a2c:6455 with SMTP id lg27csp234959mab; Wed, 16 Jul 2025 08:19:25 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWrR2372SwGFLvzBiJ00FyjDW1JX2zPBfxW9SzbAADl1oo1UUFyiKTwmT6jFPZ4qRIsLrSWt10W+ow=@openvpn.net X-Google-Smtp-Source: AGHT+IEcBM1xx9lPeLb8AkLC3Jq3gJceWkxox7/qD3XOdodpsBCB6/Z/cMld+ieJd5x1r/IcyMrZ X-Received: by 2002:a05:6830:64ca:b0:72b:9de0:891 with SMTP id 46e09a7af769-73e662c19d4mr2486495a34.13.1752679164796; Wed, 16 Jul 2025 08:19:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1752679164; cv=none; d=google.com; s=arc-20240605; b=ga2tm1kq0izIfcdQAh5EQkKqwDqsstOOxCKbxTHFB73FwDEpwNRX/y4ns2/4xxEy5P 7j2WvgexuGXe5cKNp2WueU7gncRKjFjZw6+Q6shV4rAb9QUuQrPy/5MyQV39/q1XVre1 WUlAgj3aZ/U+XnaE9uPjtXGuTtBRWrgAl56xZg7aenw9YnXRIkbN/yusk0y5IQmdeXD2 65m4F2qihICwHCBDLckqzS7ojW4OtC+N/lyDSvPNOOpLFstz7ZAwsDNygjw7fV/YKbNQ gYMcfd612CwXyloaHS9GHSZHekHsLTmfLUvhHjO04ar4kj6me006R8jrFjg/M7tnzmNX SMOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=w9gspKtTygaT+xvSf8B/Qu/WAd5iWAbqa4asftih3zw=; fh=CfxSpwd5kfiMJoL3kcov7PTxVKT7pGe/79idnx9XlBs=; b=kHH10+RlUPuVerwd/qG87h2EQobtgjHZo+Bi4kaqJnULmLp8Iadeg7K7x6M6QNciT7 huRr4Ogn7ox8FxYmXVGBsEhkRRgtQhF3w42Q7H+XaQ/36AjMzKHz/54meDqrcDtQ7q/h zc5pEz+cFc0omUO36Z71WEI7GE/M3u55IBSuFybVkvfWohC3NCpD3vhTqQWXkuecru+G b8H+o+wPNuSZRnhIe6v/le8byzPyo++0EZxT5HGXMzqY0Qciiilmt/cYe9LZl1Z/8QaY 2mDtk+XYU79B+7EATmh75Cx0mEEYUCck9q5yG2CwYFBL8kNKpCKBJdE/RpCM+J8aD4JK zXZw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=BPt3vEo6; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="NXAN1Z/4"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FmiDnKFg; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=fLB63XKD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-73e71afe251si88489a34.280.2025.07.16.08.19.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jul 2025 08:19:23 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=BPt3vEo6; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="NXAN1Z/4"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FmiDnKFg; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=fLB63XKD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-Id:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w9gspKtTygaT+xvSf8B/Qu/WAd5iWAbqa4asftih3zw=; b=BPt3vEo6kQWOENRCpR/uOfn6mm KqBeHnWVxvTkyLsKf/OhCtiFQtZFizAZkPT1zsgmD6ckPWJv6n6P91JFTdZphf4w0hMwfBAGL7jbH 6gpA2bzL/a6ykvT7kxamhy6ln8+3I4KnSgL5K6foqOqqcFAvRpLQhVZwZCaNaEe9rVpY=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uc3ug-000862-UW; Wed, 16 Jul 2025 15:19:18 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uc3uc-00085r-Se for openvpn-devel@lists.sourceforge.net; Wed, 16 Jul 2025 15:19:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bRzQxspfi369VMgP4pUd2caZvOdfqoBjlRqoefCl6dE=; b=NXAN1Z/4BEAokpWUUcDhP5svIq y+Cu6VAHDhv9gH7OnYXXp8XfSneOiaZNc4c8f81l8ju/ZlZb07vsg6dFNctG4IEfB9KTcB+t6GENa LorgcCaEP+/ii1km/nY9IpoNdO9i25bF23XU7um435FH1rG8IFoUNQKyWXmaS1Zxjo1o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bRzQxspfi369VMgP4pUd2caZvOdfqoBjlRqoefCl6dE=; b=FmiDnKFgCbY+jD6ASvl6NhHINx hANztgwGvSKpIdeb81MGDcogAaMsgVAHsi/EKhths+3AmQNyfm6j2p2ORuTPwMXaRFCgk7at7lXNV YlWEcecuk1q0Lsl1sfLahDsMiyyynB501M4xnAS0fXVO4EEokxpKvAd0YwS20utpbg7E=; Received: from mout-p-201.mailbox.org ([80.241.56.171]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uc3ub-0007Rf-Dc for openvpn-devel@lists.sourceforge.net; Wed, 16 Jul 2025 15:19:14 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4bj0834hHCz9sjY; Wed, 16 Jul 2025 17:18:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1752679139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bRzQxspfi369VMgP4pUd2caZvOdfqoBjlRqoefCl6dE=; b=fLB63XKDO5M7mlV9b3slki9SmIuMHmtSP9cHSl6R4s/XtogtbCa+OjYp/LL30nk1oCdB/q J0CbHrhKs0DLzr1hTk7mGzvEcwFuqs8B2hDGwg7cZuuqwECqMe2MwLbBAHrZ0E2CNCEe9K RmZoEQI183Qb7q50l6V1Ln0Hzt+G/PRaeRSdCpuCH/1YQp+rphJa5kbzpF+lCQzo2DNI38 l6AQDq/rGrxCP4k+UKAyvUS67GmJixvYP9XL1HMDmRD4kkWYNw17oSUbZlwVTA3BuFm4PB GQHRA64m5/9/DQ/Xu0fMugGzNuzMMtxT5v5w4TNtEwosS4J8P+8UZ1F1+Y++Zg== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of frank@lichtenheld.com designates 2001:67c:2050:b231:465::202 as permitted sender) smtp.mailfrom=frank@lichtenheld.com From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Wed, 16 Jul 2025 17:18:57 +0200 Message-Id: <20250716151857.385959-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4bj0834hHCz9sjY X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This code was copied over and over since many years, since commit 9a3f670248d6f519a399e65a7232e2196b5115db ("Fixed autoconf script to properly detect missing pkcs11 with polarssl"). It is unclear what [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-Headers-End: 1uc3ub-0007Rf-Dc Subject: [Openvpn-devel] [PATCH v1] configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arne Schwabe Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1837817306572931194?= X-GMAIL-MSGID: =?utf-8?q?1837817306572931194?= This code was copied over and over since many years, since commit 9a3f670248d6f519a399e65a7232e2196b5115db ("Fixed autoconf script to properly detect missing pkcs11 with polarssl"). It is unclear what exact purpose it served back then but probably it is obsolete. It is definitely wrong since it means that you get PKCS11_HELPER_LIBS even if you do not specify --enable-pkcs11. Change-Id: I317be5253d6563906dd3826421dc81f737beba76 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1088 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/configure.ac b/configure.ac index 8fc48ba..66cb79b 100644 --- a/configure.ac +++ b/configure.ac @@ -798,14 +798,6 @@ ;; esac -PKG_CHECK_MODULES( - [PKCS11_HELPER], - [libpkcs11-helper-1 >= 1.11], - [have_pkcs11_helper="yes"], - [] -) - - if test "$enable_dco" != "no"; then enable_dco_arg="$enable_dco" if test "${enable_iproute2}" = "yes"; then @@ -1014,13 +1006,12 @@ [mbedtls_ssl_init], [MBEDTLS_LIBS="-lmbedtls -lmbedx509 -lmbedcrypto"], [AC_MSG_ERROR([Could not find mbed TLS.])], - [${PKCS11_HELPER_LIBS}] ) fi fi - CFLAGS="${MBEDTLS_CFLAGS} ${PKCS11_HELPER_CFLAGS} ${CFLAGS}" - LIBS="${MBEDTLS_LIBS} ${PKCS11_HELPER_LIBS} ${LIBS}" + CFLAGS="${MBEDTLS_CFLAGS} ${CFLAGS}" + LIBS="${MBEDTLS_LIBS} ${LIBS}" AC_MSG_CHECKING([mbedtls version]) AC_COMPILE_IFELSE( @@ -1359,7 +1350,12 @@ AM_CONDITIONAL([HAVE_SOFTHSM2], [false]) if test "${enable_pkcs11}" = "yes"; then - test "${have_pkcs11_helper}" != "yes" && AC_MSG_ERROR([PKCS11 enabled but libpkcs11-helper is missing]) + PKG_CHECK_MODULES( + [PKCS11_HELPER], + [libpkcs11-helper-1 >= 1.11], + [have_pkcs11_helper="yes"], + [AC_MSG_ERROR([PKCS11 enabled but libpkcs11-helper is missing])] + ) OPTIONAL_PKCS11_HELPER_CFLAGS="${PKCS11_HELPER_CFLAGS}" OPTIONAL_PKCS11_HELPER_LIBS="${PKCS11_HELPER_LIBS}" AC_DEFINE([ENABLE_PKCS11], [1], [Enable PKCS11])