From patchwork Sun Aug 3 14:49:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4347 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6302:b0:671:5a2c:6455 with SMTP id a2csp858288maf; Sun, 3 Aug 2025 07:50:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU7Ug1a5UuigtcuzYxeqdV+ZRlypRaikwumO+2Oh9TE1gj5/Dfvklf/4arkoQnifSJ7ddDfXtn034A=@openvpn.net X-Google-Smtp-Source: AGHT+IFQlrMCkdsy3f7O6DCxey6XP4tN7Fi4dqitdrZukQOOZXBJPLPJLoNDJ4daKtVvjNxjvt+0 X-Received: by 2002:a05:6830:3496:b0:741:2b89:4819 with SMTP id 46e09a7af769-7419d1512f4mr3607892a34.12.1754232606170; Sun, 03 Aug 2025 07:50:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1754232606; cv=none; d=google.com; s=arc-20240605; b=W9r7OsqMwyxikAD2oOCHwS2zqbOhXK+004GpQrkffUVncyG82plOXerGQOM40e0sue P84eJ6s7Bej5mn8CtdmHhBnFwOPFlr/HnDioq9fldvz5tVMA1y9GQLbORlklJY66kfKH mMvb/3lv5mizQmEXruRyXfH1kovkAA9K+6Rffaj0/AmUI0kuEbYTzH736Q9UUyMzcAzt /RO2GQMyjmiO1lGqv0IhC55mIsDAK8cBfDBBdNyKja3DcpUQROgD5ndMJVfmI2wo0ns1 QWIQHdh6ZIWB7wWyuX2JXH7WLax17ppl9L6XqchHQV6pdfsibtavkzzC8jTjnOETQAHc OXEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=lT0rvXzJF8+Re22kf8OY2+OHzHXOk88IxjP5fdaQJ7M=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=CTO+1DfMjB8uiGcGmR76vUABqNueyu/EMAEeJTIpM8K7iQhPY8S0s+t6n+6utGw5pr ewFgXoWz1Lr0nnF9H/LbHOFFEI8uCduTj/npKWVOFIxBp0uDqqIlxtH5RwlNffq0KbAo +L11JboVtTrzchy6AVw1zpjJx1Zdx+VHiCU4CL5eM3LfFoVWMY8wIRftTlApJPDxo9KN 6RoDWpA3k4t607nsTKOTqSH+qEde0jINVg2Q45s7zSHbgUWzILyCEWFx5W4SX2xxbgQb GaWZ1SKgJtQKzaWvOEbap1pEiiEv7alL00ZUDjhoDqKG+I1onZ+7JG4EUDEgOSYlHGcu A2QQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=XyUZPsXq; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dLGDBAUX; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=e0MuULF8; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-741bc4331bdsi77346a34.131.2025.08.03.07.50.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Aug 2025 07:50:06 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=XyUZPsXq; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dLGDBAUX; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=e0MuULF8; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lT0rvXzJF8+Re22kf8OY2+OHzHXOk88IxjP5fdaQJ7M=; b=XyUZPsXqlDv9rcuxCSAXC3HgsC Gf0nGm/LekMBGrgqGQ5/d7MhTkijXljcsv8nGF5XLSFO845OxzT3Me2+k2x5E2jkZPkm7eeJmyrr2 ncqn8asyoEEZJu7qIUEbj2/cRzk36NWYPn/kRxYgWefL3EmAAFTeb4fe1HspgkTP6NAo=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uia2G-0003Kn-Hw; Sun, 03 Aug 2025 14:50:04 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uia2F-0003Ke-8y for openvpn-devel@lists.sourceforge.net; Sun, 03 Aug 2025 14:50:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RvPImHy53WPO/1/A7xrjHbQ7m70cTbsSH+EL235yX/Q=; b=dLGDBAUXVHmLBzjOMhXIIazq34 Dct7CjQiV4pmiH7ovB3zLKW8ZBzrQutU8C5c7HjqqzlrlbUxNF933tpaOnTjRZKpLISTee/kQB3YL phQmpN4r4l9vLho5gDiEYfzheKKxtBvuiqpwMVp1LEmuB8QwEHl3/Zqga7eKcbBBDwEc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RvPImHy53WPO/1/A7xrjHbQ7m70cTbsSH+EL235yX/Q=; b=e0MuULF8GABJ+DXfISGQ2Dm9jj Ui9BEUwUNWYAniERX9iXQwdKJtx6sa4EFuYzqKcOl5b+OGlLwoh+mw/ljkVU0sOPgMDV1//BDfr8F sIEFUe8OH1O5ns63W+mGnZoQmbV54mKecfk8+j/opsLpIsuwFg9oNaMLT3NQ+9r+HSH8=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uia2E-0006WM-IF for openvpn-devel@lists.sourceforge.net; Sun, 03 Aug 2025 14:50:03 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 573EnpJD021090 for ; Sun, 3 Aug 2025 16:49:51 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.17.1.9/Submit) id 573EnpCn021089 for openvpn-devel@lists.sourceforge.net; Sun, 3 Aug 2025 16:49:51 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 3 Aug 2025 16:49:45 +0200 Message-ID: <20250803144950.21034-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Lev Stipakov Unlike other ways of setting DNS, we don't log anything when we use NRPT. Since dco-win/--dns is the recommended configuration and it uses NRPT to set DNS, let's log it. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1uia2E-0006WM-IF Subject: [Openvpn-devel] [PATCH v1] Log setting DNS via NRPT X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1839446208881180943?= X-GMAIL-MSGID: =?utf-8?q?1839446208881180943?= From: Lev Stipakov Unlike other ways of setting DNS, we don't log anything when we use NRPT. Since dco-win/--dns is the recommended configuration and it uses NRPT to set DNS, let's log it. Change-Id: Ib2f30fe69cb676e347e4d59cd2db68db7568ba5b Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1126 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/dns.c b/src/openvpn/dns.c index ea3d91b..e079cd0 100644 --- a/src/openvpn/dns.c +++ b/src/openvpn/dns.c @@ -461,6 +461,11 @@ make_domain_list("dns search domains", search_domains, false, nrpt.search_domains, sizeof(nrpt.search_domains)); + msg(D_LOW, "%s NRPT DNS%s%s on '%s' (if_index = %d) using service", + (add ? "Setting" : "Deleting"), nrpt.resolve_domains[0] != 0 ? ", resolve domains" : "", + nrpt.search_domains[0] != 0 ? ", search domains" : "", + nrpt.iface.name, nrpt.iface.index); + send_msg_iservice(o->msg_channel, &nrpt, sizeof(nrpt), &ack, "DNS"); }