From patchwork Thu Aug 7 20:37:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4361 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:fd13:b0:671:5a2c:6455 with SMTP id cw19csp1117899mac; Thu, 7 Aug 2025 13:38:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUUTMW0xpybt8TzT9pxoN0r5CAeQ3ekRpChVdmwO5zr3eb8CoqsqMXALNRgpRO53oeK41LRuUZKbEM=@openvpn.net X-Google-Smtp-Source: AGHT+IGqbAu3n2vbhNkH1zo8Fg1TRVL7lEZUOPUgdXvwkoJnnrS0K/vuJwX1pAvhuPqwxKMY1Pc2 X-Received: by 2002:a05:6830:4696:b0:72b:8297:e988 with SMTP id 46e09a7af769-7432c902783mr255788a34.25.1754599084543; Thu, 07 Aug 2025 13:38:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1754599084; cv=none; d=google.com; s=arc-20240605; b=blVEkykw3JfZnrYa8CZNrebaKpfiHVGmlmF0vqpTpO1oAa7OONqzkbhw4yGDMUF9Or /BP/6GUYBRaZ8AKxdxq2ilQxNnxhO0H/wGQ/7K9x48vY33/9XNl+cui4CVnXKGY8TWJR 6siqqPd7Om0ldBKtcUOJVMI7mcNIdYCSi1ROHuBauZMgpOQ7S7M0zTw0WuCA7VZHUoNX kPeQ4Yi0AG6FLcVncxxf4kQDi6O2agaHgsOMsHPRYpz4xORT8ZKBeeDuUVFSFC9YJG8g DQviNozdHomsI0HSh8aSc0D9xCSLyF4SLnfYiB96MLoYJ6QDriS74OhMtXg7QZ0igswA u7jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=whDr6LLkNel/y3Mh6czY9L1XYO7Fr6vw41es0/4sDjI=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=SaAmFeJ28l0GthQEgRy5YHs4qseJfhwCH14hGJw595Ts7Xh6b5EzRKjJcCZPwwrLfh Fdx3Lk/du/6PlEpM8RigrQ3DV2CV6JoELSiSL66o60vieDU/qHmEQ+vqFqDOXoS+5Pyc CWvGS7Po8rPz3J2rof3sQijSBYVciPdBhRlw6D1No5G9KxtI91oV05aTyJsyDSFm2v5p VoFeNDD1FKAA6mN+VhqRZjG8Ah3CvC/FLG2VfyI3gpGFD3FwHvlsdGYJsseh7AXJBz0T Dj4HKskcRT4+ywPkS/HOGvRMOYzW4wtVOrhSA6w9rdnaG9Mu7G3N5pdWXHCUquM7ovjF iwew==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ivwdEUI8; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=JMiXRpH4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=b7mS7CsG; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-74186e05e5dsi5042452a34.338.2025.08.07.13.38.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Aug 2025 13:38:04 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ivwdEUI8; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=JMiXRpH4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=b7mS7CsG; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=whDr6LLkNel/y3Mh6czY9L1XYO7Fr6vw41es0/4sDjI=; b=ivwdEUI8p+LPSUqrd3JK3SUjIF k4HgoXBIlfd5tODgETvgmwETolgvdzpACDMiO36M7cHo1/Cqpde20Y77YaJr/i5xvCdp+wzxW8vYy S2RNMVQNMQeF3nTbIog66e7JhnsM/o9UCdXWOZXeTlYa8gswV972Xbtiq/ba2ksH1mDk=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uk7NB-0000xv-J0; Thu, 07 Aug 2025 20:38:01 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uk7N9-0000xk-Vc for openvpn-devel@lists.sourceforge.net; Thu, 07 Aug 2025 20:37:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fgMdKk+Yn3S31oAazANC1mLUIHPACQu8xl3wJa2NDfQ=; b=JMiXRpH4CYy0hAtttfNMIuKnlg orF9UTAMDb86pjUWjTlUDU3ZgJd+mXHstl0Y9fPe1voxCBge+krwoWXTQMS3Ge9o2STPoFtSxVdjq 7I7IQ29bGvfGPyBd1WqMW0i3XFpIbTmDjHoGCtyJDDsDiG1B/cZJGzHfx/a0fHoybzZc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fgMdKk+Yn3S31oAazANC1mLUIHPACQu8xl3wJa2NDfQ=; b=b7mS7CsG5qSsdfus50BQjfEWuh sx3wDl+hLXlhx8w4f50PwFYeMTSaZx+zLkikoTyc4AbBUDq94hyvCZQm4OfsgCw7+f6ydeYSXKpnv xmm+qw+bistOIztFF9gv56hqwN+q6WoKVkdqzBbV8/iaHjBTjwxfVSS6ydQWyw11x/KM=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uk7N4-0007y6-2L for openvpn-devel@lists.sourceforge.net; Thu, 07 Aug 2025 20:37:55 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 577KbfoE031384 for ; Thu, 7 Aug 2025 22:37:41 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 577Kbf85031383 for openvpn-devel@lists.sourceforge.net; Thu, 7 Aug 2025 22:37:41 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 7 Aug 2025 22:37:35 +0200 Message-ID: <20250807203741.31359-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld On most machines 1 second should be quite enough. Given that we run currently 23 tests on most t_client runs, this makes over 40 seconds difference. Not nothing. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1uk7N4-0007y6-2L Subject: [Openvpn-devel] [PATCH v2] t_client.sh: Do not wait 3 seconds for OpenVPN to come up X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1839830489231609999?= X-GMAIL-MSGID: =?utf-8?q?1839830489231609999?= From: Frank Lichtenheld On most machines 1 second should be quite enough. Given that we run currently 23 tests on most t_client runs, this makes over 40 seconds difference. Not nothing. We keep the existing 30s maximum wait-time since sometimes we want to do tests with intentionally slow servers. Change-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1139 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in index 7a271b6..a49de40 100755 --- a/tests/t_client.sh.in +++ b/tests/t_client.sh.in @@ -377,13 +377,13 @@ $RUN_SUDO "${openvpn}" $openvpn_conf >>$LOGDIR/$SUF:openvpn.log & sudopid=$! - # Check if OpenVPN has initialized before continuing. It will check every 3rd second up + # Check if OpenVPN has initialized before continuing. It will check every second up # to $ovpn_init_check times. - ovpn_init_check=10 + ovpn_init_check=30 ovpn_init_success=0 while [ $ovpn_init_check -gt 0 ]; do - sleep 3 # Wait for OpenVPN to initialize and have had time to write the pid file + sleep 1 # Wait for OpenVPN to initialize and have had time to write the pid file grep "Initialization Sequence Completed" $LOGDIR/$SUF:openvpn.log >/dev/null if [ $? -eq 0 ]; then ovpn_init_check=0