From patchwork Mon Sep 1 19:45:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4384 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:2a1c:b0:671:5a2c:6455 with SMTP id k28csp1380977maz; Mon, 1 Sep 2025 12:45:49 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU0EL18ZwE1Y69Q6gmJdeg9zBgy7JoQhem0nh+/vsF4+jBo4RaNxZhE/Lnx7yZchtRh9XIjl5hlRvw=@openvpn.net X-Google-Smtp-Source: AGHT+IGC2UmhuFW1BsVrO9oi3E8LjggHdXLZLnvRDs+urtC1ydXtNOOvf7hSqW5QWUiA/pyTCT16 X-Received: by 2002:a05:6808:1528:b0:434:d23:b7fa with SMTP id 5614622812f47-437f7cc10d1mr4138675b6e.10.1756755948983; Mon, 01 Sep 2025 12:45:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1756755948; cv=none; d=google.com; s=arc-20240605; b=HmXT/doHCvFg0bZ8Oxwi/7qCdwH5HR8r6YQMpJJ35xnG5syqHt8NGMsRaa0R8zLrY/ fpjTTJRF5/9RiepOwkAIabaN2/BeKdJwbpjtQWl7D62mj/aW6V68jmf+5MP8Q6Tyx1JF 8ApiBguoUdThtaW15rGafndczJSds8st4zILTG6Ou6fluvxdvAiPUBhhiMUwTjmUkgEN 0OMw49BrxSG3A1X9XrUd50QRTQyaWhU4RYRcCG55qTu7RN/COK/E9MYEPSLx/A782jl5 tdQXN2d5HcFG1FUs3V2CzI1sPYvB9tLqId+P1pf2sE+fqPW/cnGPVoAIVxuSW98jHwvz /SrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=sKYWMo0/4+REgogogshk4iSvC6FVukpTuu+NdrKJIgw=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=W4vMwh3fpknjBlIILbi6tBBNTT0LBrD3eoYNTSESBbobpQXsB5jdqgBu/kXNB4UfEg ix5Lvnb+BS76qXxoaOZwqw7Nt64adQphy/DTiid/w5vRsGEcwGQf7gxIlB6X9DfGCd/h FVxp8yMEuLYUFIz39JKvnWC0A67WgdYEe4C8cUiLT7341W4QzYItUxkY3u86aR+VVcOB QZRwS8yksBBvT3xTqgdpayFqZSoAy3DKZvCLwTEfkx6nZO+8L7cQdo65ubuiVfM2nvKE z9xK5c5L+f5UfnNgxEN+yAPZWbDLb5vbwD581UN2g8GbPSeTsLedL1bOpO4UzdkAP3n3 IYiw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=D7Yvtmr5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="aTv8DJl/"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=m8pqaDFt; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-437ffe8cc67si815123b6e.50.2025.09.01.12.45.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Sep 2025 12:45:48 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=D7Yvtmr5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="aTv8DJl/"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=m8pqaDFt; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sKYWMo0/4+REgogogshk4iSvC6FVukpTuu+NdrKJIgw=; b=D7Yvtmr5+sLMzXshsNBvg9bYv0 dVki9NdTXycKijFOZOR/uuRW3eDmbko9HMBRz96P23I/AQ4wm33OL1jTVPbmr7aMtAFuzc+uZvtZz dZluB6jdBJpFi665t8DDF8qQCF5abXfLW4rdWDPMy7DFx5cEIa/K5RdGLyHGe9rFRuYQ=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1utATJ-0005RG-IY; Mon, 01 Sep 2025 19:45:46 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1utATI-0005R1-Be for openvpn-devel@lists.sourceforge.net; Mon, 01 Sep 2025 19:45:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VnoxjEC3T+NaD4iDzCWmQPW30yGyIddGyYSo8sc19Kw=; b=aTv8DJl/3uEe/goCyCMuCQpm8B lyeaNEjjbljqavXv+145GCEDnWLSc/d9iCsv6T4MOqDM7OGy15s7fvRxsnfx5y7Qnk09Xoesk7AW0 AAKlI1Zks20GNWiV1fRESGiHliZxHOKOItJKjNyrpvs2zPh/ooBWmCtaMUBFLPk8ozmY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VnoxjEC3T+NaD4iDzCWmQPW30yGyIddGyYSo8sc19Kw=; b=m8pqaDFtK9xFD+p1bp6eMYNPJX hz5OlfkPMYpUlAF59JuOqC9AlmDBgiB7zzjXtuRdnHa7wSJUJvp+5Z5MVWs1gwYXJ+lFb2b74D+gY qrK6xGvA22/7D0Nfp/1Z21yczW6Kty8ITmTw6dO0oF18hDc82TQheW0iVtqrrZDFQGqA=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1utATH-0008T6-Se for openvpn-devel@lists.sourceforge.net; Mon, 01 Sep 2025 19:45:44 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 581JjW1f013699 for ; Mon, 1 Sep 2025 21:45:32 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 581JjV4u013698 for openvpn-devel@lists.sourceforge.net; Mon, 1 Sep 2025 21:45:31 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 1 Sep 2025 21:45:25 +0200 Message-ID: <20250901194531.13683-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld process_ip_header already expects them to be unsigned, make sure the flags are to avoid spurious conversion warnings. Change-Id: I6d42c67b8dc5512933bed482bd9c2be80c63e993 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [193.149.48.143 listed in list.dnswl.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1utATH-0008T6-Se Subject: [Openvpn-devel] [PATCH v10] forward: Make sure pip flags are treated as unsigned X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1842092125672882111?= X-GMAIL-MSGID: =?utf-8?q?1842092125672882111?= From: Frank Lichtenheld process_ip_header already expects them to be unsigned, make sure the flags are to avoid spurious conversion warnings. Change-Id: I6d42c67b8dc5512933bed482bd9c2be80c63e993 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1108 This mail reflects revision 10 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/forward.h b/src/openvpn/forward.h index d564149..79d0f8b 100644 --- a/src/openvpn/forward.h +++ b/src/openvpn/forward.h @@ -314,13 +314,13 @@ */ void reschedule_multi_process(struct context *c); -#define PIPV4_PASSTOS (1 << 0) -#define PIP_MSSFIX (1 << 1) /* v4 and v6 */ -#define PIP_OUTGOING (1 << 2) -#define PIPV4_EXTRACT_DHCP_ROUTER (1 << 3) -#define PIPV4_CLIENT_NAT (1 << 4) -#define PIPV6_ICMP_NOHOST_CLIENT (1 << 5) -#define PIPV6_ICMP_NOHOST_SERVER (1 << 6) +#define PIPV4_PASSTOS (1u << 0) +#define PIP_MSSFIX (1u << 1) /* v4 and v6 */ +#define PIP_OUTGOING (1u << 2) +#define PIPV4_EXTRACT_DHCP_ROUTER (1u << 3) +#define PIPV4_CLIENT_NAT (1u << 4) +#define PIPV6_ICMP_NOHOST_CLIENT (1u << 5) +#define PIPV6_ICMP_NOHOST_SERVER (1u << 6) void process_ip_header(struct context *c, unsigned int flags, struct buffer *buf,