From patchwork Mon Sep 22 08:02:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4431 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c08a:b0:72f:f16c:e055 with SMTP id jr10csp32996mab; Mon, 22 Sep 2025 01:03:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUuK4TlxB0WJWm7v/635frYXh9Swommc3hiavcfGSUz7+u4wtOS4e3ZgHjWOph5l6X7TnyrN42J92Q=@openvpn.net X-Google-Smtp-Source: AGHT+IGSSbScP8cCtSMy1gZJ3yv/VZq9Uig6ASNE7u8cW6c5PoSpXTMtcPGxrah0TqnvJIeVh4QB X-Received: by 2002:a05:6870:353:b0:315:3103:6e7a with SMTP id 586e51a60fabf-33bb67fa8dfmr5960277fac.43.1758528207080; Mon, 22 Sep 2025 01:03:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758528207; cv=none; d=google.com; s=arc-20240605; b=RRG16Q9jR16g40A38x4Yl95/J4OnxDYISdTnup0i/nzZi+/zVH2gEKzSh51KFIJdh1 W6WC6UDwf9ObjlJL52pWkGagF7TN1JR90/BkDd1YsEG5Nb3GaElRwem2VTPIJnTUsE0F D63KNJciZYBlG/J0Q/og2A8FpgK2wMeFc0FKId/d9+xvRTXzL9Dw8DcscqGCuh7Dk6fF M8GpIaEeP/P6Lwxt8CvmToaGEpoj4krGc28I8PSbREO7SuCw+DsTJLOKwpIHo1sLTk9u 4y5ITLLqrynRKDRMsHTQPRnheEWg9OLfr4T0N7xBXTvDEBSf4prfYG6zSItvCy0OhXik afHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=gjmNtWBmp8vgeAwXWSAUCPbShN1yzdJVjlF3lDlcNng=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Gii+E4QoRg16qUE8YK0bB/wV/YNDJlz110CsDf+iXpwJWTGedbGyWSG561hpNRWxXx MlPF143/C8TbJViP6AHbwXAaN/GRgftoeoERSsbukYb40qDaWGq9Pl7w5rkTcXQPj23C ZzEf4G+MGSL8czXUHjS90mJRhRNfBO/dh5FwI+nfuUeK6Kb7YXIyG4lN/n2KE9pkc13n 64cxAhUnzRRFBAfTd7c2npUPfQ+TibWwkVTqMb3u1CGb9NoopVS33+0HKS3u1Ta2BL+y WFw3h7Pbps3KNTry8IZ62eJRi6vadnYw2UvfTsubm9hM/nKm2Jv2TGMDO30O8X8HkyfP C1GA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=KuzIzVeJ; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NU0gS30M; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="AoMXh/Vk"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-336e456c403si3789216fac.77.2025.09.22.01.03.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Sep 2025 01:03:26 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=KuzIzVeJ; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NU0gS30M; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="AoMXh/Vk"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gjmNtWBmp8vgeAwXWSAUCPbShN1yzdJVjlF3lDlcNng=; b=KuzIzVeJBV+Ald+UbI7vt/jSg5 BWLKBFLxsiu+oMxO5FSHvsb4WAD8JS5bcCDm29odyIRAmv+LW/QcPaoGUKxsxNbXdiu08OpveYHcn ix8wohzpcmS6hq9SjVKQvFxxTmOd5yLGTn+3H54D7ilP/6tSgbITlIe7BOqOzAh8CHC0=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v0bW5-00039d-Jj; Mon, 22 Sep 2025 08:03:22 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v0bW3-00039N-6b for openvpn-devel@lists.sourceforge.net; Mon, 22 Sep 2025 08:03:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nwbFQReaxr9I1NwtaP8R/hTkzmEU/6r+ziWpegoEuT8=; b=NU0gS30M9xXBynNzVb2/19l+8H 03jP4dr7T8Pj0NxLYQWMZxUQueW+vrAKNFg1kLXGYhCni2pvYg6pNlfWodz0UknybD3Q4HG7/giko whGxB+ilRWPHoWGeaHtr9+NkEGCNLG3aYm+kKZ6taL6op76qlkuQJft6MbzGzkWSUmFU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nwbFQReaxr9I1NwtaP8R/hTkzmEU/6r+ziWpegoEuT8=; b=AoMXh/Vkve8cI07oIFUu92gOLX OCoL1tRmULR9k4Rqod+D29Zz6DY6dVD1Ttzq76zSuD+gJinSHuN8yzXAn2AF07fXfjOHOv0p8e4Ib p/VpVm3I50luwiKbv24BHiLDvZsRbrkIRBBADb6UDZKampjFXSWRzesktD2Rs79aDY1s=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v0bW2-0006SJ-NE for openvpn-devel@lists.sourceforge.net; Mon, 22 Sep 2025 08:03:19 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 58M836iN018497 for ; Mon, 22 Sep 2025 10:03:06 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 58M836Gt018496 for openvpn-devel@lists.sourceforge.net; Mon, 22 Sep 2025 10:03:06 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 22 Sep 2025 10:02:59 +0200 Message-ID: <20250922080305.18477-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Commit 0df0edc49c re-introduced explicit setting of broadcast addresses for Linux IPv4 interfaces. t_net.sh verifies that the built-in netlink code (sitnl) achieves the same result as "equivalent" ipr [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1v0bW2-0006SJ-NE Subject: [Openvpn-devel] [PATCH v1] Fix t_net.sh / networking_testdriver after 'broadcast' change X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1843950473091457567?= X-GMAIL-MSGID: =?utf-8?q?1843950473091457567?= Commit 0df0edc49c re-introduced explicit setting of broadcast addresses for Linux IPv4 interfaces. t_net.sh verifies that the built-in netlink code (sitnl) achieves the same result as "equivalent" iproute2 statements - and we missed adjusting of these iproute2 statements (printed by networking_testdriver). Done. Change-Id: I5fea6ca1ccadb434b5c4f4b49881524a079a9d15 Signed-off-by: Gert Doering Acked-by: Antonio Quartulli Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1203 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1203 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Antonio Quartulli diff --git a/tests/unit_tests/openvpn/test_networking.c b/tests/unit_tests/openvpn/test_networking.c index f2da83e..6a2d09f 100644 --- a/tests/unit_tests/openvpn/test_networking.c +++ b/tests/unit_tests/openvpn/test_networking.c @@ -61,7 +61,7 @@ addr = ntohl(addr); - printf("CMD: ip addr add %s/%d dev %s\n", addr_str, prefixlen, iface); + printf("CMD: ip addr add %s/%d dev %s broadcast +\n", addr_str, prefixlen, iface); return net_addr_v4_add(NULL, iface, &addr, prefixlen); }