From patchwork Tue Sep 23 12:20:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4439 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c08a:b0:72f:f16c:e055 with SMTP id jr10csp820967mab; Tue, 23 Sep 2025 05:20:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVVFsZQa4IBniFj5kQ2bA/FgQpVSAodsqotDLMFWeqLITeAZP4tyAL34LEw+oH15vju+YBxFdBM6rY=@openvpn.net X-Google-Smtp-Source: AGHT+IGbbdUe7aZMuy5W3hYxKiuBOdQwFmIGJ/D8K+/TLV7HMk+udniMGM5vbsZ52KRwFKmL0wq+ X-Received: by 2002:a05:6808:23cb:b0:43a:2e17:3bc2 with SMTP id 5614622812f47-43f2d31563amr1015301b6e.21.1758630020184; Tue, 23 Sep 2025 05:20:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758630020; cv=none; d=google.com; s=arc-20240605; b=Ek+4JS4bGqcvvjXgb1uSyw+rbPye/kqG/FwO3om4Nc27DuY/sDPeXVCrdKv35aJU8s snlyrjCrhXfhFrQHDZUqTnKqN9u52jgi47bWecnGXKSr6TB8V6Asvil+a085kEFiLmzh IAK9hNb15geDyDe9sT7m4fcgk8AUARrrHTm2g/dN7QuiWyDD8cyka360w5WX0FuY82FO 6RXa42OcrPMRM5D1WiwDsbN4yoaHBVmoOTp2yg4Wm6+ckTcPJWc7yU32CGiMHf0SgbgK C2uW3JSXcsshggQfaqF5flhIfdGZQEMTS01KEflneKXghPEjr5ZkNJR5Ao0mr8eRPiWJ ulKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=bF1pu4K7d0lMcz8LvRhUO1qlfm71kQIPK0mp45eiWT0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=hU9eqTrRIhgTYKh/dmN8O05cGejkz5WxyBjDpuptksiUR5YmtP1kOFfsvVOSU1Bmb2 eHmDBvSWdB9a6VkHV0t3LI8IU7WAMLqOrIhZObnCI5Tz+rOul2EBNVIVhMVHHZWsRV93 6wVtqoXkZc+TPpuC7+OxGft0imYviXpOXxiveG++P4FwsY6LfaEyBtu6x42pTQ1ufzCJ NAFKs0NDg24ebGSVJRLJiOohsUecZavB0Lo0gqoTF/+aUQ25CBiJ1mYx7i6FekALXXBi qwXEHfpJxIUKZXUV/PtZZWeCUe2kvl8gYEC0hAmqiiLMzz1M9Z4JkNropnHJEWjoEkxi dy9Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="AGx/EbpF"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=hQJgd3lx; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jU6zNxoq; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-43f26a2f35csi731290b6e.209.2025.09.23.05.20.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Sep 2025 05:20:19 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="AGx/EbpF"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=hQJgd3lx; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jU6zNxoq; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bF1pu4K7d0lMcz8LvRhUO1qlfm71kQIPK0mp45eiWT0=; b=AGx/EbpFGTGcGA0wbuUdLrxMe1 pkjB5EBas5UHY0VCLzpAwhzt7C4ZBO7xbXLqHOVlrTYQjR/apfH2xl9vI0ynexo+MBrArC9i0Zf/2 jBzk26lH1d+e9pjhHzpWIhmkKrFxKan7nlxbwcrPA2uFX/rvOl40UXyTrBcVZGDghKn0=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v120H-0005dd-8Y; Tue, 23 Sep 2025 12:20:17 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v120F-0005dW-83 for openvpn-devel@lists.sourceforge.net; Tue, 23 Sep 2025 12:20:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nvUVeSQqXYSUcCJYn7b18LI0FpTE8Hm8RmkTOHF45BU=; b=hQJgd3lxe4P+4qW7DfZL27TSW0 516hay+VbVmnN4GYc8dzcDuw+Lvv2P44xIuayAFQdl7bZBcdaPTZFzqaauvMvlNtYeCu4Z4Yp4hX/ DGbivHyHgmJYEiIIhRqWS6VNrNDIfM+x6vlbGu7hu/Bv5VrfEPVnjU66z1w7MMwfk2vk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nvUVeSQqXYSUcCJYn7b18LI0FpTE8Hm8RmkTOHF45BU=; b=jU6zNxoqJmWQM3QhrUSYnfM+W5 0UNnDiRvAm6IfeRPZO2TXcNqfIlvTIrIhRKcGUd/f1wnGqbctWvxgW4RW4q61hFz9J+rIZ+V9nEnb iYW6H8RqNfnwGbVTrhxknBw2oSDhRmS63qsIEJcUWF1Zf6RY8op2+XjatTOIVoWsE4bE=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v120E-0001iK-16 for openvpn-devel@lists.sourceforge.net; Tue, 23 Sep 2025 12:20:15 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 58NCK7kR012255 for ; Tue, 23 Sep 2025 14:20:07 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 58NCK7ct012254 for openvpn-devel@lists.sourceforge.net; Tue, 23 Sep 2025 14:20:07 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 23 Sep 2025 14:20:00 +0200 Message-ID: <20250923122006.12212-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld The prepend behavior is surprising. If there is a difference in behavior at least make it easy to understand what happens why. Change-Id: I1ce408d4473874d88a348308503527ef7eb8c1ff Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1v120E-0001iK-16 Subject: [Openvpn-devel] [PATCH v2] configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1844057232101231332?= X-GMAIL-MSGID: =?utf-8?q?1844057232101231332?= From: Frank Lichtenheld The prepend behavior is surprising. If there is a difference in behavior at least make it easy to understand what happens why. Change-Id: I1ce408d4473874d88a348308503527ef7eb8c1ff Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1204 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1204 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/configure.ac b/configure.ac index a5485b0..c2feeea 100644 --- a/configure.ac +++ b/configure.ac @@ -1388,9 +1388,9 @@ # required for gcc, but some compilers such as clang need it. AC_DEFUN([ACL_CHECK_ADD_COMPILE_FLAGS], [ old_cflags="$CFLAGS" - CFLAGS="$1 -Werror $CFLAGS" + CFLAGS="-Werror $CFLAGS $1" AC_MSG_CHECKING([whether the compiler accepts $1]) - AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], [AC_MSG_RESULT([yes])]; CFLAGS="$1 $old_cflags", + AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], [AC_MSG_RESULT([yes])]; CFLAGS="$old_cflags $1", [AC_MSG_RESULT([no]); CFLAGS="$old_cflags"])] )