From patchwork Mon Oct 13 16:23:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4507 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:7d42:b0:72f:f16c:e055 with SMTP id fr2csp2020000mab; Mon, 13 Oct 2025 09:23:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXlSRYPtbrPEMwOHBhME1wcOzVVOu1FxBsyoVnfACfnGYjzeAqtk9V3d/UYllxxLMIVdYYHPB+/9PM=@openvpn.net X-Google-Smtp-Source: AGHT+IE1DItaw8FuI4OqWh+qIUgptI57XxZQFmpNXKyqtRvmbGLJh/O26kuO9MhtTEXcZM4i2mAq X-Received: by 2002:a05:6808:4f22:b0:441:8f74:f0f with SMTP id 5614622812f47-4418f741b7dmr7010994b6e.57.1760372609284; Mon, 13 Oct 2025 09:23:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1760372609; cv=none; d=google.com; s=arc-20240605; b=KH4l6OunVV8Xu8N6jEKyb4OUMN85Xvtwpo7kskuJdvNwDZWifNjRKgGU4Yap/E118O jM+Z+FbcduR6ctKWXUSUtZuZRZoktYv7J74oGao9usz9h++rna2vwhVo/pouGrgtXzxb RZ1lLDNYRWPUDwY41ukaK/HVpl8FQ7xQX+ePgsnglcOu0xdj/FvLG9uAoqRwg5Ho7+xK S0t/dWBrIZktrsOjNV/uI0KoEYlQoXdpOGS2HNNAiBhGiQahMCOjQKG7Wc5avyhnRD78 yGfPUUxnOaBXpjXLCaHUpss9P2L3pGJoyby8wjNNwI3vuIHX1ucN8gMFMy0EUHn47LGr HPDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=vjtsIGOnls94e7jPhJ/KNsU6Ubs1rrv3ZIiLjvlIUdA=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=C5dEdzO1gt21m9OJRimB+AGs4aADqlHEvLbs4Rc/5ZDGRbzzGl+vPj0IjF//4ZoBED La3WuZPDpArOPtPaIxxNaF52xBs5RCLlPEbdwghxJyeWJtRGn6YjeL3QmIOxhgvTR/DJ Nd/jCdvMJUkx+TqJ7+naWLwuRulydAdg2rwmUiuz9+SOVeHRuIwFSp3o/5En7h6eqRlA LWzipRvPQ0e2nayj55ezROy2VJhMqcna+gHv9oppqRraU0uMIJz9waQIgzBLPjbeU+Ce XzwAUeHNa7vfOS7dGTSSi/7vKnyNX9ihDQKIOLGT0EmWOGHFkxArhFFYIRWDS/4FyHwQ VzKg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=VgK1n7bo; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="kJ6EO/fB"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CaPRryVm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-441d1f16729si962754b6e.405.2025.10.13.09.23.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Oct 2025 09:23:29 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=VgK1n7bo; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="kJ6EO/fB"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CaPRryVm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vjtsIGOnls94e7jPhJ/KNsU6Ubs1rrv3ZIiLjvlIUdA=; b=VgK1n7bo95nkbK51g3ikPyhHAr yT6670jeNj9j3C4+28pMqNqDHn4lfo3zlbNSQb3CTqRvZuEsdn4PyDMR+Jbh+C+aa4ZRncVM/G+uy dVTMawlaIt0gctJ/hUK5vCMBt5Bc/RKLl4JKfcySgses+7auaA4aELSiZN6ykn+oaVlk=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v8LKY-0005PQ-Ke; Mon, 13 Oct 2025 16:23:27 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v8LKX-0005PD-KE for openvpn-devel@lists.sourceforge.net; Mon, 13 Oct 2025 16:23:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4UKep2QG/9+a4QqeXnBaiKFeQkfSG+YgGBP23YmxyNE=; b=kJ6EO/fBRmxTnbA1vluvbUSmAm F9cMFDMsFMvMufThMcc/Ana95An/Ybu45FH+UPkHoekucGNJBnYtu5mzvRQTsqS7RUFtoVNUOAhmj OZibjURVJL6niUa45wpo+q207Nflf+VEp61MznRmkaiJ0mnUHLD+nQJASnhpHZ108Jlw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4UKep2QG/9+a4QqeXnBaiKFeQkfSG+YgGBP23YmxyNE=; b=CaPRryVmUKsEz8MqBK5YkkUi38 lkfGuwFCFeXbR5ID5loQ9bVj5lPA/2gb7x7kKWi5JZegXf376uT2XY/4mekkb7iPTW/fZvO9C8H8P Wliadi7bLi6bcu7kk8tWnymGFiMQG/YOPdj6ZmysxEErS0ZyNk4tlHoiCFlAIU4yYAGc=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v8LKX-0000vM-Kg for openvpn-devel@lists.sourceforge.net; Mon, 13 Oct 2025 16:23:26 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 59DGNEEB002290 for ; Mon, 13 Oct 2025 18:23:14 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 59DGNEr1002289 for openvpn-devel@lists.sourceforge.net; Mon, 13 Oct 2025 18:23:14 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 13 Oct 2025 18:23:08 +0200 Message-ID: <20251013162313.2276-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Return value of random() is safe to cast. Change-Id: I5e6cb3a287a2e8e1584036307b4c21bb68050c6a Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1v8LKX-0000vM-Kg Subject: [Openvpn-devel] [PATCH v1] schedule: Fix conversion warning X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1845884469387556011?= X-GMAIL-MSGID: =?utf-8?q?1845884469387556011?= From: Frank Lichtenheld Return value of random() is safe to cast. Change-Id: I5e6cb3a287a2e8e1584036307b4c21bb68050c6a Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1270 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1270 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/schedule.c b/src/openvpn/schedule.c index 1389889..bf6693f 100644 --- a/src/openvpn/schedule.c +++ b/src/openvpn/schedule.c @@ -65,25 +65,16 @@ } #endif -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif - static inline void schedule_set_pri(struct schedule_entry *e) { - e->pri = random(); + e->pri = (unsigned int)random(); if (e->pri < 1) { e->pri = 1; } } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - /* This is the master key comparison routine. A key is * simply a struct timeval containing the absolute time for * an event. The unique treap priority (pri) is used to ensure