From patchwork Mon Oct 27 21:27:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4529 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:2995:b0:72f:f16c:e055 with SMTP id f21csp1665745max; Mon, 27 Oct 2025 14:28:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUX0OibP4sAVvGvwKTbvXRITih87f/2aD7ou2XY9PxMvUojEB2xXyVWizCATGa6wK5F5CYj9LJQ5N4=@openvpn.net X-Google-Smtp-Source: AGHT+IH8rf7k031gMMwk05ve8r0q9zHE8IrzpfKdvX+bvIuX0cBT5YVU6Zxp5mbC0Qj/SRIGscXH X-Received: by 2002:a05:6e02:3304:b0:42d:8acf:a6e2 with SMTP id e9e14a558f8ab-4320f836705mr22654345ab.15.1761600487910; Mon, 27 Oct 2025 14:28:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1761600487; cv=none; d=google.com; s=arc-20240605; b=LVgBuoXjfEahcEjwSYaJ+saTP1yQzMtL5/3XJc/wYlFrAYazrlSbTYFpOE6n1Cpwni C0s5vxoMkJiH79kLv7zh0mk5BZxnQbrGDkfncwDuXGqihG9kqeLJbvO6gs5kYGobjL8t gA4qssX9swgZz005+qX4SXI03KxA68mNC0BHNN5kW3W2nsxY8HIreO3C9ICsBXqnfFpD alssqtWp8OTohynK2RHXlsilxwOtQ9REuWAbpABz5UiRV1+dZjkbqXehxcks+d+azHr1 N2zN4cMKzN5a+1KkaQ6zpdvfgk/Gs1kqNJ/G46fH6uW5t2hdU2I7LMKBgrIKYMFwIu2T ucew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=OBImy36b/Yt+g1WoLG6Irxlth4PgPPoFpFrlh3JzJYg=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Y8UmaK/N38RZESUaPbjrYS7XRSC1exCxsZfz4Q8gdwyQ5Rz8ZVGdrqE8btJiFiEHxz ahm/v53Ki9ho7mfzSHAyk/9AYw1dC9sITeo11NfQdZ4ZOZAl6pwc4Fczxenz1rx4ezxt agpDvxHaaUjQoXUf1tGPjovPIWXLiuZEOlRp877a3Bn+NW9kN0hK49C2OtfCWskYZRS+ FNqjDYr3C0w33EFUS8B9ZNc1fdj/a6iqjE+QqtHBorIaRxRFE5X9kXeqyiMb90d27hRT OWIifpmHUZQVuvmrEqRHzoi2QY+Eccac9XrEvytaqkIPBQOIqZn2c5SlAJL92s252CDK NqIQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=V+vUBxCS; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Ar+mVNfc; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=S7636uaP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e9e14a558f8ab-431f7e4d24dsi62987865ab.153.2025.10.27.14.28.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Oct 2025 14:28:07 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=V+vUBxCS; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Ar+mVNfc; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=S7636uaP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OBImy36b/Yt+g1WoLG6Irxlth4PgPPoFpFrlh3JzJYg=; b=V+vUBxCSyznwhyT3qxHHDMYKDN 2rNTkgkT7kgQo4qnFry8w+H/maK/H0i5V1xrCfhRpnCiM8E43oCbYQkWE035lgUAnGigipLSVmLCU dhvoLQkvXSAP0wBGyEbpkAKQPEEVa5HH59iX9pnoXi2zUCLB4YYaX286Soiozkrw4qDo=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vDUl1-0002tN-OI; Mon, 27 Oct 2025 21:28:03 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vDUl0-0002tF-28 for openvpn-devel@lists.sourceforge.net; Mon, 27 Oct 2025 21:28:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WE+xHM5nVP+er/lTmnR6VDqnfGYk5lEQbiLSDEd6XBA=; b=Ar+mVNfcllDNR3IDSLOs42JXAl eM5ruQyklnKKGtFT5QbhhIbovm/+If+6zbetlqj7XqgJQQx184+txNONYAQMpuWVV/Quta+4vwwPm kRhesIaPizHIi2fAThjFjUEw39Ofxnuy8tFGwrEbbhKfEtm46BCAgMT4uG6iwhp24jwo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WE+xHM5nVP+er/lTmnR6VDqnfGYk5lEQbiLSDEd6XBA=; b=S7636uaPjiQhL8LMWA9r1x23aE W6GHaISYBCZstqS+FrdMX36/0c7SPMvDlKvAmRUkptxRpU8PGf3JFFshtIXQNl+gP05GtYGYMjBhn IBVMdJwgXfBap9KO22L1NrDzF8EHGtQ/3EBZNQrhZkPmjM9jpkd+Iz/QzDEzzdQX9NrU=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vDUky-0005hS-Ve for openvpn-devel@lists.sourceforge.net; Mon, 27 Oct 2025 21:28:01 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 59RLRmlD004176 for ; Mon, 27 Oct 2025 22:27:48 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 59RLRmZV004175 for openvpn-devel@lists.sourceforge.net; Mon, 27 Oct 2025 22:27:48 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 27 Oct 2025 22:27:41 +0100 Message-ID: <20251027212747.4161-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Found by ZeroPath Change-Id: I85320b8f1cfc02dfd561916e5637d9481edac59e Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vDUky-0005hS-Ve Subject: [Openvpn-devel] [PATCH v1] pkcs11_management_id_get: Free certificate object after use X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1847171992743897943?= X-GMAIL-MSGID: =?utf-8?q?1847171992743897943?= From: Selva Nair Found by ZeroPath Change-Id: I85320b8f1cfc02dfd561916e5637d9481edac59e Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1317 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1317 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c index ce64135..9afb181 100644 --- a/src/openvpn/pkcs11.c +++ b/src/openvpn/pkcs11.c @@ -436,9 +436,6 @@ { pkcs11h_certificate_id_list_t id_list = NULL; pkcs11h_certificate_id_list_t entry = NULL; -#if 0 /* certificate_id seems to be unused -- JY */ - pkcs11h_certificate_id_t certificate_id = NULL; -#endif pkcs11h_certificate_t certificate = NULL; CK_RV rv = CKR_OK; unsigned char *certificate_blob = NULL; @@ -548,6 +545,9 @@ pkcs11h_certificate_freeCertificateIdList(id_list); id_list = NULL; + pkcs11h_certificate_freeCertificate(certificate); + certificate = NULL; + free(internal_id); internal_id = NULL;