From patchwork Tue Oct 28 20:32:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4540 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:2995:b0:72f:f16c:e055 with SMTP id f21csp2306340max; Tue, 28 Oct 2025 13:32:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWtQ4auMZvoZApyRBsmWf9f0UXCIJw2AJoFoH107qKAu945LkUQjOQboID/15mTA6qggAIysKeyRQ4=@openvpn.net X-Google-Smtp-Source: AGHT+IHHFEpr0g6o9y02XvblO5iW/2tkqWrfGBAz9ctlZT/Sb3KVtXcfxdB5oHYSKI/KVtqUrHYh X-Received: by 2002:a05:6e02:184f:b0:42d:8c07:70d2 with SMTP id e9e14a558f8ab-432f8fad60dmr8607275ab.11.1761683558504; Tue, 28 Oct 2025 13:32:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1761683558; cv=none; d=google.com; s=arc-20240605; b=INjpTirPfc804ZbUGbosy9q8c7t2p1f8QmXx3/S5rvky0xeqFDctG0NLua/MuV171z Q3sCaGFMrg0nSbwJTdkZ8nN3SAf4JLt4SOHMvaQIHCjTyKhClrZ0pQ5DzPsGxgBh812G zBx+CjqcAjqZsxveNqw2Ruj0CoCyitZSYoFDnWT17HJ1QJRPmJ/dffLKz+kqAuLDX/w7 NjTI6WECHZtDpl0UEwG5GRCO4KXrL1N6xQqGVgipZu+kBd7ZmJaN/KH8Fz2hJ7vJ6bXp SpnNpviLXH0To7sJjlYTNP291+JdP6/IDU5E4gHXfMq1dQZ3RAImntH0TW3lybCv34nY Zb8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=4Uauo72XG7q8w3pqVCs6PsBUXZ3AbcVkxHupS06Ihl8=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=NHfvB5BnZYpAaUP6HaN5sI5gOj79CQzu2iK1W+rn6WeasNqxkc6vWr7RftJYhhI617 1g9LX9bsvfxaUFWc5eNs3G2RdvLKJIYUG7AlMJdvHUH1dVgr/GVrNhG5EP85QelciiJV bfspGC7lVpKa8hvVxk9RPb+5jExSMgUv8V9Q4EyjXjydJNyqDNmyysKUX9MhmR83iMlU YT5mOZwYL6+Y+lo4wqNZsuyoH8PleyJXf9Ot2UX0rF1M2hcsun3ZLbjronAIYvxLr9By TPC8Kd7/UbM5ToC50a0Sf6Zs6tMmkSvRE54HCcb1kdfIkvSPiOgVezDvxN7zyBGs690m UDNg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=LYcOKeO5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Jrx6AxzG; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=DrNqQqYo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e9e14a558f8ab-431f7d976b6si90024155ab.6.2025.10.28.13.32.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Oct 2025 13:32:38 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=LYcOKeO5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Jrx6AxzG; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=DrNqQqYo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Uauo72XG7q8w3pqVCs6PsBUXZ3AbcVkxHupS06Ihl8=; b=LYcOKeO5QI2ilZwVv5oeyIXfGh qe2FHsMFQKPO4BxKwPtIXQ/R7J0VDT/dDBoXs7ZkBmRy88abU9+4FjIP+whDk/OYzjO+9AxDVZfXq ENPOzQnhQ6DUEw28sqc6OBmS0wxfaU4G2hn/32N96Ch4wGBBoYnLInRq0ksZyf6GPxKE=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vDqMr-00068P-Po; Tue, 28 Oct 2025 20:32:34 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vDqMp-000686-SU for openvpn-devel@lists.sourceforge.net; Tue, 28 Oct 2025 20:32:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iu5A3nYVTeRSugIsfzvAN1bG1Tp3CHU0v6K8eo8b0gc=; b=Jrx6AxzGVs/9pHdjP1Y+L7EAHJ wqDru2z7t4vLi27pxTFMpN51x6WWLUJ0JU9IKs++OGrrWV2xiB7Ey13uuU0avEObXdqGQYMVWTjBO G35QtmHyRX1Z6Op1a+C0tUFRONfi2N1VtThsYM3dhlZAYZ0oDgGPu55p/mLtOfsUmoKM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iu5A3nYVTeRSugIsfzvAN1bG1Tp3CHU0v6K8eo8b0gc=; b=DrNqQqYoL7KYCGbbetzaoL/q1l KvKGpGRiaST0Zx/C3JcCmSGKDQRj07o84m92P+E4M1BoJTH9V/uv9xnEGVay16QCrwcugCXQx9w+s gO4J3GBXNPK4gaCzm8PtDRUcbau4yCbvFEk2vR8V7Z966T96bsDOrCDRcLeKZgTEtKrE=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vDqMp-00063E-Fk for openvpn-devel@lists.sourceforge.net; Tue, 28 Oct 2025 20:32:32 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 59SKWJ7s011770 for ; Tue, 28 Oct 2025 21:32:19 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 59SKWJEd011769 for openvpn-devel@lists.sourceforge.net; Tue, 28 Oct 2025 21:32:19 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 28 Oct 2025 21:32:10 +0100 Message-ID: <20251028203219.11737-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: this seems to be a leftover of the time when we had conditional compilation for "--disable-server" or thus. Commit d6a0cf599 removed PUSH_DEFINED() nearby but overlooked this one. Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vDqMp-00063E-Fk Subject: [Openvpn-devel] [PATCH v1] remove redundant PULL_DEFINED() macro definition X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1847259099114600039?= X-GMAIL-MSGID: =?utf-8?q?1847259099114600039?= this seems to be a leftover of the time when we had conditional compilation for "--disable-server" or thus. Commit d6a0cf599 removed PUSH_DEFINED() nearby but overlooked this one. Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/options.h b/src/openvpn/options.h index 24253af..125e524 100644 --- a/src/openvpn/options.h +++ b/src/openvpn/options.h @@ -769,10 +769,6 @@ #define PULL_DEFINED(opt) ((opt)->pull) -#ifndef PULL_DEFINED -#define PULL_DEFINED(opt) (false) -#endif - #ifdef _WIN32 #define ROUTE_OPTION_FLAGS(o) ((o)->route_method & ROUTE_METHOD_MASK) #else