From patchwork Thu Oct 30 14:51:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4544 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:2f13:b0:72f:f16c:e055 with SMTP id sa19csp971405mab; Thu, 30 Oct 2025 07:51:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUggrKk5EU67rBlh0D0Btm6lZ/fxn0qldzVlr9nibc+lBrJXUoj2kaE1lx9YE1MyADwKAZ1NsipzBY=@openvpn.net X-Google-Smtp-Source: AGHT+IFjBCZ8Y0hv6VUJiRF9hnOz9/ltKtc/YdZ/2NQIGPEViKMWF2Ru1Rvf50de1338GRaQhksF X-Received: by 2002:a05:6e02:194b:b0:430:ae1a:3375 with SMTP id e9e14a558f8ab-4330154fb83mr45667985ab.26.1761835907145; Thu, 30 Oct 2025 07:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1761835907; cv=none; d=google.com; s=arc-20240605; b=GavdZTzgPfj0QbVJp2tFZThU20fSU0xe9B26yuRGI5Rt04zx9pzTIstYHS+TcoIG7y evCEuzPV/sfk/pJbv3s9NJu6F3UZ0CAqMoVrRyiR7LUG7ZP8zrIUyPIop+tFnnPhCTis 756aVYIkf64jgSfZi6+ODZLL/9btzfHl9pJWV1qceMpak51kDcTijb2bdDe3igpRYIvN cBjwpDHBRW+VgLYTYlfp2GK/yJs5R+iYZ0I/46aXTSwTfg7tdtUzTI8DESct2HV6Ara0 ziPKdnCFPAa5hwKjn1rPzxaI3IfJwUgz2m/PtvdX+y8YqbuZNsmY8mV0d3FcovwePxoA 3fUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=Bh5fpuX20JbObvvk1gcWPvyW9FHvjHflWiHOxBVFjKE=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=dWTBtG9kwrSzmcL5ECjbOLWoTSMUnwlRZyi16c42uy7Tybuuo+MP2bN1ArJnbppLij EkPRu/m01CcrkGufrszwTO4XqiLM6RWHUf9G2+HVquk5Zhkb0gfNv6TvsdEYIQZvyp7s +plrZKadeBSP0nqjb6R0uZWxAEaJ2DyCWbejI77wli/XUAurYV/rybJgmEf6vQYAsql/ IH5QKs0n9PGDfxJJ9eMF72TGJ8NyUthKWSspdoiQVYMOcvKsmzoAXjPgK0cB8Zcc+Aka XIM0zL9SuJXSXopi6p0gY17ql4ncdFLTgs4lrDheaJ/OxIwYnDsH1y8jlLVBJpTQRcIC fD6Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Klyy+Pyz; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=a4IpqZ8W; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gUf54QfH; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 8926c6da1cb9f-5aec8dd5825si15492455173.240.2025.10.30.07.51.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Oct 2025 07:51:46 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Klyy+Pyz; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=a4IpqZ8W; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gUf54QfH; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bh5fpuX20JbObvvk1gcWPvyW9FHvjHflWiHOxBVFjKE=; b=Klyy+Pyzwq0tp8g8k89CEXwju1 BiceYIisg/AmLuCrwKh5yeVCcB8zsLYnUElgiueQS0NWMjLwyHw/lKAoXjpG8bXvA6vTP0x5HWrei WwsKy18bKEkmqPhigEAru5dPWH9pSXUcMy8aYYY7ig2P0osMCRl+3SZqyle1D6ZBKGjw=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vEU05-0004cF-27; Thu, 30 Oct 2025 14:51:41 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vEU02-0004c0-Ea for openvpn-devel@lists.sourceforge.net; Thu, 30 Oct 2025 14:51:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dOhMYgMjUg3x0ojbXBbveV16ZkOVFF6oknkgjI/jB5o=; b=a4IpqZ8WymxEQeVoHr/T6WPT/Z ZnL83E2DdfaMzEgwPFQhdAZ1pCe5q/nt7D6w0eKu/qgBF1x0ckIrCsim87jwVlUTW7hHvWaDXqlVA vYUqK6xymXemKQrlItHVGmV0utRo4iweaS7PfHBjGFsYed6bHfOKIsAlG5HFgEXE8xBg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dOhMYgMjUg3x0ojbXBbveV16ZkOVFF6oknkgjI/jB5o=; b=gUf54QfH6WhFUCmJdS6Ckti8zo E1I8grpaKpfwpWbP7oH4buwx4O4xYzYaPuW/oo3jcEYS7wcH/F3NfqhLiTVTxhpiO2XZ0xEabuYNd m6/5qKR8WVJPKTPx8l70d8rZICqQUceOjGKLOWRgqeltHDHD5ZrquWw+v94aY8sX962Q=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vEU01-00042T-HB for openvpn-devel@lists.sourceforge.net; Thu, 30 Oct 2025 14:51:39 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 59UEpPTO002621 for ; Thu, 30 Oct 2025 15:51:25 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 59UEpPxo002620 for openvpn-devel@lists.sourceforge.net; Thu, 30 Oct 2025 15:51:25 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 30 Oct 2025 15:51:19 +0100 Message-ID: <20251030145124.2607-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld These were implictly fixed by the fixes to the hash API in commit a69aac41c4b2ccff1084736c158d7cf8474be533. ("list: Make types of hash elements consistent") Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vEU01-00042T-HB Subject: [Openvpn-devel] [PATCH v2] mudp/mtcp: Remove -Wconversion pragmas X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1847418848294474895?= X-GMAIL-MSGID: =?utf-8?q?1847418848294474895?= From: Frank Lichtenheld These were implictly fixed by the fixes to the hash API in commit a69aac41c4b2ccff1084736c158d7cf8474be533. ("list: Make types of hash elements consistent") Change-Id: Iacec5920cdc3e16aaf777f843ef1f4a00a6a9043 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1324 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1324 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index 83edec6..81310a2 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -45,11 +45,6 @@ unsigned int sock; }; -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif - struct multi_instance * multi_create_instance_tcp(struct multi_context *m, struct link_socket *sock) { @@ -125,10 +120,6 @@ return true; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - void multi_tcp_instance_specific_free(struct multi_instance *mi) { diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c index a373a6a..31134be 100644 --- a/src/openvpn/mudp.c +++ b/src/openvpn/mudp.c @@ -180,11 +180,6 @@ return false; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif - /* * Get a client instance based on real address. If * the instance doesn't exist, create it while @@ -315,10 +310,6 @@ return mi; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - /* * Send a packet to UDP socket. */