From patchwork Fri Oct 31 09:23:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4556 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:2f13:b0:72f:f16c:e055 with SMTP id sa19csp1472328mab; Fri, 31 Oct 2025 02:24:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUI49urkMOkcYg8gqtCvD6u1UpvUHV1NygSJopTZP4PF+jlL2jTpmXu1jCGgcB635Zs9vjsbQFV7CM=@openvpn.net X-Google-Smtp-Source: AGHT+IFHvtzT70DYKf6JOEtib1SdY2zwvzn0Rjnr7utZEdjWGYumx44Sjdg628xEZxV7mOZZ3JeU X-Received: by 2002:a05:6808:6a94:b0:43f:66cd:61d with SMTP id 5614622812f47-44f95e363admr1035322b6e.3.1761902686628; Fri, 31 Oct 2025 02:24:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1761902686; cv=none; d=google.com; s=arc-20240605; b=CHwg2LXd+nDs8ZdaVbdSKOlfoeoYcgT5ZdCjyR5krRhbiYk9AHMzBIGvBUwlqILOrD b+vNF/482HBnutFU3K4ip9tetPA0kcNMcBsX/AMOyjVfXZ4V1lGkFnOVxzEPcYDd2hln kfUNZT7p3SIg7pkDPAsqfa4Z7FKafycffofyIYNNkIYVHvWEXeFTa3qpb19x7waXGIPf WSEF5sCcJaxgc4qIU6RmxIoeeZHtFBIE4B9jShZDYhZKWVxb1y8pMl/KXVbeGlpU/QOw +3wQB3AwKFtFpXd8UxZF9J2wHO9FveEU0OK23cG7GxEMAXB5COCgaJkx19IfKoCMraCJ 8v2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=Vbt8fI1K6lVPPnbcvPg/m2uxBQnwwDhjjPZCV9Kmdok=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=EuOp3M2v48TRvP6Fh3yS1DKmsFZdVQ9ccR86/jhiQ0M/iZkv50tiV53Hz3Z8WChdGr SA84t1OefQN1w50Wy1MyUuacPiGEOhco5H7KO41T/bmw2FGx4qf/ZT7LSlc94ZGweRAQ F9jjYp/ddIZHqqplNOS70puf8VljPX2zhHGI0hb7mVwNRfCJkY12BYm9j3g8hg5GUiQM CRCqKdWcqzwevGT/eqiCrqd/c+xQFqg8DGzcEkbdXdXa+CCu+wQ4EKGGsfeQ5qkbP+d2 VXSqcsRBEGTNfK8d6xGk0jXSiiYZDubpZOgctPk6bLkGKKBIO378femiCYHQr19HW0xD fCjg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Kvu55QRl; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Sm1S1bB3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=UcpVH9FZ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7c699c0109asi338568a34.128.2025.10.31.02.24.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Oct 2025 02:24:46 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Kvu55QRl; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Sm1S1bB3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=UcpVH9FZ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vbt8fI1K6lVPPnbcvPg/m2uxBQnwwDhjjPZCV9Kmdok=; b=Kvu55QRlsDDRarMzywTZUAo47y SXk3lo/sITkHy4wwtOMmb6B79IAIctux45gWeT7JWbSFvrTczgseGoVgGNuoeFXzUa/86F+bX4QsN O6yC5lAx3Ywa1myOG4Fr7lD8zk6194fHVljSvMPWdU6LQLYE4qK25zr8oxcLGXgPwrd0=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vElNE-0002UN-7D; Fri, 31 Oct 2025 09:24:44 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vElND-0002UF-4x for openvpn-devel@lists.sourceforge.net; Fri, 31 Oct 2025 09:24:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=O9B56YolTsF3qRymb/VmmdsjMzEHFHoY0xB3uzuHPbw=; b=Sm1S1bB3wN6gKI0Ul7nT+jktGC h61KqKDHDXCcl2qKeozHqYYrZDrRvLURxCGt53q6kfRuNkK/cQhQiZ0CKOODjHg1ynokfNu7c0PB+ q5N2bZFB8oj0cQdC0m/RU2K2or/JZ1sK+g9kBdKvVmME81IcHz9gEbFr5pPDpaCzkZ9A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=O9B56YolTsF3qRymb/VmmdsjMzEHFHoY0xB3uzuHPbw=; b=UcpVH9FZF3sPjzouhFrgZWQKQz 9jJZnFjvdFlokPZXa/EhEQ2qpSZdy1/dlc+0YDlR+DVYRx3LH4rRr3oAUYsEvvHv6WDMQ31hgSZJD WSKyVBdvQiVkwD8ZPttkIAlM6GpejoLycjWHf1KEAKZmRo7F9MRvO5QiAvlexnMzAzeo=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vElNB-0006Vq-Nr for openvpn-devel@lists.sourceforge.net; Fri, 31 Oct 2025 09:24:42 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 59V9OTcE019892 for ; Fri, 31 Oct 2025 10:24:29 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 59V9OTM5019891 for openvpn-devel@lists.sourceforge.net; Fri, 31 Oct 2025 10:24:29 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 31 Oct 2025 10:23:52 +0100 Message-ID: <20251031092427.19824-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair This was missed in commit 05a8ba8 Note: the check for PATHCCH_ENSURE_TRAILING_SLASH in configure.ac may be omitted if we build only using latest mingw32-w64 toolchain. Ubuntu 24.04 is not new enough. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vElNB-0006Vq-Nr Subject: [Openvpn-devel] [PATCH v1] Add -lpathcch for mingw32 builds using autotools X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1847488871285250960?= X-GMAIL-MSGID: =?utf-8?q?1847488871285250960?= From: Selva Nair This was missed in commit 05a8ba8 Note: the check for PATHCCH_ENSURE_TRAILING_SLASH in configure.ac may be omitted if we build only using latest mingw32-w64 toolchain. Ubuntu 24.04 is not new enough. Github: closes OpenVPN/openvpn#885 Change-Id: Ifea896e722635a471cc01f930bc1e5d0f2c165be Signed-off-by: Selva Nair Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1334 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1334 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/configure.ac b/configure.ac index 8f3c01d..3117e13 100644 --- a/configure.ac +++ b/configure.ac @@ -1383,6 +1383,17 @@ fi fi +if test "${WIN32}" == "yes"; then + AC_CHECK_DECLS( + [PATHCCH_ENSURE_TRAILING_SLASH], + [AC_DEFINE([HAVE_PATHCCH_ENSURE_TRAILING_SLASH], [1], [PATHCCH_ENSURE_TRAILING_SLASH is defined])], + , + [[ + #include + ]] + ) +fi + # When testing a compiler option, we add -Werror to force # an error when the option is unsupported. This is not # required for gcc, but some compilers such as clang need it. diff --git a/src/openvpnserv/Makefile.am b/src/openvpnserv/Makefile.am index a27fbbf..f45d770 100644 --- a/src/openvpnserv/Makefile.am +++ b/src/openvpnserv/Makefile.am @@ -27,7 +27,7 @@ -D_WIN32_WINNT=_WIN32_WINNT_VISTA openvpnserv_LDADD = \ -ladvapi32 -luserenv -liphlpapi -lfwpuclnt -lrpcrt4 \ - -lshlwapi -lnetapi32 -lws2_32 -lntdll -lole32 + -lshlwapi -lnetapi32 -lws2_32 -lntdll -lole32 -lpathcch noinst_DATA = \ MSG00409.bin eventmsg.h eventmsg.rc openvpnservmsg.dll BUILT_SOURCES = \