From patchwork Mon Nov 3 21:25:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4563 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:a40d:b0:72f:f16c:e055 with SMTP id vo13csp1692623mab; Mon, 3 Nov 2025 13:25:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUB+xhN9p1aPjTZXyw5xKYJIAwTPx2f3hA7Bv6T8E1rWiIm63VB3HqhqB0SRKgrOSFv1ELfVjU+YyU=@openvpn.net X-Google-Smtp-Source: AGHT+IGfNzI4VkOnLPsYPyrFKPsGEDpdCWRB0iT3wJeiYVUQcGeIzF3cOFW+VD3gyV1kl6FdmyTJ X-Received: by 2002:a05:6e02:3499:b0:433:2bf6:2c85 with SMTP id e9e14a558f8ab-4332bf62e3emr82376085ab.10.1762205144100; Mon, 03 Nov 2025 13:25:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762205144; cv=none; d=google.com; s=arc-20240605; b=jQEcnTtXQQ3JKMF5dyAgQ3SneDQ4SAz3+0uemDnLnQnn2f32Vhk4TwOdCLqjpMaIG5 cOfGwgQ0mhCNChTEMhHgsas+LG1f6EhKGb9nKP6IYDa3lrghVnrGtzQf1rPhXrOQcJMh hBlxa8KNPMrlZhe7xwPhOjfNFRG5sypTRlDDLJeN4Ea/a/TUbLxGK1zoZOhWkhhZAIbe o8c6T/Ev+191L+DP88Bt+S68J++W6fTW5LYi71nUdpTgPGiDiXEQ2bj0JttWJrxXy1Gu 5WvkLh/drkW9gGd3WhnZuSnTIDj+cLhEE7ByBjzG4vZQmmEwDwsSqqbxpSb5UELHa0Xh ca1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=YKXKrL7AjFihz+GzzUxBEs5yNKOZ58jhrZ8QOIvv7zg=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=RPQbYs07h84eB1RGUEsy3dgshj6SMzdyVeGA6+9TLmF59M03K1vE1k2Lyj9dCrlQk8 CwYW8TsNflPYM+tElmoTCVeTZewlVuMcq1SuK5ln+XJHXkEnILz88QyNx9ptgEGC37yY /6QuYShHSo8EurLh1IYzEf9W4tClPEi/GFBRk2gFDu/nUmR+9DUnhNDsEURCrxSi0XAl pvHOpQeznMhQ9Hk+pK+XdZY/AuDWjCzOGquOw/cLt6xD79ZebCDg3SjRg9qBUNxXK9Jk J6lGd2RtouMOWH1QQG9ShNpMWiLMGCBk+emZmcURzCIYVzqZyPg9btGwmq7/S9fj/Poj mhtA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=RqTD8+fO; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LojBtcy9; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kgGFxuER; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ca18e2360f4ac-9483440ac93si602930139f.116.2025.11.03.13.25.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Nov 2025 13:25:43 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=RqTD8+fO; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LojBtcy9; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kgGFxuER; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YKXKrL7AjFihz+GzzUxBEs5yNKOZ58jhrZ8QOIvv7zg=; b=RqTD8+fOUdB9YOf1U+jfk7h+vS vHC954z4xM7p3+mXAC0LpqYGAqN6z/OkoY6Sd/5MkiemyIdPf04x9mWryoxpq11+UNrpshMU/Tqm9 upjC6UCwd+hazODGr8G4T9GBnGNVcaCULGclVB0yjjWCNLxkoK/+Sc+YEayCR1O2QZoc=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vG23X-0006iX-0v; Mon, 03 Nov 2025 21:25:39 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vG23U-0006iN-Ii for openvpn-devel@lists.sourceforge.net; Mon, 03 Nov 2025 21:25:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+qB4nvm763XqqEo2/zLvMz7eqUQVF8woltblbISnlGM=; b=LojBtcy967wSgQDFJkREO+C24H PZdOhP0lLAN9lHghuu10bzExs3Mk8yr+kppVAWshihcAqMb6Maa+K+pruZHP+iNqdyYNyeAWfsGI3 oWHR8fUJ+tYu276cy6ypdWElRzTf00H8FXv4C4tgsWHqH7d8+HTRZtqaCuBt4YkAokQU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+qB4nvm763XqqEo2/zLvMz7eqUQVF8woltblbISnlGM=; b=kgGFxuERZmr2GwfMHgBry71BKQ d75o2Uk9967/+vOSIDwA1LFymji7y1CesmWS2Sw1zRgsGlSYmt6FYkGBuMjS341AWJsPk06mh01am P4K1yhOCuatfIPvgJ1Hsq6SX4elBotYqrMx26Lz/JsoMvEzpvJwi7ZwToXWeXV35xuuM=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vG23T-0000fM-FM for openvpn-devel@lists.sourceforge.net; Mon, 03 Nov 2025 21:25:36 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5A3LPNJY031425 for ; Mon, 3 Nov 2025 22:25:23 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5A3LPNgH031424 for openvpn-devel@lists.sourceforge.net; Mon, 3 Nov 2025 22:25:23 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 3 Nov 2025 22:25:17 +0100 Message-ID: <20251103212523.31409-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Reported by: Change-Id: Iafac2b8f319457de8e36b427f26ebc27c040c6f7 Signed-off-by: Selva Nair Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/13 [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vG23T-0000fM-FM Subject: [Openvpn-devel] [PATCH v2] Use correct undo_list when clearing DNS addresses X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1847806021572619840?= X-GMAIL-MSGID: =?utf-8?q?1847806021572619840?= From: Selva Nair Reported by: Change-Id: Iafac2b8f319457de8e36b427f26ebc27c040c6f7 Signed-off-by: Selva Nair Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1344 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1344 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Lev Stipakov diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 58f1e02..0712986 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -1797,7 +1797,7 @@ HandleDNSConfigMessage(const dns_cfg_message_t *msg, undo_lists_t *lists) { DWORD err = 0; - undo_type_t undo_type = (msg->family == AF_INET6) ? undo_dns4 : undo_dns6; + undo_type_t undo_type = (msg->family == AF_INET6) ? undo_dns6 : undo_dns4; int addr_len = msg->addr_len; /* sanity check */