From patchwork Tue Nov 4 08:55:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4566 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9ac3:b0:72f:f16c:e055 with SMTP id m3csp225859maw; Tue, 4 Nov 2025 00:56:14 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWDhQA1fegf+9q1NWRHQwvQeUlMc3k5gb9dXfQNtbUH1B/eRDhcu6csIJ+XEn/uh1IUTZu5Bh7pnDI=@openvpn.net X-Google-Smtp-Source: AGHT+IGIpcwGlY82CZW848rjND01CtWBe5lUFY1HTFeS57pN2KimI+GRLT7VO04rbbLS/pnj3Jti X-Received: by 2002:a05:6830:2783:b0:7c6:8bfe:f5e with SMTP id 46e09a7af769-7c69681ecacmr7392760a34.32.1762246574075; Tue, 04 Nov 2025 00:56:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762246574; cv=none; d=google.com; s=arc-20240605; b=gOk7BsKChA0i64drBISkLyKBNyIzzqtlJICU8eE1Gt5lKDwU1YWm6CKIzuk5TQyqcg e2zH3fBDY52cXLLTmtsT5/KuZ2rwqQa1I+t7V5j/1QkrkdnMEfXDG1cxL9+gYuebBQkp gWKpFNSdjKTt6zG5ULjcgA5JLPLf4JOtTOWPpNsyihc97yqCHZEQTtLMkT249LbiTaah tg+1GURes/Kop/Y2MAAaAPuqTwYwD/3Y0qL1LP4Cetx5Ntp0LOlX1GHCn5mUUCOzvB6q WfZkp+mdzcg9p4wadfVbrI4ktSi5fHprWbJQ9QtsnwJpuS6BUsH/slO29QUdef2Lb2G3 XiDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=7PR+OaWGTws8MKz7Sx80YDo9ZTlfRrydO45xnOBXRGc=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=OInUzxZlo+OjkyBASVlh5rAoD/BKHpiufneZX1ansKWfz+qrfeiQuJVBg4RTcX+enM UnG75S30RMIuXGESFheXqRid8zDIuXr9s5oxH6I3BQDyLu1x7eGqwe/DKJw2brNOXi63 Y/dQ2WzDhB1h2fvbGT3CzZaLMI6MKvGzrJsUzmFEL/9hbQm1cHPtY1hcnrD8D38YW56r Abb/uK+5IRxEm6RHMnBp1WcJ2dOIHKS71yKvoMcjINCJuXp6U10xEXcr/qsswzyeQ6zp 0w7G81ay9zwC7/mBz9oV/P7G/Nc/545ZKciusLiULbWMRKvpmWjTjMvvXHThkudq2TAA We+w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=DHza7e9u; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=K29hJvVQ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IYOsfe59; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7c6cd6d8dc6si35222a34.268.2025.11.04.00.56.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Nov 2025 00:56:13 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=DHza7e9u; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=K29hJvVQ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IYOsfe59; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7PR+OaWGTws8MKz7Sx80YDo9ZTlfRrydO45xnOBXRGc=; b=DHza7e9uZTk+r5WC+kOtH3OYeT fOkKWfD50MXJlnunZp2gVNYtsfl1FJgTC+0f8NV686+K8o1OmvqEqtSPQDt8BpeAlqXLE3otCt8f+ cDSs8Md0UMj1BDVj7GYKw4/msStDHLMOGorSK03ERSy7Ij3P7oWQI4eSpa48tj+HXIGk=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vGCpm-0005r0-2L; Tue, 04 Nov 2025 08:56:10 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vGCpj-0005qs-IY for openvpn-devel@lists.sourceforge.net; Tue, 04 Nov 2025 08:56:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=emMHVWl/JYFkP50p/KwXmZOSKsYrutK/q2JHZjqLR0c=; b=K29hJvVQrWH7nPtxbcISpIvzWP 3qXXOOrpw3nOqVnYaUH1rV7bQCHC+AcwuELNEnGQHnW69mnqGhm61ZRXwjKLyehYuZRD6RUXPC8Zb eW/6cSat4Ez45mX6DKP4UmZwWo3KcETbuMnZcTce8exgGN6jqF73ZjC+TuqW7NNjQer8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=emMHVWl/JYFkP50p/KwXmZOSKsYrutK/q2JHZjqLR0c=; b=IYOsfe59x5yTdL/yCnluFEJcip hogrWG1xod94vsOp9yiJkvaJ1RjKQtx0wOH9oA7zLr/UAzNVqI3QqX58jv5z3gYnAkPIQFmEQ2zQo A4ByMeF6VEjI8lXTnFRqegl9MeAY/bH0iS64TCQST3d3b4kjlvlol0O54fV9xe5DitWE=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vGCph-0008Ka-Nv for openvpn-devel@lists.sourceforge.net; Tue, 04 Nov 2025 08:56:07 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5A48trju008245 for ; Tue, 4 Nov 2025 09:55:53 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5A48trZj008244 for openvpn-devel@lists.sourceforge.net; Tue, 4 Nov 2025 09:55:53 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 4 Nov 2025 09:55:47 +0100 Message-ID: <20251104085553.8218-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Marco Baffo Update mi->reporting_addr(_ipv6) for status reporting purposes after sending a PUSH_UPDATE containing an ifconfig(-ipv6) option. Github: fixes OpenVPN/openvpn#889 Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vGCph-0008Ka-Nv Subject: [Openvpn-devel] [PATCH v2] PUSH_UPDATE server: update reporting_addr after ifconfig update X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1847848622022725758?= X-GMAIL-MSGID: =?utf-8?q?1847849463231872273?= From: Marco Baffo Update mi->reporting_addr(_ipv6) for status reporting purposes after sending a PUSH_UPDATE containing an ifconfig(-ipv6) option. Github: fixes OpenVPN/openvpn#889 Change-Id: Ie15977b44091445b9d1edebe885d92ec5cb5770a Signed-off-by: Marco Baffo Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1340 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1340 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 261209d..2b944667 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -4346,6 +4346,7 @@ multi_unlearn_in_addr_t(m, mi, old_addr); mi->context.c2.push_ifconfig_defined = false; mi->context.c2.push_ifconfig_local = 0; + mi->reporting_addr = 0; } /* Function to unlearn previous ifconfig-ipv6 of a client in the server multi_context after a PUSH_UPDATE */ @@ -4358,6 +4359,7 @@ multi_unlearn_in6_addr(m, mi, old_addr6); mi->context.c2.push_ifconfig_ipv6_defined = false; CLEAR(mi->context.c2.push_ifconfig_ipv6_local); + CLEAR(mi->reporting_addr_ipv6); } /** @@ -4389,6 +4391,8 @@ { mi->context.c2.push_ifconfig_defined = true; mi->context.c2.push_ifconfig_local = ntohl(new_addr.s_addr); + /* set our client's VPN endpoint for status reporting purposes */ + mi->reporting_addr = mi->context.c2.push_ifconfig_local; } } @@ -4408,6 +4412,8 @@ { mi->context.c2.push_ifconfig_ipv6_defined = true; mi->context.c2.push_ifconfig_ipv6_local = new_addr6; + /* set our client's VPN endpoint for status reporting purposes */ + mi->reporting_addr_ipv6 = mi->context.c2.push_ifconfig_ipv6_local; } } }