From patchwork Wed Nov 12 09:39:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4587 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:33c4:b0:7b1:439f:bdf with SMTP id u4csp2445032maf; Wed, 12 Nov 2025 01:39:24 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXHitjYps14ogsYC9dbP0ofC71Y2CEkZNsoAgAa0CIQcEBP6tmWKf7sxyrll3i5d0xu9B4BX/z3BI8=@openvpn.net X-Google-Smtp-Source: AGHT+IHp/j0poLvbDvsTC0rCRO+mfu7MAhCdH1tSW4SO2ovD1ap8yBCEIbYWbUhFNuUvC6mMQqdi X-Received: by 2002:a05:6870:8111:b0:3e8:3382:aaf9 with SMTP id 586e51a60fabf-3e8341b241amr980390fac.37.1762940364399; Wed, 12 Nov 2025 01:39:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762940364; cv=none; d=google.com; s=arc-20240605; b=O1kBL3ow/y3g0TQPrKUPjePRUdIy63gTQMpEvOslTHLvG2UDQs3GBhQgKwlZjruuFW ISRan+aWuh7jAyIlH6AXf8QKOmr2XNI3/kuj20lGeZdxbVL5EtsfaFq4FV8vRak0aqMJ rZhS6BOVGxjZynzVSUAaaWvMplLQcrPLAyz61J3dxMXC+akPnMef5dCK695dJubbnnoN af1uO5r52MXx5YUr41oQgN2jw4fwZ7v0O+Fj2Y6oZ+4yHrpw8N2Ro8K9onqvQr398XLT 6sgzmafpGLFO4q+uTabalyY3YJQ1sFneHutHHbaCm9CbUDE6RE6F8Z0NlIWWVpRonMh+ rGDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=OMBprSto9Q87Np0Mz+RwzwxiRZh+Lk38jOW2NGUFj38=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Mq/SPYs1/uERpxtcpWm1c7uFQrmaDJY2YKU1mgQpeYQdt1R5WTrqCSnKRHmiKmW03s QonXjo+vJFiYaQdNdRKDKoydQqvnOlx16DiyljlE5M+rN4Y6K8il6+VKX0vYjckEs3Bp /6UItseuRCAC9YKiahuO+/x4y3J6w8Uj1/udFK5HivgZbB+SgjBhc6qDuZAzXukPAIJd i215geGvqwzN4mN/DYqiDzKpVd+P5P5ziQ0jHETUbUmzX/iFY0Z/wloZgEgFwtGtvuLC 3h2+stdne6fJ32Pe8ewL8lCOxpN4NGWEdwuVkq79/a9THJtW/HBhZcxlEwQoWqtwkhci DuhA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=hytqq1mN; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=E9+fcqla; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=REtetbRo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-3e81f8b7deesi1769021fac.372.2025.11.12.01.39.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Nov 2025 01:39:24 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=hytqq1mN; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=E9+fcqla; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=REtetbRo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OMBprSto9Q87Np0Mz+RwzwxiRZh+Lk38jOW2NGUFj38=; b=hytqq1mNh8XcwlTjfpNgPuCn1M ouA27B0X4joeP8jfkXjk8lMCwmAMj2iGJTzIYfEjWeT1RbzXu9EP5m2EEJtZUNqQc+qzYbkhXLF33 jh5QlJflzscGlYkrZp7VZ78CgTOX7nQ4dF4XtXPHOtLTfvZOLAJsG9iDBWgUAwhwoqtw=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vJ7Jw-0007Bw-QH; Wed, 12 Nov 2025 09:39:21 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vJ7Jv-0007Bk-6H for openvpn-devel@lists.sourceforge.net; Wed, 12 Nov 2025 09:39:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yzZJeK7djXWq6+00rz9zJRchiXxxnWPuEJZZ2Bw/JAk=; b=E9+fcqlaX+oQbt5kiu1WPNXvld O/3WDj0ebmUwsOZz9bVtWTVVQHiVqoj8mYRRVr2ik5RWhIVBMBJkm10OpPS4mJ5YfV8ejIaf1wH/d SWad9pSWSV0MYDcHiq8txWHzPSOnUjFwbQ7XGDfn6FaEwXGqSP6RvqUdjb+HM+O+PfLw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yzZJeK7djXWq6+00rz9zJRchiXxxnWPuEJZZ2Bw/JAk=; b=REtetbRoOSNckPykPRTK3fPtN3 LU9JB+SiObD6BBlj6WcZEJjVsOSTPB3trBMWVkuXc2RV6r/mUvpnjDpRyVGAio7yA/6KVcnj14Yor bJd5EFwgdldRs9gDpqp4kNUHPrF6XIQhgwdFT/JuHkuP6zcLg/+6q41N5t0qxS//9XVM=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vJ7Ju-0000uJ-TH for openvpn-devel@lists.sourceforge.net; Wed, 12 Nov 2025 09:39:19 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5AC9dCJk024212 for ; Wed, 12 Nov 2025 10:39:12 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5AC9dC7I024211 for openvpn-devel@lists.sourceforge.net; Wed, 12 Nov 2025 10:39:12 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 12 Nov 2025 10:39:05 +0100 Message-ID: <20251112093911.24196-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Heiko Hund Windows filesystems do not differentiate by case, so we shouldn't either. Reported-by: stephan@srlabs.de Change-Id: I4d905da3add9b8a3daf349eb1bc830a017cf493d Signed-off-by: Heiko Hund Acked-by: Lev Stipakov Gerrit URL: https: [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vJ7Ju-0000uJ-TH Subject: [Openvpn-devel] [PATCH v3] iservice: validate config path case-insensitive X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1848576955754518497?= X-GMAIL-MSGID: =?utf-8?q?1848576955754518497?= From: Heiko Hund Windows filesystems do not differentiate by case, so we shouldn't either. Reported-by: stephan@srlabs.de Change-Id: I4d905da3add9b8a3daf349eb1bc830a017cf493d Signed-off-by: Heiko Hund Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1362 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1362 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Lev Stipakov diff --git a/src/openvpnserv/validate.c b/src/openvpnserv/validate.c index b3189b7..3381503 100644 --- a/src/openvpnserv/validate.c +++ b/src/openvpnserv/validate.c @@ -78,7 +78,7 @@ res = PathCchCanonicalize(config_path, _countof(config_path), fname); } - return res == S_OK && wcsncmp(config_path, s->config_dir, wcslen(s->config_dir)) == 0; + return res == S_OK && wcsnicmp(config_path, s->config_dir, wcslen(s->config_dir)) == 0; }