From patchwork Wed Nov 26 10:49:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4634 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6c3:b0:7b1:439f:bdf with SMTP id j3csp3242206maw; Wed, 26 Nov 2025 02:49:51 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUbhHG4aunAleWuJeDL5llg8/TdvLqysewrybCOkErk+n09CysV3XPyAFwj9Ft1kzMRU+lI1Fdbcls=@openvpn.net X-Google-Smtp-Source: AGHT+IFse7hb4+VwGyLA+/JU2ckRtMOdCaAGNefa4311WuTsLZz+RfIhefKaZ5oEviUaAmRfkRH9 X-Received: by 2002:a05:6871:d04c:b0:3e8:9537:f84c with SMTP id 586e51a60fabf-3ecbe58603amr8096898fac.46.1764154191137; Wed, 26 Nov 2025 02:49:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1764154191; cv=none; d=google.com; s=arc-20240605; b=A2DlPh5Dr9nclSpqWvDZ084IikpgZ5En/BJ3M9tsMdsXGq3kESrQTg1dYTcmlj9x+C wMjmaEBl7DnY+mQiYsto3kpFwMZFRubzpqNTPfE9hCUKlhYx5GD1K4tt1DSwoqZ8Myz0 ydbE8uuIgdfEFTmo9Nn14KxXdChqO1Tuy0ZFbisaniJlzS+VtAS8PsPZzMMIaPAHf29Z bv2erryAhA2pkcmZ2FL4hF3FHwyewhXtUuK9A7JLAh94biAkYHcHbWRQ1hERpM4nZNc3 lzNYFhUcQzZ8WVwi2UivW2SAC0MF0t6loL6HY5/QIDz+WsPEdnL5ymTn1liaDl3sHxDA LfJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=QUDoG1wOMB3pc5CFsEAb8LcSX5diY08y6uVAC2X/9SI=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=WgumDRXR0d981xPMpKvkreRz+hoyYA+hqnz2nyko1DRjIuldrXSzt7KvnDZtYjd2uH reFJsksN7GshCbWv1MQnbahfE3VSwOa0iOBqbQxHSCx5JbLNfNR+QzVXHaimJfMwIcdB x4pO7jWdyo4SVksjYMKwaFKJTz36Rpe3FzDX8Okatho1p4JENPq5Vl0NIq+FSgZbEnHu r/KPCa/+uA+CHNNKmNE+GsYhxHEHyZMiwPhnV21esuEA3+HT+dOQwnjpAJ3ZuE+bRVq3 Yo0KO5hFWAYcCOmrvU+RKX0FeKOuLDc/dH20I6BB14V3WUvFkAmOiAXuTC9zLVT9LVpO 5gEg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=SWh458sd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mGWODQPE; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=i7n6I6c0; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-3eca1b64b86si3370384fac.623.2025.11.26.02.49.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Nov 2025 02:49:51 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=SWh458sd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mGWODQPE; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=i7n6I6c0; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QUDoG1wOMB3pc5CFsEAb8LcSX5diY08y6uVAC2X/9SI=; b=SWh458sdrW5DFe6i/IpZ0xE1Rp K8RUy0Ig5G0XM0h9cGJyayMC8oLuGzgoMdlnQ/UIX69ZNhVCudTIP2Uye6kBbGMa3ASh04HkS5uq+ rTlO32fh6Xr6vmvpCdm6vzpZWmgmik6q9TplkWpa61ODs2HomeblMhDqi4pEZBcrnMaQ=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vOD5o-0003Gt-78; Wed, 26 Nov 2025 10:49:48 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vOD5m-0003Gl-Ev for openvpn-devel@lists.sourceforge.net; Wed, 26 Nov 2025 10:49:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mVS0Y57SQ89cEQQE8RZVVuvLy4JxFGf0a5Q65/tLPVc=; b=mGWODQPEO+l5+IwWnlNz9QxOMD QblgOaqa89x7c67h1GFMeQqrFG3ikzUdb+qDKz+43JRAE2Hbm3l1Tksu70aEVOpFvs9UYXUOYHdCQ V63rspww1i+zAc2TfcuGM3upCXQOXf9FKKUOgv+lxAiLE8rW/1SaIWXnoevlRRmqYS70=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mVS0Y57SQ89cEQQE8RZVVuvLy4JxFGf0a5Q65/tLPVc=; b=i7n6I6c0qYYl7mC3f1Deqxf2H3 3SUyR57S5d70KCzEAEtp4wEzNF4VjSd5qf1AU3Vv+RaViaMTFhMoDD8npTDgIvY6I3Vnc3y1qelQi KtAmStbQ2JFYPRoEhAQZ9tj5WzlegJGV0xBM/lmEuL473YLOtXRoCwH5LvpdKWIOI1bA=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vOD5l-000757-El for openvpn-devel@lists.sourceforge.net; Wed, 26 Nov 2025 10:49:46 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5AQAndin005635 for ; Wed, 26 Nov 2025 11:49:39 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5AQAncDU005634 for openvpn-devel@lists.sourceforge.net; Wed, 26 Nov 2025 11:49:38 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 26 Nov 2025 11:49:32 +0100 Message-ID: <20251126104938.5612-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Heiko Hund In case there is more than one non-ignored interface domain, the start of the next domain was off by one glyph. That meant that all but the first domain was ignored when converting to MULTI_SZ. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vOD5l-000757-El Subject: [Openvpn-devel] [PATCH v3] iservice: fix off by one error X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1849849745270384480?= X-GMAIL-MSGID: =?utf-8?q?1849849745270384480?= From: Heiko Hund In case there is more than one non-ignored interface domain, the start of the next domain was off by one glyph. That meant that all but the first domain was ignored when converting to MULTI_SZ. Reported-by: Marc Heuse Reported-by: stephan@srlabs.de Change-Id: I3ebf30f6d9edc66eb54fb3f1b5634c96d156b1ca Signed-off-by: Heiko Hund Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1395 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1395 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 31a7ffa..23d18aa 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -2234,7 +2234,8 @@ return NO_ERROR; } - pos = comma + 1; + /* Comma pos is now +1 after adding leading dot */ + pos = comma + 2; } } }