From patchwork Thu Nov 27 10:53:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4641 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6c3:b0:7b1:439f:bdf with SMTP id j3csp3989247maw; Thu, 27 Nov 2025 02:53:59 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUIYsiClBo0L1DVoJ+sqZXkyK23tyLJZ+eLWxh1Eiow0SOn4CCZphdcwRtWIE3JPNaJLai/RsFRyPs=@openvpn.net X-Google-Smtp-Source: AGHT+IGNNDO68uvpYCD1KWGvIqt9ll+J3uY42ZSalaCJu6I0ikPxrtOFDf1UCPkemYxdTuvGUdiV X-Received: by 2002:a05:6808:1b24:b0:450:d504:9281 with SMTP id 5614622812f47-45112ce5055mr8638339b6e.59.1764240839802; Thu, 27 Nov 2025 02:53:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1764240839; cv=none; d=google.com; s=arc-20240605; b=BHIjYgHwYG6hwtr/K0UBaDnOdm+FwyG+ny+KgmiXeOek+K4XZdPik5ordZRmIuUEqv 7772p6CwS0Zbntb3WQBQHRQJ8z5eFDXFaoQG8PFXQlcWZIFmOZ5JAYJUfDTQJDqKwOAT XOxP8KWzI6GPlplPOQzkVkDxAhyLAbTZNggS8CjUZw+jBX3bI9AP6s0yVE2V805HAutR Z8kkDY6o+fEtpgnBJVZfusUyHKqqTvxcdDhS1T+qkAQ0z3M1QmdQRrsiCSbbRIdEXToG FNOLNeWynTVFp5C0mJrT5j0GssjMTETPioYs2YhYmTUGq0x0iV+VfXuAO4UaKZRwyNNt w3vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=mS3Gazw6rNNBcbtmTEV5QXjccia5ClU8IBxE/dqUnSY=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=NGBiKZpBKdhFW5jtidRD1tUm+VqvZOZW0jfbyf4yHk+MNwi/qC904T5ieHbRNCHRGx ubhrwGyipEt837HFVpwYL9UCNr9yxyK+HI5VWhgrpR+cV0wH8nrlW4j2fMHNhVUPpwBP mZvueKjE4mDTK+u9EcIOVWq37KbLYyIpY9iEInQw2K2NfSSCS27PdjPs5RkFwxAEXX/f HWz9KomHMEDnNKS0OY/mQQfVuX1sSTTMMvph+2v0AO/nBtH3kFUB5X1oH9e2zuI7ObXu hCytnqM1CPhlHTCHkfdmXo/NtT/8Be9xfcD1haZnMISNE6gvedCq3cZVNDWgAziJNXZP o5JQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="OfHJ/ejs"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gimAuUx6; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XVGT3JtB; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-453169a3e57si113093b6e.4.2025.11.27.02.53.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Nov 2025 02:53:59 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="OfHJ/ejs"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gimAuUx6; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XVGT3JtB; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mS3Gazw6rNNBcbtmTEV5QXjccia5ClU8IBxE/dqUnSY=; b=OfHJ/ejscIKeNWU5ETDWqgo0Jb S0Atdy8DkRWcuKuLEsTP7MEahUxkOcohihtxD99T7PHBPgbyhJMuZle7iEJ9Mdi5CYXpb1PXA44XD TN6SaGSoa2cev9hdxyh+2xy2PklKuDnA+Rs2VhfrLr7BvkLs6RupkLNkGjsz/O2EEMEM=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vOZdN-0000hh-7J; Thu, 27 Nov 2025 10:53:57 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vOZdL-0000hY-OY for openvpn-devel@lists.sourceforge.net; Thu, 27 Nov 2025 10:53:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0jq6M2S0LuQvzyOGUJPZQyi5uztWkDa/tpTexJLumNk=; b=gimAuUx6zB7mKtPliZAprvCadE Nel+fsY6wLsCe9Vb/otuV5g7zwBJNEus+XOnwF5+Mw+CnOYY7obLab//KZQTxvaT/gdJoN+r3aLKF PEndT1icWpSABloLHLYL0Gy104kg0eK1l5YecFfr9vjUyNa6ZmybeIp41jGjyP4fT9vs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0jq6M2S0LuQvzyOGUJPZQyi5uztWkDa/tpTexJLumNk=; b=XVGT3JtBExoZ545I/0LzDRJ85/ Bry2nRGtNYAhTdrQkxcvsVlOuYMldT2qaO2o6HIuykiEcsdW4kiMEUbiJOJHpZIGflbfAg4E5jkon eWq52mSHavR2oAUd8tPEPcZWlETRoFMjUQMvwjT9AwaS+/X4uvj2YqynweTVPD5wdxps=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vOZdK-0004Xa-P7 for openvpn-devel@lists.sourceforge.net; Thu, 27 Nov 2025 10:53:55 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5ARArh4k030744 for ; Thu, 27 Nov 2025 11:53:43 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5ARArhUj030743 for openvpn-devel@lists.sourceforge.net; Thu, 27 Nov 2025 11:53:43 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 27 Nov 2025 11:53:37 +0100 Message-ID: <20251127105343.30723-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Do not run configure checks that we do not actually need. But add one missing check in CMake for strsep! Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vOZdK-0004Xa-P7 Subject: [Openvpn-devel] [PATCH v2] configure/CMake: Remove unused checks X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1849940603084381945?= X-GMAIL-MSGID: =?utf-8?q?1849940603084381945?= From: Frank Lichtenheld Do not run configure checks that we do not actually need. But add one missing check in CMake for strsep! Change-Id: I0da2cc8bbe9e394d1bb55cff496ea3e11584ca20 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1409 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1409 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/CMakeLists.txt b/CMakeLists.txt index c4d50e4..f101a1b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -240,6 +240,7 @@ check_symbol_exists(chsize io.h HAVE_CHSIZE) check_symbol_exists(getrlimit sys/resource.h HAVE_GETRLIMIT) +check_symbol_exists(strsep string.h HAVE_STRSEP) # Some OS (e.g. FreeBSD) need some basic headers to allow # including network headers diff --git a/config.h.cmake.in b/config.h.cmake.in index bf1899c..f68ea27 100644 --- a/config.h.cmake.in +++ b/config.h.cmake.in @@ -281,9 +281,6 @@ /* Define to 1 if you have the header file. */ #cmakedefine HAVE_SYSLOG_H -/* Define to 1 if you have the `system' function. */ -#undef HAVE_SYSTEM - /* Define to 1 if you have the header file. */ #undef HAVE_SYSTEMD_SD_DAEMON_H @@ -332,12 +329,6 @@ /* Define to 1 if you have the header file. */ #undef HAVE_TAP_WINDOWS_H -/* Define to 1 if you have the `time' function. */ -#define HAVE_TIME 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_TIME_H 1 - /* Define to 1 if you have the header file. */ #undef HAVE_UAPI_H @@ -347,12 +338,6 @@ /* Define to 1 if you have the header file. */ #undef HAVE_VALGRIND_MEMCHECK_H -/* Define to 1 if you have the `vfork' function. */ -#undef HAVE_VFORK - -/* Define to 1 if you have the header file. */ -#undef HAVE_VFORK_H - /* Availability of different mbed TLS features and APIs */ #cmakedefine HAVE_PSA_CRYPTO_H #cmakedefine HAVE_MBEDTLS_SSL_SET_EXPORT_KEYS_CB diff --git a/configure.ac b/configure.ac index 030f8de..60799e0 100644 --- a/configure.ac +++ b/configure.ac @@ -475,13 +475,7 @@ ) AC_C_INLINE -AC_TYPE_OFF_T -AC_TYPE_PID_T -AC_TYPE_SIZE_T -AC_TYPE_UID_T AX_TYPE_SOCKLEN_T -AC_CHECK_SIZEOF([unsigned int]) -AC_CHECK_SIZEOF([unsigned long]) AC_CHECK_HEADERS([ \ fcntl.h io.h \ sys/types.h sys/socket.h \ @@ -492,7 +486,7 @@ AC_CHECK_HEADERS([ \ sys/time.h sys/ioctl.h sys/stat.h \ sys/mman.h sys/file.h sys/wait.h \ - unistd.h libgen.h stropts.h \ + libgen.h stropts.h \ syslog.h pwd.h grp.h termios.h \ sys/sockio.h sys/uio.h \ poll.h sys/epoll.h err.h \ @@ -546,12 +540,6 @@ [[${SOCKET_INCLUDES}]] ) AC_CHECK_TYPE( - [struct iphdr], - [AC_DEFINE([HAVE_IPHDR], [1], [struct iphdr needed for IPv6 support])], - , - [[${SOCKET_INCLUDES}]] -) -AC_CHECK_TYPE( [struct msghdr], [AC_DEFINE([HAVE_MSGHDR], [1], [struct msghdr needed for extended socket error support])], , @@ -657,11 +645,11 @@ AC_FUNC_FORK AC_CHECK_FUNCS([ \ - daemon chroot getpwnam setuid nice system dup dup2 \ + daemon chroot getpwnam setuid nice dup dup2 \ syslog openlog mlockall getrlimit getgrnam setgid \ - setgroups flock time gettimeofday \ + setgroups flock gettimeofday \ setsid chdir \ - chsize ftruncate execve getpeereid basename dirname access \ + chsize ftruncate execve getpeereid basename dirname \ epoll_create strsep \ ])