From patchwork Mon Dec 1 09:01:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4650 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6c3:b0:7b1:439f:bdf with SMTP id j3csp6777345maw; Mon, 1 Dec 2025 01:01:34 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVq7pp3yyLicyWhVUBxfW/x/VL5elHDB9tSu+WeA/wl2qZn976WEKkBFGbGuXwwleh29OY5lgIr630=@openvpn.net X-Google-Smtp-Source: AGHT+IFeCsVJ/Mn81Fiz5eRCPcuHuUlYH/FwtBunfqugfgjNtOsVALFe4Unts3weCMw4UL9zdT5X X-Received: by 2002:a05:6830:3115:b0:7c7:620:b1b4 with SMTP id 46e09a7af769-7c798722bbbmr17095162a34.0.1764579694141; Mon, 01 Dec 2025 01:01:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1764579694; cv=none; d=google.com; s=arc-20240605; b=Lj66UpVFZPP4cJVLG/KufpgmSbxRaXEZXj/k+CnQVHZTg+kgFcfa9bPGtHrpDVbf2r X7mTlXjFfpFUTvPj6J0vtytl14eoYewyPXqxfpDoAec13hJ5+d04Q1MZkzmjN1bv7tr+ JU10rNnARQjIheHzg0mZonc0AVWElylcuy2roVtVbX/7M2h+OoF8Rar6sGH+GVHbLAzF 1XNhAUUJZxj2akbQrkX54DrmUZ4ExCq0ZlwYtrKT2+RH4AkCl7xOauGlLvAVfTA1zrd+ NWgGV8slq04BCBd9zISum8AxL2GiwEoXuQRmvnzDh4G/C4+jaVlt/gDpNjd+82U32r5K rvNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=XRuSUsfnPyBIHzAWAzaecJfRA+/z3EP0hDY7ih/+yQM=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=ktyzSdLJdCFGrwFypwKUM2bc9P9zGwSK1UCRJ7Ye97r6LcM87XdIFViqJr+ZNvYp2S yu0o5lAbRbU3sbhTXuwMcKHxA4Dpv2Uw9PMq4CCOU+oGURpdSlHQ+zycfC2DPNcAkUtq QosYzipRQFhyaT5jPKl4COQx/vuF8FhiMpk8UjbShQ786V8Od6b25aF4RktpdpevebVJ Kjbw8ck56HygOirPV/lagIVkAflFYvWBoqy3eFa3M4QzQLHwzoXTk41wCUXQryp1gLJl RYkFCodbHCXG6UhQreIoeop2M/EbKnu8F7izTiovmniInLwbivLxxRXrBIsKowLz2rSC X1aw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=kJQdZPHI; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=KVxZoCpS; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=GfKxc5nL; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7c90fbea964si2080332a34.175.2025.12.01.01.01.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Dec 2025 01:01:33 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=kJQdZPHI; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=KVxZoCpS; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=GfKxc5nL; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XRuSUsfnPyBIHzAWAzaecJfRA+/z3EP0hDY7ih/+yQM=; b=kJQdZPHIBjJLajtECqMrE8ASP1 uotWWR9RaJkfB3zVbkj11YfwvvqYjv39j9U23gEuwL53fTroWPcfWa9Tz0S4hNqQYBqF29PqEOrEZ zDXNbvaRwHLwH91/sDtyv34DLYcBQSKLdHtw19m8w1wJjGLTFgOKE3gpEnMHK9Of6j0w=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vPzmk-0000Zl-8e; Mon, 01 Dec 2025 09:01:30 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vPzmh-0000Zb-Ru for openvpn-devel@lists.sourceforge.net; Mon, 01 Dec 2025 09:01:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LeJ9gHGMah+1qEuVc+1OIhLcFSw+674R0LEhp8yYKTw=; b=KVxZoCpSqtuVp7BFwuE8xpR5Qh d7APYhnVZXz2keAeb2BsZuZgZUaaEbqIwXBOVX1rXziqrkUwcqm/AORkfvijnCrHjX0GQqBMJyPEf MaPk1zGnrVPtwTEU36PG4/2yiqy43keW67hBG6hgn2Z83WM5VDqAt++lgPDjHM/JB8zw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LeJ9gHGMah+1qEuVc+1OIhLcFSw+674R0LEhp8yYKTw=; b=GfKxc5nLVJRVaQv74y+PTVK8M4 hQaq3MOobSljDBuZM8uy+gxAw+oMNm0yjMF8UZP3+qziK6ekdFhwh++FzwliXLQ2AT/Gud9p9ucg4 By2UL10Azeh8wsD3neZjl1sY3qQaNV3rn3MdIgjOacq+uRjHCnScsl/tKpK+1Uxa4DlA=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vPzmd-0006Cq-C5 for openvpn-devel@lists.sourceforge.net; Mon, 01 Dec 2025 09:01:27 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5B191Bi0005505 for ; Mon, 1 Dec 2025 10:01:11 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5B191Btx005504 for openvpn-devel@lists.sourceforge.net; Mon, 1 Dec 2025 10:01:11 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 1 Dec 2025 10:01:03 +0100 Message-ID: <20251201090110.5487-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Works on Windows 10+. This ensures any UTF-8 string we pass to ANSI API will not get interpreted in some local code page in effect at runtime. Although we do not use any such API, OpenSSL dll we link to does (e.g., the store API used for reading certificate and key from files). OpenSSL may fix this in future versions, but this is an easy wor [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vPzmd-0006Cq-C5 Subject: [Openvpn-devel] [PATCH v1] Set UTF-8 as the codepage using manifest declaration X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1850295917549688811?= X-GMAIL-MSGID: =?utf-8?q?1850295917549688811?= From: Selva Nair Works on Windows 10+. This ensures any UTF-8 string we pass to ANSI API will not get interpreted in some local code page in effect at runtime. Although we do not use any such API, OpenSSL dll we link to does (e.g., the store API used for reading certificate and key from files). OpenSSL may fix this in future versions, but this is an easy workaround that looks harmless and appropriate. Fixes failure to read certificates when filenames contain non-ascii characters reported by: Carsten Mietzsch Ref: https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page Change-Id: Ic4e233c788b16a862c1fddcf314a3da661072fb5 Signed-off-by: Selva Nair Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1413 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1413 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Lev Stipakov diff --git a/src/openvpn/openvpn.manifest b/src/openvpn/openvpn.manifest index fa5b3d7..f964152 100644 --- a/src/openvpn/openvpn.manifest +++ b/src/openvpn/openvpn.manifest @@ -14,6 +14,11 @@ + + + UTF-8 + +