From patchwork Mon Dec 8 11:36:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4659 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:29c3:b0:7b1:439f:bdf with SMTP id g3csp596058max; Mon, 8 Dec 2025 03:36:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXR7wLXV8gb1MRb1P/bOB4mPbeSrJwhnnes7S/8GAfCEt12O6Vz9+gXW5ZJH4VTCBUkLBl5aOr3wuE=@openvpn.net X-Google-Smtp-Source: AGHT+IGbzlQG2/e7UF4iuFX+qZg+2qLqz9e7WdGAxh2gAmg0cgGSJA4mt+p8Vvk65EIJXp7Wd9lw X-Received: by 2002:a05:687c:20c3:b0:3ec:5a83:38fd with SMTP id 586e51a60fabf-3f544037e31mr2922398fac.31.1765193814114; Mon, 08 Dec 2025 03:36:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1765193814; cv=none; d=google.com; s=arc-20240605; b=IfG9Tl0a2Bq1m3D0Y6QKoVMczKHlElLaHI+GYdmUjZahtCp+akE+Xh4qCBwZgKUnfv peROCOqP4Yrl+Mq9Vu+QPjUIZeScbvQn9HXj/k0sRYDTWIO966N7wUSwKMiJ1vLLiV95 B+UJyo+5kzUUtM3e24ubFcBN/njaQzpIEstwiM39RGdpE+d7DvAhDdwwX5Z+0GIGdTBH AGzfdnuOupoz15rS9mE6KfSvGnFnSTYwxROWQj8dDnJ4SciLGnM7CLJ6kU50vxfuiaNe qCu1m9JncPYqig+tcnTHDowg7XRQAc53QIA8tQSrxOBHhWfaTW4Z/zqlr6K2r1/4jcq9 Aq9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=PKd1n5C3Vf+KF2YW89Uacz4HX/ESBhJHyX0NLcA5J3Y=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=PkAiczpAWdFkUmfFWIYozsVYsuRHfTNKSGVXTEQpOjpsCkrXQVYIf4yANqgtJaXFik BA4eCMcUVwlmtm35nIFaG1/N7HkXFdcpYV4NtRdCZWD9KNUIQcIvHjti+C4gNPCX2Zcu JRPzDfIgfBmM+EMhukLEuDZEzNk6zpOFlCZMmGsd8naPjuMrSkwahPVxT6d+W0oeU3i5 kzri4jic8iTqQK32F0NApPTY/5WkAohs2SSE4LtIVv1wIRNA8OY1Wr16I0QxUd2UXH85 +6i7ain72xDqafhTOVr5SoqVrDGf5FkG6S80vnf4sUtnEMzgvtVDOoII7aDnhmBkWW7h f3Tw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=JRF7H3tF; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=SK1uip1e; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=PMg1W+2x; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-3f50aa212cfsi6763292fac.74.2025.12.08.03.36.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Dec 2025 03:36:54 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=JRF7H3tF; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=SK1uip1e; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=PMg1W+2x; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PKd1n5C3Vf+KF2YW89Uacz4HX/ESBhJHyX0NLcA5J3Y=; b=JRF7H3tFO6H/IMRTe7SfUP5StP DYkMDf/xtKifezPtHxhgLn41oAoxSpJof5plG2/3gma78/8oW9haX67J6WdbNDe6dsW/MKwRpL6zA SXB9F+NEiwFhINXG7+Y81ZCKUFsu7D9RPhPUXySLW4/jXJ2gTNQmYGiU8oYp9esVnbQk=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vSZXu-000442-BZ; Mon, 08 Dec 2025 11:36:51 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vSZXs-00043m-Oj for openvpn-devel@lists.sourceforge.net; Mon, 08 Dec 2025 11:36:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tp/ipHrefaVQMKjNFzEzGoDHRzwUEKzodS9UiuLr68k=; b=SK1uip1ewRtwEyfYJ1Y89gPyBu f3jwYY0EyFxWBaFYjCRt3Nuv8yOCmMBSKTrvQ5Te5akbfy5qqeXKmNfIFWmDJnojzXaehPZ2h6J5f RiczSq2xpOaUaVStmMf9k4tv9TWNIyixFGajBHDt9wOZKIb/38sNeAaXvbcUpdNk7e94=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Tp/ipHrefaVQMKjNFzEzGoDHRzwUEKzodS9UiuLr68k=; b=PMg1W+2xleltkmUqMlLGF5N2U/ WrWG+QCx+uvReAoq4Aew/tijsnboDqLzg8FEyJ2YQ4e/6SZEqq23ktpxshlg6KyWW8oEvGlAJU5wO lH9Bbl7h9yBiVJ2HrqiyHNgxvoyDLoqj0CAO7Qfi4d7kmBiLwwn+UXN47661FiEAoOQI=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vSZXs-00079z-IX for openvpn-devel@lists.sourceforge.net; Mon, 08 Dec 2025 11:36:49 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5B8Baadp009685 for ; Mon, 8 Dec 2025 12:36:36 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5B8Baapd009684 for openvpn-devel@lists.sourceforge.net; Mon, 8 Dec 2025 12:36:36 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Dec 2025 12:36:30 +0100 Message-ID: <20251208113636.9650-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld But exclude the added checks that currently have failures so that we can keep /WX enabled. Basically this excludes -Wconversion and -Wsign-compare, as expected from our GCC/Clang flags. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vSZXs-00079z-IX Subject: [Openvpn-devel] [PATCH v3] CMake: For VS build, switch from /W2 to /W3 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1850939868897964599?= X-GMAIL-MSGID: =?utf-8?q?1850939868897964599?= From: Frank Lichtenheld But exclude the added checks that currently have failures so that we can keep /WX enabled. Basically this excludes -Wconversion and -Wsign-compare, as expected from our GCC/Clang flags. Github: #382 Change-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1417 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1417 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/CMakeLists.txt b/CMakeLists.txt index b3142e4..906fa04 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -85,9 +85,12 @@ if (USE_WERROR) add_compile_options(/WX) endif () + # C4018: signed/unsigned mismatch + # C4244: conversion from 'type1' to 'type2', possible loss of data + # C4267: conversion from 'size_t' to 'type', possible loss of data add_compile_options( /MP - /W2 + /W3 /wd4018 /wd4267 /wd4244 /sdl /Qspectre /guard:cf