From patchwork Mon Jan 12 18:02:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4700 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:b01a:b0:80a:3855:ce6a with SMTP id nz26csp3411438mab; Mon, 12 Jan 2026 10:03:21 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVyBVn7UeG2Pz+TpiAW8LeZHkyeLe9NClX/TR314DH9HoLCeocHWuf2GKSy+GHtQcuuudLUjPYNjBQ=@openvpn.net X-Google-Smtp-Source: AGHT+IFYbVDpfpt0RMmCuKHQCfIAxlvC+6XID8K6UwwX46NSriQUOt1CY6AkVsSqEUQo/5bDym/q X-Received: by 2002:a05:6830:438b:b0:756:a322:311 with SMTP id 46e09a7af769-7ce50ae90cfmr9446523a34.10.1768241000955; Mon, 12 Jan 2026 10:03:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1768241000; cv=none; d=google.com; s=arc-20240605; b=M0bYqBB9JRG8bMIciZ/VyNVF8PqcB38gDBbDptgjBS8xBMDDo+ahSSuCdvSoGbqTlP FcP6e5C1tPtg5TAKh2rsdrRLQZKNdCQF/2vrCphl7R+hC/10hqcDcEKTiOFGlKWTRU1G BPnwnZ4QaE2LuOojKPXJ9aIzXEaX4H5xfjnXLuxmh64wOtMgbK7982B4QLEqa2OoCmKM 4G6OHNjdvi5Sh/iHkl/opQaTaQScTmt/t+XVmaq+Msw62RE4AqSH5JP4QkUkpDxWprdi nVcAEDNqmkC4SBL0J4+E6GsPsjVyCdNG91aQwnWkkHRLACB3SUpUEeKi0IssxWs1wPcD ogSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=haj98PeO5ll/eAeM7NfvrY2Ys8LcLn+K3R/3NHg1uEQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=jmzoy2Y0hYk6slifmt9KPAmr8gEV90KuTNMK0f2tGHbd0H9VDYeStzW/V/ICW0heTY Gc4k9l30nF43Uc3TbpwTzdfHVs2Dfe2LbezCABuqEXUZOKavVBhAfhWTkBsPnWM8fpxB G9ymyDE7fDo0rjWX5N+NmNSx1UFhwOCwf7Kdi1Yu3QN+ZzuLElKYXQRvpEkg5qrpEhCB xkRFpnvXEsRqXW3XoG6uHewaRxoVS0JP5Tj4O1jmG3DDLSFZ2JCIsY/CeLkkp77fj13h uAxsp7J5Y/yzQbLsd71Apz86z+yk0hnHTl3QFhYNsEvqHkupKyg4alkOyno25WZOyRPs vYOA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=R9KEBnKN; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XsN9ir7o; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=H3a55Pq7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7ce477ff1e4si11970139a34.14.2026.01.12.10.03.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jan 2026 10:03:20 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=R9KEBnKN; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XsN9ir7o; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=H3a55Pq7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=haj98PeO5ll/eAeM7NfvrY2Ys8LcLn+K3R/3NHg1uEQ=; b=R9KEBnKN8cHAc8Y37HbDCee//I s0I5g0h2IP706mid0JoV9cstquwFt9kVcgMDr1MjRq0ZO4UUkYsnC6Lik5ZFvzo/UARNveOvjD26G We2hCj7Wxk28m9ExnbM6ghQayl1oYeBTzG/MgxfJ1znguGw8+8fZxGilGzWhCjSUnWxs=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vfMG7-0003w7-Bp; Mon, 12 Jan 2026 18:03:19 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vfMG6-0003w0-4I for openvpn-devel@lists.sourceforge.net; Mon, 12 Jan 2026 18:03:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=b6atHRaBmUtl6BmHEH16OK5AvSFsbBgBRgmJd26jgLM=; b=XsN9ir7ofjfQjKdi0eNXW0u2CI GjTa/ucL926UusO7wCC7Oa2geOhX1CEup7E7M6V8SFCz/Uxtpu1/y3g3tPALbmF6MUmaBVdzudHge ZS1G1OjO7i//nO219h2jFpx+gxwW4MpVB5zbEObAS+diTg1rhVXweKxfrFm6EzVD6OMo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=b6atHRaBmUtl6BmHEH16OK5AvSFsbBgBRgmJd26jgLM=; b=H3a55Pq7NjRxtU3+rPD5Z+TIN8 9Nk9KdcglcYmvmVbv1Rhqvv0qMX3wTo7AJLUChlsXsuKMYxIA5jqZcvSCKPHMlkgkVub+9bWfxb/z tmHfOYtCQLlJ/4UDXbCYidRiQInc2WTWaS8KhrQUi3yoPKZc9KaBGQdiCnE6/qWNtgMk=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vfMG5-00014d-3Z for openvpn-devel@lists.sourceforge.net; Mon, 12 Jan 2026 18:03:17 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 60CI34lp008757 for ; Mon, 12 Jan 2026 19:03:04 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 60CI340O008756 for openvpn-devel@lists.sourceforge.net; Mon, 12 Jan 2026 19:03:04 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 12 Jan 2026 19:02:56 +0100 Message-ID: <20260112180304.8742-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Due to wrong boolean operator the function did not correctly detect when the authentication failed. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#4 Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Signed-off-by: Frank Lich [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vfMG5-00014d-3Z Subject: [Openvpn-devel] [PATCH v1] socks: Fix wrong success check in socks_username_password_auth X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1854135075817787718?= X-GMAIL-MSGID: =?utf-8?q?1854135075817787718?= From: Frank Lichtenheld Due to wrong boolean operator the function did not correctly detect when the authentication failed. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#4 Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1466 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1466 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c index ed2d9e9..1e99c9a 100644 --- a/src/openvpn/socks.c +++ b/src/openvpn/socks.c @@ -143,7 +143,7 @@ } /* VER = 5, SUCCESS = 0 --> auth success */ - if (buf[0] != 5 && buf[1] != 0) + if (buf[0] != 5 || buf[1] != 0) { msg(D_LINK_ERRORS, "socks_username_password_auth: server refused the authentication"); goto cleanup;