From patchwork Wed Feb 4 16:13:22 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 4750 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6911:b0:80a:3855:ce6a with SMTP id o17csp3200279map; Wed, 4 Feb 2026 08:13:57 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUk+rs95lMcVK0y+AKIxaD+IQ03rgUwK1Wp1qHF9oVAMdFIutvDWOsuWfYNmk+f1YEE1CnsqBhiEvs=@openvpn.net X-Received: by 2002:a05:6808:1703:b0:45f:174a:1297 with SMTP id 5614622812f47-462d5632f04mr1752002b6e.0.1770221636977; Wed, 04 Feb 2026 08:13:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1770221636; cv=none; d=google.com; s=arc-20240605; b=VFsfkW1lb2ca5kCyq6D7uyxve5Ig/JFXEA/vRbDjPAFNyuHuI6tcZFDwLWvlQEpMQw ZgpjTIulrybvORc+yt3cR5B8JFQbS6Z6Ne5FlepUarDyz3CL6KqVCJur5QAPYRKA9/+q RLNM/t2pOfN0iLLqv/MaWNupf5tvCygKEYcCsWha3K1Vhv7f//26F15zbxAHEXRBGy9n z5nM+nvtNvv7nSJeA0svRCr1KI3aGpkzTS64qVUqyxt0polLqI05WhEhnLNG3DRB5Noj FknmJ/H0rUPTLXc3SAqhgPvahyhNZxRNGFDSw4IPyxJjA8sZ+IyYEcdVqu9srzRHd89r SWvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=MOGAtwQ8/G2I8DYB5dH6OZcC8AUZuatbTEWhDjH82d8=; fh=oHFsXhGO7ECKiwqrShgwGfAGGPWeuBskwCLeyoMLkfU=; b=d0yhFphrGkpGXEGjta3kj+vO5gOsLUwC7lxhE4cMfIklkCsWQGTjq0BDSqR1phcWf/ /MRovQcZL4ckvaWJ95bkhk4syMhff1dj4co23CmF85kcJycWiQZAGEJsSrkRo7C+2yej RSNH6Brsbw9eLh4VpzKVwQgX72u/xH1VnfmpQdl00LFTN0Eb9jmeC1p3sV7A+XTdGjAx 5n5guFkheqJc5b3ucGCureoDQKT2UV9vJW3e4ym+UKVRNMMiiN+Qyq59PjDVF4XsZ7bA XCj73Onkz74+/MwbuxyGeBUYu3C2EmYS1cbWM5XZPtUaPGVC9Bg/rKKwUjW4e/AFEuvP lA2Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=mu5Xphbe; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dWQD+ems; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=LdqALa5t; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=abD8dx2q; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-40a541f4473si2160438fac.122.2026.02.04.08.13.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Feb 2026 08:13:56 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=mu5Xphbe; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dWQD+ems; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=LdqALa5t; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=abD8dx2q; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MOGAtwQ8/G2I8DYB5dH6OZcC8AUZuatbTEWhDjH82d8=; b=mu5XphbeCDpMHfvoDqLHiA7F7T AUHKEyQVmtYX1zWhu5lEQf+dVotgiljizP7rQFauZ3/FPcBCTFaQ5D+SjNRaHq361wA4IXCnm3Plu xEFUI7421nnafIh9xF8x/QpBUN7rby5ZojcY2JwTekJmL5SLQ+oLUBqjL5aNSHwKec5A=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vnfVm-00044y-Pb; Wed, 04 Feb 2026 16:13:50 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vnfVd-00044l-UA for openvpn-devel@lists.sourceforge.net; Wed, 04 Feb 2026 16:13:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nkHvn9pXHvX3MEDAR8GRBZt/OT3XHXxOfy077hUhVX0=; b=dWQD+emswNTRAGN1GynbXc0S8D PTe2n99T0wh4qzvC5n49DrK22XsNisC23rJphkUvyfx4E2JGx7gu8ETqktzBXTYveA89c/6CJR4ra NpjtBQ00+ug0PyBnL5F+PiBZ3fSUKxv27lpWX02SinkjkrzAsP1svk4qQ4xkgeJGkFEE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nkHvn9pXHvX3MEDAR8GRBZt/OT3XHXxOfy077hUhVX0=; b=LdqALa5ta/UdQQ4sZy+85Xa+oa GGKV+nzqJ1VCsWMdb7nHAeI+cyJJ4j4EP930H0ZsO1doHjBxG+XfVHghikjVuvQ+NO+3IARG9vvIx F/4P1TwpYqE/5+pWc1RE1x9OIDMNJrVN3m1Ht/HWOkLSy75CcFLklsH+EjNECRIgFGZk=; Received: from mout-p-101.mailbox.org ([80.241.56.151]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vnfVc-0007oF-Ed for openvpn-devel@lists.sourceforge.net; Wed, 04 Feb 2026 16:13:41 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4f5llB0lBhz9tfM; Wed, 4 Feb 2026 17:13:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1770221606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nkHvn9pXHvX3MEDAR8GRBZt/OT3XHXxOfy077hUhVX0=; b=abD8dx2qlsnFmnpofEBxBrDqRvPquTEbR8WIG16B9ByFN+05GiflbjIcix/TuoB/jU1PMG B7KZDu8i5Is/jrl7oC3IqKqaYeMc6Rwr/zVo3FCPL5Dld9HAO8onBlHRq4Zszsy3Pz6N8s 3tgpgrX9Mt1y1ofoBGmRv6F366J/6XuwHck8+YMlFDbjnMyJrzPkUOV6Njis5e8YbQr/Jf LlbB2Z5XTERl8gw64U91rP+e1rKsQoyaN5TPWA2ocf58w57xVPBBQActK8V7dExTYQjbnU EKyRfQOMCqmoLbIzZ36JVlNyV5Pupv8V68TXCvBn+SqGuuXQ57Ty1Hb5TEw0kQ== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of frank@lichtenheld.com designates 2001:67c:2050:b231:465::102 as permitted sender) smtp.mailfrom=frank@lichtenheld.com From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Wed, 4 Feb 2026 17:13:22 +0100 Message-ID: <20260204161322.149284-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4f5llB0lBhz9tfM X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe make distcheck fails since we are not listing all headers that are used by the unit tests. Change-Id: I674af04e1a6449544b7def0725337c3b353ea276 Signed-off-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20250531204720.28156-1-gert@greeni [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [80.241.56.151 listed in list.dnswl.org] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1vnfVc-0007oF-Ed Subject: [Openvpn-devel] [PATCH v1] Add missing header in unit tests Makefile.am X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gert Doering , Arne Schwabe Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1856211923362558195?= X-GMAIL-MSGID: =?utf-8?q?1856211923362558195?= From: Arne Schwabe make distcheck fails since we are not listing all headers that are used by the unit tests. Change-Id: I674af04e1a6449544b7def0725337c3b353ea276 Signed-off-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20250531204720.28156-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31830.html Signed-off-by: Gert Doering Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1509 (cherry picked from commit c2776ee0ff03832bb2213ebd19e9a14d37445bed) --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1509 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/tests/unit_tests/openvpn/Makefile.am b/tests/unit_tests/openvpn/Makefile.am index 38a7ab4..0a0f4f0 100644 --- a/tests/unit_tests/openvpn/Makefile.am +++ b/tests/unit_tests/openvpn/Makefile.am @@ -32,7 +32,8 @@ argv_testdriver_CFLAGS = @TEST_CFLAGS@ -I$(top_srcdir)/src/openvpn -I$(top_srcdir)/src/compat argv_testdriver_LDFLAGS = @TEST_LDFLAGS@ -L$(top_srcdir)/src/openvpn -Wl,--wrap=parse_line -argv_testdriver_SOURCES = test_argv.c mock_msg.c mock_msg.h \ +argv_testdriver_SOURCES = test_argv.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/platform.c \ $(top_srcdir)/src/openvpn/buffer.c \ @@ -41,7 +42,8 @@ buffer_testdriver_CFLAGS = @TEST_CFLAGS@ -I$(top_srcdir)/src/openvpn -I$(top_srcdir)/src/compat buffer_testdriver_LDFLAGS = @TEST_LDFLAGS@ -L$(top_srcdir)/src/openvpn -Wl,--wrap=parse_line -buffer_testdriver_SOURCES = test_buffer.c mock_msg.c mock_msg.h \ +buffer_testdriver_SOURCES = test_buffer.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/win32-util.c \ $(top_srcdir)/src/openvpn/platform.c @@ -49,7 +51,8 @@ crypto_testdriver_CFLAGS = @TEST_CFLAGS@ \ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn crypto_testdriver_LDFLAGS = @TEST_LDFLAGS@ -crypto_testdriver_SOURCES = test_crypto.c mock_msg.c mock_msg.h \ +crypto_testdriver_SOURCES = test_crypto.c \ + mock_msg.c mock_msg.h test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_mbedtls.c \ @@ -64,7 +67,8 @@ packet_id_testdriver_CFLAGS = @TEST_CFLAGS@ \ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn packet_id_testdriver_LDFLAGS = @TEST_LDFLAGS@ -packet_id_testdriver_SOURCES = test_packet_id.c mock_msg.c mock_msg.h \ +packet_id_testdriver_SOURCES = test_packet_id.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/otime.c \ @@ -77,7 +81,7 @@ pkt_testdriver_CFLAGS = @TEST_CFLAGS@ \ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn pkt_testdriver_LDFLAGS = @TEST_LDFLAGS@ -pkt_testdriver_SOURCES = test_pkt.c mock_msg.c mock_msg.h mock_win32_execve.c \ +pkt_testdriver_SOURCES = test_pkt.c mock_msg.c mock_msg.h mock_win32_execve.c test_common.h \ $(top_srcdir)/src/openvpn/argv.c \ $(top_srcdir)/src/openvpn/base64.c \ $(top_srcdir)/src/openvpn/buffer.c \ @@ -103,7 +107,8 @@ -Wl,--wrap=buffer_write_file \ -Wl,--wrap=parse_line \ -Wl,--wrap=rand_bytes -tls_crypt_testdriver_SOURCES = test_tls_crypt.c mock_msg.c mock_msg.h \ +tls_crypt_testdriver_SOURCES = test_tls_crypt.c \ + mock_msg.c mock_msg.h test_common.h \ mock_win32_execve.c \ $(top_srcdir)/src/openvpn/argv.c \ $(top_srcdir)/src/openvpn/base64.c \ @@ -174,7 +179,8 @@ auth_token_testdriver_LDFLAGS = @TEST_LDFLAGS@ \ $(OPTIONAL_CRYPTO_LIBS) -auth_token_testdriver_SOURCES = test_auth_token.c mock_msg.c \ +auth_token_testdriver_SOURCES = test_auth_token.c \ + mock_msg.c test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_mbedtls.c \ @@ -192,7 +198,8 @@ ncp_testdriver_LDFLAGS = @TEST_LDFLAGS@ \ $(OPTIONAL_CRYPTO_LIBS) -ncp_testdriver_SOURCES = test_ncp.c mock_msg.c \ +ncp_testdriver_SOURCES = test_ncp.c \ + mock_msg.c test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_mbedtls.c \ @@ -209,7 +216,8 @@ misc_testdriver_LDFLAGS = @TEST_LDFLAGS@ -misc_testdriver_SOURCES = test_misc.c mock_msg.c \ +misc_testdriver_SOURCES = test_misc.c \ + mock_msg.c test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/options_util.c \