From patchwork Mon Feb 16 12:30:20 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4764 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a924:b0:80a:3855:ce6a with SMTP id hy36csp1760954mab; Mon, 16 Feb 2026 04:31:32 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXFm/ax9M2QOK3Gj9Q5NHFg7pLSiUDtxvfbjHq8Zc8z54xb0MyTRd+4kok3LoZlY9WiteHGKKbKGBw=@openvpn.net X-Received: by 2002:a05:6870:d1c1:b0:404:1c81:596e with SMTP id 586e51a60fabf-40f0d577145mr3148018fac.12.1771245092401; Mon, 16 Feb 2026 04:31:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771245092; cv=none; d=google.com; s=arc-20240605; b=lprOYXQgWmHcIjnvCCyOye7pOtagS7jlKkp1R+TeumPQMKk5Mmt/bhqt5BZJ61X31J m/A6Li/eSHJV/tkxJ7Whu7IOzWQpFMFRTL3aIYAEV8EmmD1pGNc1N7L/vAy4yE9UBebu TY4JwoADotezLXmLOG+j2zuXlgfRoLZIb74vvSlE01GkS9xDoYenpvMAQCxDQFQySuB/ 8D4J6OgCqyVrPQb6u8Gm4P6LlRsk2dejDPzlRYAsbkjMAWuOrADOjBWizEJgpePYnD63 SrdLi9sfWkOan6zomkJ2FscSkg4e2rqQ8EzYiU25Vm6kbmtKNDw+O+7L7CMw364CnMm2 jLQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=Ww0cbXfAQu6KBR8tuFglJCDVwi/Hrqpkm5G2oSvtLyA=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=ZpkPeQSuAa7v6eV3ZyzuFTyuPy6sqORE0rA4ID7qOWFZYpsVZnAlug+qLURK+1XcLi 5HJElt3xf1RFTEHcupGy9ZKSWOnvYxqa7kznDeC3qNdwCLCcILrKMOSSQDOvxvWKI/8M /xSZJYA6IOZ9LPA6ij1/Oi4lPuwa4gsp7Bg7yC4ybYWpx0UcYd792+0uBDkbgnpk0V0M VHTX8LNpetwwXtsmLcOj4Q359TonmxWCFA3hbvWiMw3vDJSI9D6rc2FRXqX4lt1ecPQm PumUfG8UDdlvFeD/dq7dHR8evZZFa/G0T/plH1r6CXy087Mv5OE23ZNxl7tjze4tSwxM lgBg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=aoa94nfV; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Bm+l+vVq; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=B9efYVzR; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-40eaf427c4fsi11689497fac.401.2026.02.16.04.31.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2026 04:31:32 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=aoa94nfV; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Bm+l+vVq; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=B9efYVzR; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ww0cbXfAQu6KBR8tuFglJCDVwi/Hrqpkm5G2oSvtLyA=; b=aoa94nfVDyOyMDU03bl1iMCwbx grqbuLUBWK3aT2q7uiZ6Z/sieYSQo5mFluNMe6RSHpKlNj6j+v7P2DGxXPEOqIkFBL+zB1HKVqmdv /M8GMKznhrWDJisgzSjwGSx9FAqwT1ryrw/0nUt9g2weHEuus10+e6ZPZ6AiLDutMWmM=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vrxlA-0001A0-RQ; Mon, 16 Feb 2026 12:31:28 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vrxl8-00018o-MW for openvpn-devel@lists.sourceforge.net; Mon, 16 Feb 2026 12:31:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LfwyfbSE+zHePTLbfBRL9GyUVrT+9++oS/s7NjInnh4=; b=Bm+l+vVqsO1Yxd8StVbyKSMOZx actxcY+VBE97EIzP9Xbhpxs1dKy0G+8whFeiwdCOmUn8IlZjqcvqGSr9xF97urkW+ERfRJBRRoRef bSJXXMqyVJWI9OI2WcjsdnDdUMFKwfLjNethIQMd5dBal2UHcqM5GfNdb+uTILqwY/Zs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LfwyfbSE+zHePTLbfBRL9GyUVrT+9++oS/s7NjInnh4=; b=B9efYVzRdJBLm+Wa0T8OrAXZcB K4FMH4Jt4YmqcM7WL3GXlKRQHCPYPHpiClg4OyZbpLxZ3ePG8OFnnp4xTg/Ig4lVU+PELCMG8mvZQ 1z6yiZ/vqHkDsEqBBvQiCmhC5Sfzrkx/C5Ghqe4G1ju9NkYVmf8NOv756xJ9Ige4ET/k=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vrxkN-00006b-1H for openvpn-devel@lists.sourceforge.net; Mon, 16 Feb 2026 12:30:40 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 61GCURRI003350 for ; Mon, 16 Feb 2026 13:30:27 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 61GCUROV003349 for openvpn-devel@lists.sourceforge.net; Mon, 16 Feb 2026 13:30:27 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 16 Feb 2026 13:30:20 +0100 Message-ID: <20260216123026.3310-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld This takes care to add missing braces in case of one-line if-statements or loops. Apparently we never tested this specific error and we had no existing cases in the code when we did the reformat. Noticed this during a code review. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vrxkN-00006b-1H Subject: [Openvpn-devel] [PATCH v1] clang-format: Add missing InsertBraces: true X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1857285094356160989?= X-GMAIL-MSGID: =?utf-8?q?1857285094356160989?= From: Frank Lichtenheld This takes care to add missing braces in case of one-line if-statements or loops. Apparently we never tested this specific error and we had no existing cases in the code when we did the reformat. Noticed this during a code review. Change-Id: Idb1e96a4d0a618089db4290c5980d192985b5d29 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1529 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1529 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/.clang-format b/.clang-format index 1cce4c3..cbec0a4 100644 --- a/.clang-format +++ b/.clang-format @@ -31,6 +31,7 @@ IndentGotoLabels: false IndentWidth: '4' IndentWrappedFunctionNames: false +InsertBraces: true KeepEmptyLinesAtTheStartOfBlocks: false MaxEmptyLinesToKeep: '2' PointerAlignment: Right