From patchwork Tue Feb 17 17:13:00 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4773 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:ab03:b0:838:aef6:1aff with SMTP id xi3csp687216mab; Tue, 17 Feb 2026 09:13:23 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXlYk5i3fD/03GBay5hkbRrRygTPFhcu3hhLYeENb8VloPRM0W31iA4cAQRVx7EICzUYTs+69vvyuU=@openvpn.net X-Received: by 2002:a05:6870:6985:b0:3e7:e20a:39fb with SMTP id 586e51a60fabf-40ef3aace67mr9671485fac.11.1771348403598; Tue, 17 Feb 2026 09:13:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771348403; cv=none; d=google.com; s=arc-20240605; b=RKBXopAZkxiziZZN43iS44kA3FGLeZPifEpCN/9D49VZJ9IxvrdZ9ibd6ce8RTXKrG JP06k/iZRgB6UCxyZzrZpdu9TZoixfFlz5TopakgglqTCkYR6udZ4CRhos41pL5DLabK VhLPJS9P2Rs03hDyZfq5xserMk3OgbFcACkiCYMrHnAOd7TwGoKzCA5MkOyp37nY7QEW cWZM/a8mCXJcNASW0z4X88nwnS+e0YCWkK/ecdQnBY1gEnMwhsMXuh4qbRARfFId26lx HXDzgLoW168r0+fWqYHXGb7oDsdow0t7btKWCMZTdHhDBqSNf5bNVFxAfm5ROpHjvQDC Rnvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=rKapnd0l+PvX2xHzUanZDDLJLXmnj8SZGnzTyC6rGFk=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=N95qBLBcRpe2LJ0eFft+sXdeYJ2ZdYS6fKsmdKMl0cdEPOhDrhwjifaTw4KspGPoBz Q8OViiXqLNJpSqYB+2AYJSM530pTr9DZq85CNJ6QnXLCYF4+yNTa0TMV153hYvmGxXpW 2Sfa2ujdPNsrVJOiKEGiAFkhGtuHL0iBuscveFJ78iuUm29xFnp+zVqnA3N1w6OJxxv5 FSs2eKoMfuwWgB2qc/kK4kHMXAKrvbpNUJfXP2cQZO/+sfGTnTJS/Bepjd7jfjS0Rh7W cv+1XdsyyohmpeGLDLuJr1oPRRtITyE+DOSjhYIwL5jqesaPwPnNAxzbset1HUuxFCQ9 QLLQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Quj+UMcl; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=chG+FhcH; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=INWlOM0Q; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-40eaf417a04si15000079fac.374.2026.02.17.09.13.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Feb 2026 09:13:23 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Quj+UMcl; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=chG+FhcH; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=INWlOM0Q; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rKapnd0l+PvX2xHzUanZDDLJLXmnj8SZGnzTyC6rGFk=; b=Quj+UMcljdTGMab0MWfPlMBOhM t/d16DFPB7n2F2WXgylk05Y+6WhwCaU0gWlXnz7lhhuADQjx7Fe3N8suUKkUoQu1jkxN/4J+O4BTu U7AiKlMzCmITSpAoX74eJ89AV2839leYkjtwwcJmr9V1kTfHOz7SXeBvuG3B2/sQDB+E=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vsOdU-0002mf-S8; Tue, 17 Feb 2026 17:13:20 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vsOdT-0002mX-Hq for openvpn-devel@lists.sourceforge.net; Tue, 17 Feb 2026 17:13:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+SRc7G6AoMcjQonf5817iKWiiayzMYZI9/z2gXzO3Mo=; b=chG+FhcH6Iz6aFXE6R3Ry9WXai FqyxZOcZ7d4dJ8IxVAM42uHOppKNS2ZKLZBaiMX4MfT940WqSbZMm1U+QyRqFd++Ygn2+O645hOr3 yhaHbyYV0nlObu9HHpl+x2KYHPOWnrAwHN5Aox3Bt9hQZsUBY1R6PKeFLesaxNjqyeG8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+SRc7G6AoMcjQonf5817iKWiiayzMYZI9/z2gXzO3Mo=; b=INWlOM0QpMx8OHsEPQqsd126m4 dErdaGrpzCnDh1kdka70q88lY8PRZSSWhWip4/Gu5a9vfD6jtHuFzLBpNud/UO46FGZCTciTGy1lW swGwFQiHR4s1IKAEXYbrpRyTmg+HVhFXw4f560UwZVIq9dn2pUe9moTujDzDbiLWz9Ko=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vsOdS-0007ND-6Q for openvpn-devel@lists.sourceforge.net; Tue, 17 Feb 2026 17:13:19 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 61HHD6Vk031244 for ; Tue, 17 Feb 2026 18:13:06 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 61HHD6hV031243 for openvpn-devel@lists.sourceforge.net; Tue, 17 Feb 2026 18:13:06 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 17 Feb 2026 18:13:00 +0100 Message-ID: <20260217171306.31229-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Max Fillinger The previous Mbed TLS 4 change removed the mbedtls/version.h include from syshead.h. But this include in mbedtls_compat.h where it's needed. Also fix a warning by removing a size_t < 0 comparison. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vsOdS-0007ND-6Q Subject: [Openvpn-devel] [PATCH v2] Unbreak Mbed TLS 4 build X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1857393423766110526?= X-GMAIL-MSGID: =?utf-8?q?1857393423766110526?= From: Max Fillinger The previous Mbed TLS 4 change removed the mbedtls/version.h include from syshead.h. But this include in mbedtls_compat.h where it's needed. Also fix a warning by removing a size_t < 0 comparison. Change-Id: Ia5d330fe5c922aaa6948c1fb05c9a4947c833311 Signed-off-by: Max Fillinger Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1538 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1538 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/crypto_mbedtls.c b/src/openvpn/crypto_mbedtls.c index cba6bb5..e8931d7 100644 --- a/src/openvpn/crypto_mbedtls.c +++ b/src/openvpn/crypto_mbedtls.c @@ -700,7 +700,7 @@ md_full(const char *mdname, const uint8_t *src, size_t src_len, uint8_t *dst) { const md_info_t *md = md_get(mdname); - if (md == NULL || src_len < 0) + if (md == NULL) { return false; } diff --git a/src/openvpn/mbedtls_compat.h b/src/openvpn/mbedtls_compat.h index 667529e..50739b6 100644 --- a/src/openvpn/mbedtls_compat.h +++ b/src/openvpn/mbedtls_compat.h @@ -36,6 +36,7 @@ #include #include +#include #if MBEDTLS_VERSION_NUMBER < 0x04000000 #include