From patchwork Thu Mar 26 11:06:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4854 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:2f09:b0:83c:d90d:321 with SMTP id fv9csp1223087mab; Thu, 26 Mar 2026 04:07:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXxcn4+Xj2MpM9oeijYQ36loqBKVBxJiipzLFKSO9G3MfiOiVPPeyf0NPLxjzWfyywaX93QNsqZABM=@openvpn.net X-Received: by 2002:a05:6820:4dc2:b0:67b:c122:d29d with SMTP id 006d021491bc7-67dff57525dmr3549354eaf.60.1774523240457; Thu, 26 Mar 2026 04:07:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774523240; cv=none; d=google.com; s=arc-20240605; b=ZLOllWfiwkVCkfvktM/FpQcL45TlVEXR2wGcJ3IH6XSp/elgayxDvK+gok6ND4eMSG 08WRXOWIyUiUGtIuMEslFya0MgdDhfYx9pKqPNEEvsrwQT285QrC/ToDj6m+rqwLlRbO xWjrhTw5xisDACvoEwlT6TXCucs2V8B4J0jQaykPTBpsA7Qztl7rvTyRMTcmOQiuhEuU HvqQ1Ucqny7pgSjCtD2+a1jHh8WRC/rYiYVc/DF3S+u0orBFeSirDkj1BuiOMJft8Je+ MLBxawhLSGJYQSLPttxj9PpOgiS18MTGuULnKt+SmARzEBNpGjDS96TitQK5+YO+5kIO j9sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=GfCVey3FSOfh3W8zfCT7kug/dws9ZJoxh1O5NLh2vwg=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=J2H4XKd6eUCh2ikHqkqhUO6DfBS0Z0UaYiYocKJ0X9Q0LnPBtOb4oJM3uoXONN9v/c WwM1c+oiti34U66ytYCVhIrKOtyaBolu3f61B6RN9OTgpR+j3GPXb6PIc+DzdXuIBbcJ q8UoWyD3xeoZDRk7Iyww3khX+6hPaGps3zs+tFWl9JaUZ2ccLKg+QHCkwspwIIsF4UVe 9XhjOzGpseBlCBjEdcwAc1cDlvMiNSGtSVxZeZ961J43D5iHioJSoEtkFdutXfJXewWF bKgdFopbNmt6TZUNcUty0ByeD+96vUiZ/0TapINvUJP6tuBDuGwkCauGMBARgKJmQu5S PbPQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="l/Teq4/N"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=kKw8GcVF; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="jRb/WUVE"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-67e0ab3bd41si1747382eaf.81.2026.03.26.04.07.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Mar 2026 04:07:20 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="l/Teq4/N"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=kKw8GcVF; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="jRb/WUVE"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GfCVey3FSOfh3W8zfCT7kug/dws9ZJoxh1O5NLh2vwg=; b=l/Teq4/NJTx5577Yjey0XkpZE0 eqOin2uychiesdiVJNdh/r2hkTbpVk7bC2YQXNtUlOt8oNI9LoTps+fn3NN2zjcZqlhGZ4nhwaQ/n GcGZ1IM3O38L9Il605TaoDSIxKRyt06NBDoWe82qq4SZRxIBEaCqcQapqa2h+S0dL0tI=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w5iYW-0003EN-67; Thu, 26 Mar 2026 11:07:16 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w5iYR-0003EG-NE for openvpn-devel@lists.sourceforge.net; Thu, 26 Mar 2026 11:07:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W2jLvP9Mie9ewuhfZXEb4lQIKMoR7gIDdXVRDNZ1m6s=; b=kKw8GcVFttZvjZ3ZXYmF499ni6 82yZ1jm10j1DwILWkSf7I8VEofpjYoBDZoSoNXpuZUgJwWMXvCHl23Qs1HQL9TXbj/2+cIzySJaqX qD9LaBOnQhr8FZFg7xCDhSh92FgmcwlkxL2vYNS47KN0UaEDBGL7NOSy/p2tkxTp/Dvw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W2jLvP9Mie9ewuhfZXEb4lQIKMoR7gIDdXVRDNZ1m6s=; b=jRb/WUVEz5SqnfyMOjyWXpMzMe PMpWfqcWEx8QDRoXFT8zGOr/3gJB+fC38cPRQgBIxL6sbcC/YILXSWjF0Ok5byEsqgRaHcEDimJuk okiRAcMAUQ8IvOIJrUqFi9UxrdlvB45J60owSXaqrW/qWApZCt/ORexXha5cpYkdL7qU=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w5iYQ-0004wl-As for openvpn-devel@lists.sourceforge.net; Thu, 26 Mar 2026 11:07:11 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 62QB6w2t025754 for ; Thu, 26 Mar 2026 12:06:58 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 62QB6w6M025753 for openvpn-devel@lists.sourceforge.net; Thu, 26 Mar 2026 12:06:58 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 26 Mar 2026 12:06:52 +0100 Message-ID: <20260326110658.25741-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe The new OpenSSL 4.0 will return const objects from these objects, so make them const in our code as well. Change-Id: Ia43bb88d9ddf2e82c638011353a64c770f2c2c0a Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1w5iYQ-0004wl-As Subject: [Openvpn-devel] [PATCH v2] Use const specifices in extract_x509_field_ssl X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1860722481040137793?= X-GMAIL-MSGID: =?utf-8?q?1860722481040137793?= From: Arne Schwabe The new OpenSSL 4.0 will return const objects from these objects, so make them const in our code as well. Change-Id: Ia43bb88d9ddf2e82c638011353a64c770f2c2c0a Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1588 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1588 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/ssl_verify_openssl.c b/src/openvpn/ssl_verify_openssl.c index 46401cd..4c492a3 100644 --- a/src/openvpn/ssl_verify_openssl.c +++ b/src/openvpn/ssl_verify_openssl.c @@ -195,8 +195,6 @@ { int lastpos = -1; int tmp = -1; - X509_NAME_ENTRY *x509ne = NULL; - ASN1_STRING *asn1 = NULL; unsigned char *buf = NULL; ASN1_OBJECT *field_name_obj = OBJ_txt2obj(field_name, 0); @@ -222,13 +220,13 @@ return FAILURE; } - x509ne = X509_NAME_get_entry(x509, lastpos); + const X509_NAME_ENTRY *x509ne = X509_NAME_get_entry(x509, lastpos); if (!x509ne) { return FAILURE; } - asn1 = X509_NAME_ENTRY_get_data(x509ne); + const ASN1_STRING *asn1 = X509_NAME_ENTRY_get_data(x509ne); if (!asn1) { return FAILURE;