From patchwork Tue Mar 31 06:01:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4860 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6c4a:b0:83c:d90d:321 with SMTP id c10csp1923489may; Mon, 30 Mar 2026 23:01:37 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXBn4aZYEbVDMxznYNi8sx+BE1mKYrkB8JWo59YG4ex1at2TaAD6MQ1cX2JbJTF0jZHTD5vOlHY0fs=@openvpn.net X-Received: by 2002:a05:6871:c928:b0:3fa:aa1:5b1c with SMTP id 586e51a60fabf-41cec3b8aadmr8452851fac.30.1774936896717; Mon, 30 Mar 2026 23:01:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774936896; cv=none; d=google.com; s=arc-20240605; b=KgCMiDLaOI/S7rU8muna88mLPQZM/Av9iuqggbEzcBrBqxzYaSiSxpcoWYWWVDQLdA ZnCgNLKxDxhp/SeTv3x5CuCEPZ5gKf3hWMq7RmP2+f2Rk3O9F9iNCuOX7fC9ZuKKTc/r R8MooA/OPgEH7LkQPuNfrLroEG2mJTZkmjSLZWjA5rBoZuCMSVdn4v3NpRzyBlmWqVb6 czJ59OKotRBv//52oOZ3cUZbb5LEQviqoYVk5rFQ2YB9fWSGUSyp2O50seZ1/aLZ1Hi8 bCbmMWInv7oKarIybb6lxyrbB192vUS8fSQjm2YWhf6gOo7R5KaLqJ3R5dLDUXHjln/i N9IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=bmvQDp/+/TGa3E/rd3XoMMfZHAlO++YVJQRK+nH8fLc=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=U7gsCenkT5OZprke6JIS7W0L0+41MMFBua/G7J9hNZabNUGO380pDXAqK1wfA9be5+ BZAsZ50ll9SzIekmU+xcEI6YwfN/qaFKMwNR8LX+qLxpsGSqVRtCCLzrvAoyp6cUgbcR My/3r1pTa74W054gJnjpkaEjgDyr3UXFZzpo7JWw4ifGOAzvZYFJxB0EVcr/GFfp+aFF 9NNZQdpSWq+p3w/67aawXH1cQUhS1nVFtHOjgWvkdQAoaFu52ruWE3ecMFy1AsVMqkCU MhE4uZVCJHjJuuDCH/T9d/G6c/hlvp+0XVAqZrdv20RfIvfFWc1qrmG7boYuovZKUybo 5CWQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=GFRWniFH; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="FAJn/SYp"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=aErEZNFg; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-41d048b721esi8411436fac.74.2026.03.30.23.01.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2026 23:01:36 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=GFRWniFH; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="FAJn/SYp"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=aErEZNFg; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bmvQDp/+/TGa3E/rd3XoMMfZHAlO++YVJQRK+nH8fLc=; b=GFRWniFHfo2xJJ0fJ5Qg0rhlOg eiwTH6KrBfJSKfHbkXM8DFLr9eR3l1pAap3cBc3Vg+GdWH1d5uHEw75cFF2WN/XNRO8bvDHuLFWbS ci7MkH08eYydMVMNGWy0vbAwSMBk9jMrdVjIpB3xU5xFzFYfFLLWCGI7ZjopF26UenvI=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w7SAI-00022P-GZ; Tue, 31 Mar 2026 06:01:26 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w7SAH-00022H-Gl for openvpn-devel@lists.sourceforge.net; Tue, 31 Mar 2026 06:01:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cFDFdpBfeyR41Zm7qGHgREbQdA+n+jYr+m6J/AwOtwY=; b=FAJn/SYpNju+eADhxBcWNj0gD1 ZrGkd+1E2GpWx1IVpmIxvAG1MdCMrcZ0WeKeLtdtRhyQKCOwfnPXXmDEC8UIiBCdQYxTwhgNaQgxU BhQmBiqRze02xI5tcETZzjbczVQwhaQMwu1BhWhfPH+s5sCeZ+CDVG7IMD8ZFUgMNaaw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cFDFdpBfeyR41Zm7qGHgREbQdA+n+jYr+m6J/AwOtwY=; b=aErEZNFgMv+zLtHIpQ+WV7KfAX SyzBmvQbtq7qf9fP7KzrcwcsERugfMMj5uLsCBoj7Km9AeBK6myHG3zBoVHHzox1XxalZZKjkDM3H SnFBnLQrHIFGH5z1sf9VV7FFfmmafzbCxSPEjaJa4C69oYCWx0yu1IYMmKL+VGsMdToQ=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w7SAG-0003EI-Cc for openvpn-devel@lists.sourceforge.net; Tue, 31 Mar 2026 06:01:25 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 62V61CpE005210 for ; Tue, 31 Mar 2026 08:01:12 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 62V61CeJ005209 for openvpn-devel@lists.sourceforge.net; Tue, 31 Mar 2026 08:01:12 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 31 Mar 2026 08:01:05 +0200 Message-ID: <20260331060112.5195-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld In commit 91fd9614f980b02772e4dfbb09144c822ec97df0 type of "found" was changed to uint64_t. But due to -Wconversion not yet enabled in all of init.c one occurence of the old type was missed. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1w7SAG-0003EI-Cc Subject: [Openvpn-devel] [PATCH v1] ssl_ncp: Fix type of "found" parameter of check_pull_client_ncp X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1861156231527369912?= X-GMAIL-MSGID: =?utf-8?q?1861156231527369912?= From: Frank Lichtenheld In commit 91fd9614f980b02772e4dfbb09144c822ec97df0 type of "found" was changed to uint64_t. But due to -Wconversion not yet enabled in all of init.c one occurence of the old type was missed. Change-Id: I1a6dfc175075636bc7a5761215547077a9dc397a Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1594 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1594 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/ssl_ncp.c b/src/openvpn/ssl_ncp.c index fdac6925..649665a 100644 --- a/src/openvpn/ssl_ncp.c +++ b/src/openvpn/ssl_ncp.c @@ -307,7 +307,7 @@ } bool -check_pull_client_ncp(struct context *c, const unsigned int found) +check_pull_client_ncp(struct context *c, const uint64_t found) { if (found & OPT_P_NCP) { diff --git a/src/openvpn/ssl_ncp.h b/src/openvpn/ssl_ncp.h index 837f662..dc3a750 100644 --- a/src/openvpn/ssl_ncp.h +++ b/src/openvpn/ssl_ncp.h @@ -49,7 +49,7 @@ * * @return Wether the client NCP process suceeded or failed */ -bool check_pull_client_ncp(struct context *c, unsigned int found); +bool check_pull_client_ncp(struct context *c, uint64_t found); /** * Iterates through the ciphers in server_list and return the first