From patchwork Sat Apr 4 20:33:30 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4871 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:d1c6:b0:83c:d90d:321 with SMTP id ly6csp627324mab; Sat, 4 Apr 2026 13:33:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUQvHfPYlib7rAOg2rOO2e7BsQO+9aRKVq/PznGn7TLK2J38qS7gW9hv6mwVGUSv/0wADkk2k7qFVA=@openvpn.net X-Received: by 2002:a05:6830:6993:b0:7d7:da43:387 with SMTP id 46e09a7af769-7dbb70b897dmr5195141a34.16.1775334833078; Sat, 04 Apr 2026 13:33:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775334833; cv=none; d=google.com; s=arc-20240605; b=E75BKZDp5ebsjC6fJivfhFxv/61Dm0J1bnyUBy3Oi8uIJ2mbTqhwK5AIPX9kMxlfUl 6e0CjYwy3NPsEbXQsN3wxoss60ywQvFbNDsES/ejGvCZiE6euS5Jgb5DAjZVRx3lj5EU piuIeLzgZ23ZSTSDUVqIJdi91b5pGcevsK2E3S2KZNecAuUPQr0N83FFjDWiQ8XD2Uuk +r9Ji0lpx9t46SFc6Vvh1FWQfQeI83N6m7Y8I6wNBR1OABnnF4zJXrWUuo/CQ4CnWThE YKSzVEjQwvf6zDnYkUPUzsidwUh2TJ7xLBaaAdUJxCbxqgOc/Z0WmycXH94Damjhmvgv Y7ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=ULbMLd4JTfT67BmidBwV4e8CHxg95TkDSGWBWSM29hQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=PIuL4v4tiOYO0sR287bDVtqOAw58T64Wo+44b4nGfwaMSSW4r6vTp4rkyu/PfAC2EB 3IXHRIpcgaSohQkwB04OHmdwJ63N0dZ2HY9uuz9KZCnMbpU2LnjTJonl1gMfeRcfgwex 2XZc2cqO2ovonStvHa7mtrrYDHN4sa+lnVYiJNoLyFOxGPgigoWKnh1TjRCMu7r79wzN fNjc6hboJ51ahcWiqEfKETMEk5PXOB1uXDrZcGPKpFTQ6WZFiK8gD2ha85h+aaSS6hW8 rch2Yb0RwCmI0RIqtKhDFonGqCWrTzSCsl/Ouo/HIPVKimURytB2Ck/hLhtyA9JhoBSE 1nuQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=a4fDHu7Z; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=FoVtz8w4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Q+qF+eU7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7dba74eed5csi7733949a34.123.2026.04.04.13.33.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Apr 2026 13:33:53 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=a4fDHu7Z; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=FoVtz8w4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Q+qF+eU7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ULbMLd4JTfT67BmidBwV4e8CHxg95TkDSGWBWSM29hQ=; b=a4fDHu7ZEIPGJeAuUiC1DPiMXF Rl5BR7cJtB5wF2bSpxkTjCXp3ZVQzzMeRZ/P+kf0Q60JA4fsQ6IK9MTPAxQui2PClY9cWpp7sFsmM xjOmNSWkKGOtvN1xlw2x7uAOiIXUFMUMhEuX8XS1Tl4rIoLVQ7UJI3RMQ6T8DuApFPbQ=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w97gk-0006SE-PR; Sat, 04 Apr 2026 20:33:50 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w97gj-0006S8-8W for openvpn-devel@lists.sourceforge.net; Sat, 04 Apr 2026 20:33:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5SZHq7NM4Wv0y6Ip6aLoAL8LbKQeSerQS4xA/gfa7Qs=; b=FoVtz8w4dJO2N/kvhc7qzsy4Ha 70GUMH999iugdu5v3bIsn2e+Ohk/lfXH8UCIjZZ++YpDulx5QhaksBR10/qTyBe/aaWyICSEJAUzs QUoFX+kdPpK2JfViiB2+f+h6ziplr08cSb12302Ii24xe4JkrNIMp0tyNvn70Gax9OyA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5SZHq7NM4Wv0y6Ip6aLoAL8LbKQeSerQS4xA/gfa7Qs=; b=Q+qF+eU7jzmzufR9Tq19KmlxWI SYcnoK555+JsUtw+HAmc3zl+rGpzCMgb8s9S1FWR10Nalap5FCFYzL/iJaOYjW2fOF7vtERx0DGQd IpsYI2upcL/a0s14VJvVWz+tclLOvjDFjS45acZS6lOIEa3Piv+ZLRK5gIK6x63+85HU=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w97gi-0005ew-AI for openvpn-devel@lists.sourceforge.net; Sat, 04 Apr 2026 20:33:49 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 634KXa77030666 for ; Sat, 4 Apr 2026 22:33:36 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 634KXaJa030665 for openvpn-devel@lists.sourceforge.net; Sat, 4 Apr 2026 22:33:36 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 4 Apr 2026 22:33:30 +0200 Message-ID: <20260404203335.30650-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended. Found by cppcheck. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1w97gi-0005ew-AI Subject: [Openvpn-devel] [PATCH v1] mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1861573497618886595?= X-GMAIL-MSGID: =?utf-8?q?1861573497618886595?= From: Frank Lichtenheld Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended. Found by cppcheck. Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index 2eab7b7..7651b4d 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -155,10 +155,6 @@ ASSERT(mi == item.instance); mi->context.c2.to_link = item.buffer->buf; ret = multi_process_outgoing_link_dowork(m, mi, mpp_flags); - if (!ret) - { - mi = NULL; - } mbuf_free_buf(item.buffer); } return ret;