From patchwork Sat Apr 4 20:35:19 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4872 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:d1c6:b0:83c:d90d:321 with SMTP id ly6csp627912mab; Sat, 4 Apr 2026 13:35:44 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUBy+KdWCPnzVDVeuIUKrgzmwiIe/UxYKS4Glz/qU93NdumX24PYVhX29TAch1+94vK2d3NzELoP84=@openvpn.net X-Received: by 2002:a05:6808:1b2a:b0:467:ee:7a2f with SMTP id 5614622812f47-46ef7502174mr4225091b6e.28.1775334944667; Sat, 04 Apr 2026 13:35:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775334944; cv=none; d=google.com; s=arc-20240605; b=W/RBbefzV5+1f+z1t7CIqK0YicGMBodB5NUYCrVSVfsee8+jmxqub1NbALAKgjLUB/ Yc3Bx8OG9vc7CUEvN0Ti44E/QQO8hQ7FhAPDM+prinNwg8VBhos1KUKybfnBgD6x3cVK MIj4XulNQHjmNjt7v77E0gbmL3cSPJfSiRm3MAfAKc6NXCB2wwA5JLOihpv45mI9v2Zm UqOK89nd5oCHZwn4Rsod+5mAc0psll7Zhtj6i2XDKaO+ZK17H/GmZTQAvxwwaJwAvpJH WMGl31lJxD9e/6FwQtJ1ST1su5qoHxigffvSQUevd7P03ZfCUFWVt7Cqw2LpcLWFQIlx H+OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=QqyrQX1ODTm9W4qkh0H/cHRgABX2rg1Vwgorsu8/9Is=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=VhLDIUGLRs97uiKs4wWaM9yS38fuFHxa39AeKcekKLTFNQxSxJldZVaGXZj5aIrTxQ iQzuonE19jRo3UjVMRAgEzRjPbDfh5VMmgJRb+pUDgW0Znj+dI4SPwTpXdqU3HBVpqYz LMJScaBo7sVp5n1RY2QTbrgeVfcuphZNtkMOV1LIrFSvM9gjQBP56rNZd9RHa0+SwrS9 KjkYqzzpb+LrOU2sKfbQuSbywzjhVcTmlI2vysQSA2XMnAV87m69mNvqv4zWaIGJLY42 G2n37a1S43jz2n41I0OtJgP1tCt35eVKS77zNjGsMC2hk7aW6oXQFrbeeziDlHre4O28 SGBg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=fWHoWL6U; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XunHV8Tq; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=RQAs2Pfv; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-42342af227csi1444648fac.37.2026.04.04.13.35.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Apr 2026 13:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=fWHoWL6U; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XunHV8Tq; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=RQAs2Pfv; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QqyrQX1ODTm9W4qkh0H/cHRgABX2rg1Vwgorsu8/9Is=; b=fWHoWL6Ug2iXkV30rS9A4pCjx8 dVArlcicFjgbE8euxsySKM/07VuXQ5JKy4m9zKEWQvdCQOTAVzQGXirXVnnLeQKoKghi6OjAwdkbq og9m5MSQExgglJwZ2wMTdkrZZe6TskTbdTsfWxZWb9gd2JK0GYX5mIbeTFr+Ew29XkcA=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w97iY-0004s1-EN; Sat, 04 Apr 2026 20:35:42 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w97iU-0004rq-HY for openvpn-devel@lists.sourceforge.net; Sat, 04 Apr 2026 20:35:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a5DLKFQ91ndt8sd9AWO5FMkwAhCtBnZ8xABb+x/Lf6w=; b=XunHV8TquHQPo+erwOvIXtdZkL mAhfg77cQQndr9l5We6TMhumJKJuqYjyU2lGuWYN1tFLjuErVsHY7gul4EUb+335xFlRrcZ+kpRB6 Xqmt5HTl7/utWi1ONeLis3SiVm4sGiPGihPEn6RFpDD55BuiHcu/o5wHONDA80ySMp7Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=a5DLKFQ91ndt8sd9AWO5FMkwAhCtBnZ8xABb+x/Lf6w=; b=RQAs2PfvZ/uxpgrChanEly/pu5 0D1hzsVTr8QPxWCjxpGDPAI58ZvbGx3f3WjilMDr9fxMCw+tUI1tMR3N9svzBHCPc6XptUrSgjpvc CRNGDu6AgUQ2myjUnCeDS/qquMp/KEY2Yr5AgO/s9x8PnaNwv8NELRgzrXSprTSmOM8E=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w97iT-0005ii-NW for openvpn-devel@lists.sourceforge.net; Sat, 04 Apr 2026 20:35:38 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 634KZQqm030805 for ; Sat, 4 Apr 2026 22:35:26 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 634KZQYm030804 for openvpn-devel@lists.sourceforge.net; Sat, 4 Apr 2026 22:35:26 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 4 Apr 2026 22:35:19 +0200 Message-ID: <20260404203525.30790-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Increase the integer, not the pointer. Found by cppcheck. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1w97iT-0005ii-NW Subject: [Openvpn-devel] [PATCH v1] openvpnmsica: Fix setting of iTicks in schedule_adapter_delete X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1861573614722707558?= X-GMAIL-MSGID: =?utf-8?q?1861573614722707558?= From: Frank Lichtenheld Increase the integer, not the pointer. Found by cppcheck. Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsica.c index a145b64..fdb610c 100644 --- a/src/openvpnmsica/openvpnmsica.c +++ b/src/openvpnmsica/openvpnmsica.c @@ -613,7 +613,7 @@ msica_arg_seq_add_tail(seq, szArgument); } - iTicks += MSICA_ADAPTER_TICK_SIZE; + *iTicks += MSICA_ADAPTER_TICK_SIZE; break; /* Adapter names are unique. There should be no other adapter with this name. */ } }