From patchwork Sat Apr 4 20:36:09 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4873 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:d1c6:b0:83c:d90d:321 with SMTP id ly6csp628181mab; Sat, 4 Apr 2026 13:36:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXx7+gsnEtTzXo3CO8b/cbSYIlESWvWVu9PzmtH8RnjCup50PmY1djFxT1kPoUEji2SfhjlHvduFdo=@openvpn.net X-Received: by 2002:a05:6870:16d5:b0:422:bdd3:95f2 with SMTP id 586e51a60fabf-423100f91fdmr4409034fac.43.1775334991155; Sat, 04 Apr 2026 13:36:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775334991; cv=none; d=google.com; s=arc-20240605; b=Db5Qv3NCeFx8j4T2dRa09bXfdIwCtNeNmSZdoeUETFZxNpQXJUzhKf2LrUlZgl4m3+ wqMYjJ5BF1CkCj8jVUpxGZ/GMhKnkg8IwquM/QGeLwTzKq1tyhhQWV4/9zcnzIx2OVOi RClxP1o1XGUcqgyBuEDxSmkPQj13qWmI5aWjDOWt/rWUqeiwlgOETJzonJGXOhZAlVIo 9z+hhfBcd2b4bJH20PkcWldAjMnssP4KzXegqHiCIsu/X8+//tiktPKTXX6iDIn7b+u1 8pNRZcxW8+TNv9q0zbP7rfUcYGj4VKrlqf7S9/EniHigzTglg49o5VlTpvSRTX92y6+B Am7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=xFv6EjVkNWmKBClgdaaZrlvT/fsrmjJ64z25nqXaVwY=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=bnNSKNtrmcyNud4GyZpJr8o+NXih2NkZVfJ1YE1IJtlwVzCF2lZe94UNDpX6JPkWMC e7wciueLzlwLxjs3/vH+hszJIT3xHuK7E12yUT2nbqwZ+/vIRdrkcc0/w/bOB1fHrZtP V6hKa4JdTdNW6JAYwRo0NB1zSfz09Boh0pTHCF5LjCHIGjGZxNNQvgwUFwxcneMRDn48 yi/zJHJClCpPe7Kv2QW8DVyw1KHZGGehaYlk4FdbrV92cWUvukYQmYPXlRvuVQiI6Kb9 J4vJiwQzUFpryU6qA9W8ZiGkuzwvq5pw2f5R6f0s+S/kTIEG/MNg6FDqh/LBQuEARw/9 26IQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="SK/x5gNS"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=nPA53Dq9; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=QVAGs3l5; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-422eb4358b6si9546600fac.275.2026.04.04.13.36.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Apr 2026 13:36:31 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="SK/x5gNS"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=nPA53Dq9; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=QVAGs3l5; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xFv6EjVkNWmKBClgdaaZrlvT/fsrmjJ64z25nqXaVwY=; b=SK/x5gNSmqCAEf5okkpkjwrXso h5n3Sl7WmqUczqXjCmIDpKY1FcrtMuysdhIfGfzxTMIQFOe9shktMDrcSF2cXxiNBkqGht05qIqg8 i0Na0JLsmV2wYBEuvm+k+85QjNkxf7TybSgQk6sEOFQbxk4DlHNx5b+U+FePiGEyyNGE=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w97jJ-00069m-5d; Sat, 04 Apr 2026 20:36:29 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w97jI-00069g-68 for openvpn-devel@lists.sourceforge.net; Sat, 04 Apr 2026 20:36:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=txOjXr+lbxJqLcVwNRJufYqGXIY/Tpc4gH+HA/Rfh4M=; b=nPA53Dq9kJlOaQMAKZ4/Iede/e adtqOVlkaGetdaM8B2t3iIUD6PhuA1uFU7MSUNfN094mczdzhuhsYDz7rOG0+rAIobh7tPzWBM/IV lFYSu/Y20SIlGplN6c8FMpgGJw+qyaFFn7fEVtwHSdHETR6DFSukIyddEMUQ0OmkSmVM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=txOjXr+lbxJqLcVwNRJufYqGXIY/Tpc4gH+HA/Rfh4M=; b=QVAGs3l5XMUG3Mr991Kx3xMKPY TBiQe9SOse9rn4ZC+eGYr+bZko+EJOTb9TyRX4XfJpOQh5tnbzFR+rSTGjHRS2ODz3VXmqPwipLQw g3ukcPoV28y1/0/JBrT9l67wbCnee+CldhGYuMMwFPNPjCqabjZpU+w8WV9mowEpUOWk=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w97jH-0005lO-9K for openvpn-devel@lists.sourceforge.net; Sat, 04 Apr 2026 20:36:28 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 634KaFJB030879 for ; Sat, 4 Apr 2026 22:36:15 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 634KaFTn030878 for openvpn-devel@lists.sourceforge.net; Sat, 4 Apr 2026 22:36:15 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 4 Apr 2026 22:36:09 +0200 Message-ID: <20260404203615.30863-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Change-Id: I46499ff1f40dbdb94b84d58d17457d0ccdd75288 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1w97jH-0005lO-9K Subject: [Openvpn-devel] [PATCH v1] Remove various unused structs X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1861573663759531862?= X-GMAIL-MSGID: =?utf-8?q?1861573663759531862?= From: Frank Lichtenheld Change-Id: I46499ff1f40dbdb94b84d58d17457d0ccdd75288 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1607 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1607 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index b7bef46..2eab7b7 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -37,14 +37,6 @@ #include #endif -struct ta_iow_flags -{ - unsigned int flags; - unsigned int ret; - unsigned int tun; - unsigned int sock; -}; - struct multi_instance * multi_create_instance_tcp(struct multi_context *m, struct link_socket *sock) { diff --git a/src/openvpn/multi_io.c b/src/openvpn/multi_io.c index f484fe2..e6f4e9c 100644 --- a/src/openvpn/multi_io.c +++ b/src/openvpn/multi_io.c @@ -46,14 +46,6 @@ #define MULTI_IO_FILE_CLOSE_WRITE ((void *)5) #define MULTI_IO_DCO ((void *)6) -struct ta_iow_flags -{ - unsigned int flags; - unsigned int ret; - unsigned int tun; - unsigned int sock; -}; - #ifdef ENABLE_DEBUG static const char * pract(int action) diff --git a/src/openvpn/networking_sitnl.c b/src/openvpn/networking_sitnl.c index b88f03c..baf6f89 100644 --- a/src/openvpn/networking_sitnl.c +++ b/src/openvpn/networking_sitnl.c @@ -124,15 +124,6 @@ typedef int (*sitnl_parse_reply_cb)(struct nlmsghdr *msg, void *arg); /** - * Object returned by route request operation - */ -struct sitnl_route_data_cb -{ - unsigned int iface; - inet_address_t gw; -}; - -/** * Helper function used to easily add attributes to a rtnl message */ static int diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 1cfbf80..3b18f74 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -3257,12 +3257,6 @@ * netlink(3), netlink(7), rtnetlink(7) * https://www.virtualbox.org/svn/vbox/trunk/src/VBox/NetworkServices/NAT/ */ -struct rtreq -{ - struct nlmsghdr nh; - struct rtmsg rtm; - char attrbuf[512]; -}; void get_default_gateway_ipv6(struct route_ipv6_gateway_info *rgi6, const struct in6_addr *dest,