From patchwork Tue Apr 7 20:53:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4882 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:d1c6:b0:83c:d90d:321 with SMTP id ly6csp2303981mab; Tue, 7 Apr 2026 13:54:02 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW5uzH9opYrDopohgxPdg5Sdp+DoTZAT8DOoHD4pYQMqKyYds7GtMw0c2bwBlLHSM7SNk8jwmNg8wg=@openvpn.net X-Received: by 2002:a05:6870:15d6:b0:3ec:4475:9baf with SMTP id 586e51a60fabf-42310131cbemr11028519fac.26.1775595241941; Tue, 07 Apr 2026 13:54:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775595241; cv=none; d=google.com; s=arc-20240605; b=WHVY4hyCbElCkKK6JlIX4mRH0qOjldAhfCnP1EyFQVwc7MZ5e5LQcY0qlIs8vklw3W IG77aerG+jZiZhXAUNT8RsRdABsEV3bBTHhSo0yHr8dKH4EwmfYYe+sgD6gy53p1TMxU sdCwahQt6XoLzlefkeIKC+FXMazZHwmGYP204qLkopu4EZPJzGLpF47PcJGL4/N6V0Xi HFP3LPLcr41bw+ijnDqJz+2sNo2GtsKIkW+H+X5qSkNuQmPuYk+J/f4Nw7ppDFQ5v/32 kMiKlrz0Yy571XbMcAuvYCtj9ReUN9+sEkyX3TNJuhmy/eI5mqlCIZIHgRxMTp1Y9D1s ocJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=VLGdF3lFss5EbV5+X+BpMLsRCdURdKqcZ0g3EcMzD8k=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=D+C8sKA9WK8IzAStS8RfJtiKp93m9WE8fEeyj2nbuT+9qAxd9gn72FNl+PzXcJTfAR OcQUGm10blkJhuVKmmCPFUaoeXM09gglxvjxvpQkuezKP5etbBRI76wqp/+kJ+bYqZRu BXOSGBAqiF1sLWt8TdDO1ZJKFP6P6FOjQ5iXg0/EuWr7RSgKGRaDHEzI9lQpyGCUkO30 r+63Tc2X0u0MH3u5D+QkdZRyYckiMpgGAUkIXuwusy9IllTJsnAVemlDzr7jzgbiUBCE UYPlWZ6swsNgCsazMMjJntFXJJkig+5A3FD3ll+MSH1+tEkCwhYWS0w8eE7PCMIoSBZy gDvQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=lLBnILKx; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gOHDSd8z; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=AHCv6ela; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4234f634de5si8721789fac.210.2026.04.07.13.54.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Apr 2026 13:54:01 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=lLBnILKx; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gOHDSd8z; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=AHCv6ela; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VLGdF3lFss5EbV5+X+BpMLsRCdURdKqcZ0g3EcMzD8k=; b=lLBnILKx9uIdFokIEhOwFLoFUv oxk5u1N5UFR3mIPPhS2UDaKspmZhiSzFDqcFrb+NiGl2U4+907Ppz3EhmitYioxvDDL/0gbTklc3F DdQUycNqW9SxjBAZ+EDrNAZVm9BIlzGmXVnqwn1RN6jQXSs/f+a/qXeelPvKb9sT+Lz8=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wADQu-0006mF-56; Tue, 07 Apr 2026 20:54:00 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wADQr-0006m6-KP for openvpn-devel@lists.sourceforge.net; Tue, 07 Apr 2026 20:53:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n+XHBWD2kxJGnma+FFGQtXcon8czBOrrkMrONV9G1Ps=; b=gOHDSd8z9M7E8ppaR5SOTM9L09 c9XLYj0CyHm/0wD2TJxD6PdeVbAcvN/FLiVSchyyci7hdDz/PQWzLhqcpkodZDJBaMv1yK76sznIf pLJoFOgg2WNWL1zyhcUa6yiSwcsnjPA0aQCZhU5g1WmWfsNUYphG9jilGXWJcmVzwIu4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=n+XHBWD2kxJGnma+FFGQtXcon8czBOrrkMrONV9G1Ps=; b=AHCv6elaby9kW/FNKCCEHmI9GA IKJl9M1UG/nhRkArOm/K/YPAWMdsU7CLafRknrrys/FwL0WbSnTXmTYlgXlUcpbdTR/+F7Kxt3cST 6lMTgOY8xbkRR2/fqXuzbW6y+0c0ccEdXILc3euVcqPgqNmei4w/CXbMlmA3v41J+mPU=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wADQq-0003h5-Dk for openvpn-devel@lists.sourceforge.net; Tue, 07 Apr 2026 20:53:57 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 637KriiR031281 for ; Tue, 7 Apr 2026 22:53:44 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 637Kri1v031280 for openvpn-devel@lists.sourceforge.net; Tue, 7 Apr 2026 22:53:44 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 7 Apr 2026 22:53:36 +0200 Message-ID: <20260407205344.31263-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Found by cppcheck. Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wADQq-0003h5-Dk Subject: [Openvpn-devel] [PATCH v1] openvpnserv: Remove redundant bit-wise operation X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1861846556100823111?= X-GMAIL-MSGID: =?utf-8?q?1861846556100823111?= From: Frank Lichtenheld Found by cppcheck. Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index a2f9f09..ace25b9 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -3410,7 +3410,7 @@ ea[0].Trustee.TrusteeForm = TRUSTEE_IS_SID; ea[0].Trustee.TrusteeType = TRUSTEE_IS_UNKNOWN; ea[0].Trustee.ptstrName = (LPWSTR)svc_user->User.Sid; - ea[1].grfAccessPermissions = READ_CONTROL | SYNCHRONIZE | PROCESS_VM_READ | SYNCHRONIZE + ea[1].grfAccessPermissions = READ_CONTROL | PROCESS_VM_READ | SYNCHRONIZE | PROCESS_TERMINATE | PROCESS_QUERY_INFORMATION; ea[1].grfAccessMode = SET_ACCESS; ea[1].grfInheritance = NO_INHERITANCE;