From patchwork Tue Apr 14 05:57:59 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4888 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:3ad5:b0:84a:48f:a1fd with SMTP id q21csp526600mas; Mon, 13 Apr 2026 22:58:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ9DcX5Nz90xT3m09T4eypFTvuUh5YjsrJPkcGiY3ppslf7GwzA4aYXD0ek9sKowq4aywYVKFfuYNLM=@openvpn.net X-Received: by 2002:a4a:ee19:0:b0:686:d107:2858 with SMTP id 006d021491bc7-68be8fce656mr8717835eaf.61.1776146303246; Mon, 13 Apr 2026 22:58:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776146303; cv=none; d=google.com; s=arc-20240605; b=U70Y2aXQF9RwSXTCRRka+lGe1S+tKDma5dhgtH0J/TYzv5qTJy9hep6MuckgzRIcP0 nNbe2AsQpGfjOnHYJWUSpWTAZp4cq377yPmEsjZpUG2sem7Kz/t1Y+vFRqXwrIGE5rOB RVd9n7QL5kJFc7ZmNom0xbIN1yNYAwvQK5cKajG62jnz/KNmigu3FsiqNrSPCYUs/bey iUC76Yq7hK0iWSgHD+Uvxq7w7Vp9H0vhrCeHqorR4+uLhDKsm2XufpywR0IcTlJ6fs3E HfU/j+6IUMrzX5YS1MNWDaxSEIUlBUJMqYGi40Nb4MaZTKgT3RwUMZyAfNzV3O9piSFx 1tuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=UL2+6a922rvwoJLMA84++oa4OD9asJVopqYna6nK4lM=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=P/vDwIy+DTf54NC/XR+oJ60E7DJBFLPn4jg1sc2UAGkfcWiry4wlRcaPnmynDXCpJN Vt7oVOGvTIjJH6wp7TYerCKl8ZvyL0aGPoLj5d6VScBrk4JnAraiBrT13PZ+aFQ0EgTm 1J3Gn6Zny1lMymYVknq0UoSL7kNIPBYyrOTxAWYh3Gb29MVIA8H486pjrlqY9bXuPfsi 5rJL3jYy40ynGhit5WGpGzk99GdiePHgescXMXDeLtmUpH9q2GGzUqDiFDOQLZ2l838M lHesmuAv8HZNp0oKMuwvFgO48+GYfwXFwQ8oaQntlPnfKs2D98jJf881Y4P1cWhWh6DG cRlw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=iBqK2iPv; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LTK5aR+u; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Mds+wAWP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-423ddb9d9d1si10880481fac.183.2026.04.13.22.58.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2026 22:58:23 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=iBqK2iPv; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LTK5aR+u; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Mds+wAWP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UL2+6a922rvwoJLMA84++oa4OD9asJVopqYna6nK4lM=; b=iBqK2iPvZEpUPpyoLOr08SsDCf O7fneZ7FwcNzdHiGt5IKQSEw5AZ//LrHbMFJZYcYFLqMbNXCUxUidSH72WP6t2d6f0XE2vb3xXEZm U8K7NRw/HIRI3OmHkvY1tJOunLiXkxRcVpRz0KNZWkxAo74Xyx1MgstoEMkb78k3EiZE=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wCWmx-0004pf-0A; Tue, 14 Apr 2026 05:58:19 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wCWmw-0004pX-Fq for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 05:58:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XryX9jdw+K6QUmcrce5w/+VE5oNMwEz0yQgBYr/vgtY=; b=LTK5aR+u6dvWKDMJpwVKqZo3vE O6uo+gFnwucHOEu3RpH8KnuZHzACCKdQy5NMPOa/GuFC5sTHDm8RkQKgAwBB1hexpTtDLA3sZPM6V dW19eRvRCCKBCr0sePcKgDBZzIO/iqDRwonNGEGB5wwyFG5/dA+4O8r0p9zQ1PeZ63ic=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XryX9jdw+K6QUmcrce5w/+VE5oNMwEz0yQgBYr/vgtY=; b=Mds+wAWPQMG2Vl/4qISqFAR3o+ cT/vltrBtVgXHHtZyYHAtdg44aI4UkQSkkdOh5j51Rt4ZH0sYY2W3ZZ5Ja6WpdD14yOC2X5RUj4dA mq+pdntJ/h8h60btJERh7PwkZ1DdiglOFmm2tUX52P/jSrbvh8kEXYvr+7JdPVoiFFkk=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wCWmv-0003cP-La for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 05:58:18 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 63E5w6dv017000 for ; Tue, 14 Apr 2026 07:58:06 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 63E5w6c9016999 for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 07:58:06 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 14 Apr 2026 07:57:59 +0200 Message-ID: <20260414055805.16974-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Input from stdin is tested. Change-Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wCWmv-0003cP-La Subject: [Openvpn-devel] [PATCH v2] Add unit tests for 'auth-user-pass username-only' X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1862424386300001409?= X-GMAIL-MSGID: =?utf-8?q?1862424386300001409?= From: Selva Nair Input from stdin is tested. Change-Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1602 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1602 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/openvpn/test_user_pass.c index 16e0535..c0a0866 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -282,6 +282,17 @@ assert_true(up.defined); assert_string_equal(up.username, "user"); assert_string_equal(up.password, ""); + + reset_user_pass(&up); + + flags = GET_USER_PASS_USERNAME_ONLY; + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT Username:"); + will_return(query_user_exec_builtin, "cuser"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, "stdin", "UT", flags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "cuser"); + assert_string_equal(up.password, "[[BLANK]]"); } /* NOTE: expect_assert_failure does not seem to work with MSVC */