From patchwork Tue Apr 14 05:59:21 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4891 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:3ad5:b0:84a:48f:a1fd with SMTP id q21csp526899mas; Mon, 13 Apr 2026 22:59:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ+SFDf/2M7WNbLiaSvRY0BBBxKZGINyTi3McZUWzzOQAmkJe1ovdzbNDuMX/kWQYwhJfQOyqtPc4XU=@openvpn.net X-Received: by 2002:a05:6870:9626:b0:417:abf7:d42a with SMTP id 586e51a60fabf-423e120c93emr8506152fac.42.1776146379809; Mon, 13 Apr 2026 22:59:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776146379; cv=none; d=google.com; s=arc-20240605; b=gs62TEK569WkrVfGjx8Ea9B9hLqWP/6gmZSdy5h23bvx3yt47XBvo1w+4WVWFX2mG9 7UTNpAKjlY1/YfKNrKoInrtDTMgVPUrB34+Yj8tjXiCQgabAkKJIz9Qz60DlpXGyqgFP naNggxd4OP2lBxEihcm4xEtkym/IbNGsCcF1lVaMJgrqFUAxyxWtbXFnU1SBaRyuX0K1 8Y46h6x+kjJBTT3jLGxpwBiROJGTiyfUyz6qo0qg7LY7i9qP/O/qc0td6bNBdMadzAc/ txYZNbp8c45BVO5SZvM0NqhH620AJJ0hS7gYnBSj3oilovSuAHH7VZ/k4LpLRUTVinIw BZDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=pkV2uljOohTz7Hwiy2cPmlqvol/OYbiCJ8PTrB2tBLE=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=cPimU9fh719YLj4O1qa8nFV7uVjrGFtgaA3AwdzGSYY86uqsKCsqfn8HH1AbbPJ+uX 1R9JHjYJOfEewjpFBuJ9wZRZ1fORoJojygChr1D36PwYLvN9CHUgvaqFRrXpmn3NHvl4 k63YdgqP+YVoPUPTm/LUjYMKuTIPtzuAgpO05OSldlZOExJfVTUX4IUu20fwAbwv7Se+ zDo9gkiHLG2Yqj+4fPwqbL/wTh2Rpr3q57lwyq1YsXPbZ32chJelBP43IoIZGwHptYI2 vTd9JAM6ZLbl6JO4+i8E1CsiJhtCqhezKivN7TNLds9UxJkpmk9i6HJ/Xvz9Mg72mG2B nRxQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=DGZK2kQV; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="VChfM7m/"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=aZxgntd6; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-423ddb9d944si10983928fac.155.2026.04.13.22.59.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2026 22:59:39 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=DGZK2kQV; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="VChfM7m/"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=aZxgntd6; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pkV2uljOohTz7Hwiy2cPmlqvol/OYbiCJ8PTrB2tBLE=; b=DGZK2kQVJxnBm2bPIJ0qjz435L 0y/TPhdWLvEoNhxWG5+eV4dpRcuFFszK3jspUo0XkoCiAqmYasxqTkWIqdB1AacBMizDcjI+lYRnd dRbtbSwDbi7vyXqo7ZHP+Ogbjuj5OtQfxACehOlStyy+iYNg4ASl33TN9CKcW4AgzOgI=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wCWoD-0000OC-4t; Tue, 14 Apr 2026 05:59:37 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wCWoB-0000O1-Fx for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 05:59:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uFplM5CgafCGhPcPzsOkJA2eLr3Z90JG7KnklmXcArY=; b=VChfM7m/Eq2vS9EIv+IjHPplyW xg97e2e9J6GOyL/PoIKiGGMUnHGm25U15oycz0BC3Lan0hb3WoEa6rmQOinRYObL8+bqTt+Ue9FbO sDcuQmqsv+kQRJc4UwymSY6rzDo1CBbk64IcBgJwznRGXa9x6HYCjOge3udbbhSUv6ao=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uFplM5CgafCGhPcPzsOkJA2eLr3Z90JG7KnklmXcArY=; b=aZxgntd6VfaGskvtXu8FOvNFk5 HpoKxijPOlClkk/CT/vtABclHDQsbH5AuUuZkujqvgroJwcoHZ/fQZL7gpUutp+jGO/6GW1HRxXh+ 7jJLwN5Tguq4+6LPGhzGdPcZOuUnvRI1jI8s69vufUnVAl/foV1HCFOelGBl74holW3Q=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wCWoA-0003iQ-NO for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 05:59:35 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 63E5xS4U017288 for ; Tue, 14 Apr 2026 07:59:28 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 63E5xSGF017287 for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 07:59:28 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 14 Apr 2026 07:59:21 +0200 Message-ID: <20260414055927.17252-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld These are unsigned values, so treat them as such. Identified by cppcheck. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wCWoA-0003iQ-NO Subject: [Openvpn-devel] [PATCH v1] ssl_mbedtls: Fix format string in get_ssl_library_version X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1862424466631719471?= X-GMAIL-MSGID: =?utf-8?q?1862424466631719471?= From: Frank Lichtenheld These are unsigned values, so treat them as such. Identified by cppcheck. Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1626 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1626 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index a62ff76..85c771a 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -1572,7 +1572,7 @@ { static char mbedtls_version[30]; unsigned int pv = mbedtls_version_get_number(); - snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d", (pv >> 24) & 0xff, + snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %u.%u.%u", (pv >> 24) & 0xff, (pv >> 16) & 0xff, (pv >> 8) & 0xff); return mbedtls_version; }