From patchwork Mon Apr 27 17:47:50 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4911 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:66c6:b0:84a:48f:a1fd with SMTP id x6csp6222158mal; Mon, 27 Apr 2026 10:48:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ+UC0I+pFuOTQVwcuemZEOZAGBPbGyj65nM1fbXjvOZ/T+EF0mkN0ZtxCcroQ2i7sPoFkbZ3EYPlNI=@openvpn.net X-Received: by 2002:a05:6820:c8f:b0:67e:294b:7246 with SMTP id 006d021491bc7-6965b9229fcmr8270eaf.14.1777312117806; Mon, 27 Apr 2026 10:48:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777312117; cv=none; d=google.com; s=arc-20240605; b=WYtaCUVKQrX26nigv/nlz0R73mKmikpp2sqvlPbF9MUat0L4OMo0M1qvJ3hrd5VCou 3eoH/tA4pJlcy4ClXYtnt5YPVG4wfkcDReKniuRON2Upz1qEdnVhgy1lccz5VtfpM2MC rHK3RSQw3Omq1PfbOJ4ZcgRRkL1bQdR1IoYm22thJdmv1lVcnEk1EgwxGhH43UCu96jX 4CZ2W++ZXsx4aDKZBTfmYQjPE6Bn7wdof18aqH0gDXpEMFQtvq//hCSRYJ4MYyvDlWjZ Ddz2ykoZJTgNSyeNistWZ3UWh6emLq0WrV3PDflLNP0uiQQY4v7M93X+y/VcuDIo7HxI vYKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=J7PL+x66C71Ej9Xd+TKle7tDviepo/tIZmPYu3TjK/w=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=PnAjEnKmCS8jOudwtY87Un4ANiElKrnzgl1w6+GXwRcdf7U0ayNnfXsbqfC0/shJf4 9z6EVeLwNEeO26t9UbF6DVp2tTbHYU6dSiXQfiRzAUDaqh30m8XvzcrqO01CGqRu2KJ1 8e+sdkf/F3YEghr9u8jqVvw/glCQ6o/JqKszMtHtICV76ecIvmH8j+7NFAZwl8F/se1u k/3f4lTH7lwToFRYqOLQ8JpiQhL1EG1rEJPt+/FDPu3bVXwtYaYO2xioyJglPuFF7DEh Euxal4UKM3M8CZR8iYaJySqAgr0KXXN66le37pSmJxGmxrRFUKbTgWO8vbmXkJPYc3ot vH9g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=bNxhq3Ns; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=FZm3oKPH; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=euKOaqPF; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-6965b929101si3132eaf.12.2026.04.27.10.48.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2026 10:48:37 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=bNxhq3Ns; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=FZm3oKPH; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=euKOaqPF; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J7PL+x66C71Ej9Xd+TKle7tDviepo/tIZmPYu3TjK/w=; b=bNxhq3NsS2HmH3Bx0zDnRruomY TnWt33EInrpUB5FUl7o5dJoDVly2Q9ZfPbgIVHV8/cyrH3vaHu5pCjjwhgc8bKqpWEHuoghLdNjVG lhPzhQyDWludGLzwOBlG9nAm3p2FC6TJxNbwtqKi2EXBVW4KpeG3ZW7nHhbpLI1tB5hs=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wHQ4P-00078e-Qg; Mon, 27 Apr 2026 17:48:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wHQ4P-00078B-3G for openvpn-devel@lists.sourceforge.net; Mon, 27 Apr 2026 17:48:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1KrElnHiGXNMSd9Zu2oJii2GP0ICxXKeq4k85ZUJRIo=; b=FZm3oKPH5wTXhdLy+/YSGtSl1/ xlId0RWKe6jcvIKs6x/6PeG3E6ca3XE+MsifTPxa7dXsnH/3GknEmPfCtrhsCBy3dIiyiPnI+ErMg UpLF1HBM4JIeGHH5QrEV1yMxdDWy68et2eISMG0Ez1cZIGrQeFLzXxBOvUyZhlzGSKXs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1KrElnHiGXNMSd9Zu2oJii2GP0ICxXKeq4k85ZUJRIo=; b=euKOaqPFGeuSMb0GfkI5BwaUhD N4RjN05tViFg+XuQCa2IAZzSk+QT5pH3ONfNmLPxAfv1tylfZvzjWHOZZHug7VXR1XOnqpjwrlkYC 9WTXJXHbOC+eEQuN+0luK2+wr+uJvjxFr23CgHj2p9hfRKpPAOz9gn3snfjreId/oYsE=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wHQ42-0001b7-9J for openvpn-devel@lists.sourceforge.net; Mon, 27 Apr 2026 17:48:11 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 63RHlwq8004095 for ; Mon, 27 Apr 2026 19:47:58 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 63RHlwZt004094 for openvpn-devel@lists.sourceforge.net; Mon, 27 Apr 2026 19:47:58 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 27 Apr 2026 19:47:50 +0200 Message-ID: <20260427174757.4075-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore. While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1 Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wHQ42-0001b7-9J Subject: [Openvpn-devel] [PATCH v1] configure: Remove --enable-strict X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1863646831486939052?= X-GMAIL-MSGID: =?utf-8?q?1863646831486939052?= From: Frank Lichtenheld Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore. While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1 Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/CMakeLists.txt b/CMakeLists.txt index 198c98f..f9cbbfd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -112,7 +112,7 @@ add_link_options("$<$:/CETCOMPAT>") endif() else () - add_compile_options(-Wall -Wuninitialized) + add_compile_options(-Wall) check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation) check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes) check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition) diff --git a/configure.ac b/configure.ac index ecef2b9..5da877a 100644 --- a/configure.ac +++ b/configure.ac @@ -203,13 +203,6 @@ ) AC_ARG_ENABLE( - [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debugging option) @<:@default=no@:>@])], - , - [enable_strict="no"] -) - -AC_ARG_ENABLE( [pedantic], [AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler warnings, will not generate a working executable (debugging option) @<:@default=no@:>@])], , @@ -224,13 +217,6 @@ ) AC_ARG_ENABLE( - [strict-options], - [AS_HELP_STRING([--enable-strict-options], [enable strict options check between peers (debugging option) @<:@default=no@:>@])], - , - [enable_strict_options="no"] -) - -AC_ARG_ENABLE( [selinux], [AS_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default=no@:>@])], , @@ -1270,13 +1256,9 @@ fi if test "${enable_pedantic}" = "yes"; then - enable_strict="yes" CFLAGS="${CFLAGS} -pedantic" AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode]) fi -if test "${enable_strict}" = "yes"; then - CFLAGS="${CFLAGS} -Wsign-compare -Wuninitialized" -fi if test "${enable_werror}" = "yes"; then CFLAGS="${CFLAGS} -Werror" fi