From patchwork Wed Jun 3 14:50:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Lici X-Patchwork-Id: 4991 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:b18b:b0:861:c897:cb9d with SMTP id x11csp3677914mau; Wed, 3 Jun 2026 07:50:57 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ/zJ/BEfxCprrwWL9XqnDO3psazBu6KCOG+cLk1keiWlWHB7FLXF/LIDfrSQYO8mp6YnXTE36vaByw=@openvpn.net X-Received: by 2002:a05:6808:2393:b0:479:d16e:961d with SMTP id 5614622812f47-4865aad5681mr2058657b6e.20.1780498257035; Wed, 03 Jun 2026 07:50:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780498257; cv=none; d=google.com; s=arc-20240605; b=OpcI5xRoANl/7h4IXOiMWSwCdTWGARNvcmatxbksYg2tnNB+bcpBGitjNxOUH5kHm9 Y9B0yytAwaOVFS3SAQQ2OPbmc97dw3ZBPxR1aGHYD2U/eiAqS+UtWLBXvh+fwsLZ2jU0 5GP6dy4y6QB+vZyTA/tsHps8ty+/HFVSMtEPxbGyBCvLibmL3A1CjsQt5pvsOm8qMKTS 1pjSfLinK7Ch7Bn+O7xqKscZTo+xRRiUlqCr/hA+trKDKAMMTNtkQP+/9mfZiY8Jwo/Z iD5RphIWUFoGY1+zU5knHJmFcvj95Oi/dZpoJcFLS6BYPQC5ZBsv+UcWX4RLEzuGQg8R KiHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=uqXfI/dCgQCGxowSPiOCZb/12tkN56dI8Z8kaZERiOs=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=GuArir+J8DSJ45BWBz1GWNGvLQTBtcu/g8Hz3zoicJK+/Y8Ew0yirtxP/RmOzO0TG1 /Y0sJYBiy6Gl0SJEZk1vsM8Hvyp6vVQVnWsPTx/zMpcr1B6JEhthVhHweIhZ92Q19vSD N7NaHryXcQtmEge41B3bGbTrzVDzarz+ii9C/5CmCQwGInAh1i6oTwRljGQTYTDOkwk+ Z83iESnJBg5LP/WEYmCbfPKDmzeAIditRIJrzsrD46x5CA0ogPFsjNoMqkb5TSgSzM4P oShP5A5k97Y9vL+d1Tj/2Tv09rNV2NpaJWllW2CZxBrANspcJqoSWntue2iBewcMvyA2 ESwQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=a6yHsrft; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=WZPuUaVU; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FW3ZutXJ; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=WTdHfdSD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-4865b536b6asi1515512b6e.14.2026.06.03.07.50.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2026 07:50:56 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=a6yHsrft; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=WZPuUaVU; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FW3ZutXJ; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=WTdHfdSD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:Message-ID:Date:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=uqXfI/dCgQCGxowSPiOCZb/12tkN56dI8Z8kaZERiOs=; b=a6yHsrftBhYNFduIszEC9/CZPi qCqS1RxhqSZyxDsAck9Gqgjikm1UNoL4c4iKK8RAYGPXpz/njtg+bdS49DkGwCJQ3lxuMuL4C6RpJ tXvg3av7FbuZtWKZnPIT99qIgXTFogTDYgnHvlomCtsvE/4M8dyUssI6fAvZa7GS6rSA=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wUmvf-0006Q9-Cy; Wed, 03 Jun 2026 14:50:44 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wUmva-0006Q2-NG for openvpn-devel@lists.sourceforge.net; Wed, 03 Jun 2026 14:50:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pxNi6HAtD/FgO+847ryv4NPAVaAGFqOxsws/YdMkiyI=; b=WZPuUaVUavEytwWaaUv6G8mBu5 47f2gHsEMwD+wrt0tJdtDlKwTwd+1mfSasDgIT0o2IzDzh3bqeaE2QSZeP39I8DRI1JFrjhY8AJzN ahZg/OmdYzrWfh18mAxhsJqeLKfG/nEmit44t64GoHUeAdes3i3o8h5dh36EcNwy0Gvs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=pxNi6HAtD/FgO+847ryv4NPAVaAGFqOxsws/YdMkiyI=; b=F W3ZutXJdHBmPCegtk/IUwFtiyaSubmD+vyCkkSyT0K9+0zjHktxZSwdKG7ST0Q6zdMrhfGkeIM9Ue aEXTFKnfR9l0r52NxfSkibtIK7zOXISuZ1EcikNBbelmjg4s6pCu2zyk1wwOkBn2uXJOUHT41NLd9 /1PABA2diLWTPziM=; Received: from mout-b-202.mailbox.org ([195.10.208.62]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wUmvT-0001D8-5g for openvpn-devel@lists.sourceforge.net; Wed, 03 Jun 2026 14:50:40 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-202.mailbox.org (Postfix) with ESMTPS id 4gVrGR1dmKzDsS7; Wed, 3 Jun 2026 16:50:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandelbit.com; s=MBO0001; t=1780498223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pxNi6HAtD/FgO+847ryv4NPAVaAGFqOxsws/YdMkiyI=; b=WTdHfdSDYVWv4OedQRxBGFkktLJUkYhXjdp3NkLL4/PxW94n7gG0pgDFf+r8tn2YXUTYOj 2F+L38Nmt1hTqEl4ABHFRAteVj2y2tLAlh6hEIU09x9O7QRe0wMZC64zbohpN8JBj6/j6c 4/n55LeEDDid/RQwk7ynOXk0iRRfuONEujU9EzgUesQwsCPNBOAW6nVlvQMu1cTtIhCaV8 4YeBv/LDVRniRTRdJUxflMulKGSzSmleIxtJ9/RwW5rhWZaLKY8S7L2uw+thibZSKIS48J yf5mc6SfoHoymdgHPOQmyrALtcKjI0WFiWY5ewIfUjhywPkE260plIVRYN2ZWQ== From: Ralf Lici To: openvpn-devel@lists.sourceforge.net Date: Wed, 3 Jun 2026 16:50:05 +0200 Message-ID: <20260603145007.603632-1-ralf@mandelbit.com> MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: ovpn_fill_info always emits IFLA_OVPN_MODE inside IFLA_INFO_DATA, but ovpn_link_ops does not provide a get_size callback. rtnetlink therefore does not account for the ovpn-specific attribute when sizi [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1wUmvT-0001D8-5g Subject: [Openvpn-devel] [PATCH ovpn net] ovpn: add missing rtnl_link_ops->get_size callback X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1866987740370680903 X-GMAIL-MSGID: 1866987740370680903 ovpn_fill_info always emits IFLA_OVPN_MODE inside IFLA_INFO_DATA, but ovpn_link_ops does not provide a get_size callback. rtnetlink therefore does not account for the ovpn-specific attribute when sizing RTM_NEWLINK messages, so ovpn_fill_info can fail with -EMSGSIZE. Add the callback and reserve room for the mode attribute. Fixes: c2d950c4672a ("ovpn: add basic interface creation/destruction/management routines") Signed-off-by: Ralf Lici --- drivers/net/ovpn/main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ovpn/main.c b/drivers/net/ovpn/main.c index 2e0420febda0..43c36e7cc81b 100644 --- a/drivers/net/ovpn/main.c +++ b/drivers/net/ovpn/main.c @@ -217,6 +217,12 @@ static void ovpn_dellink(struct net_device *dev, struct list_head *head) unregister_netdevice_queue(dev, head); } +static size_t ovpn_get_size(const struct net_device *dev) +{ + /* IFLA_OVPN_MODE */ + return nla_total_size(sizeof(u8)); +} + static int ovpn_fill_info(struct sk_buff *skb, const struct net_device *dev) { struct ovpn_priv *ovpn = netdev_priv(dev); @@ -236,6 +242,7 @@ static struct rtnl_link_ops ovpn_link_ops = { .maxtype = IFLA_OVPN_MAX, .newlink = ovpn_newlink, .dellink = ovpn_dellink, + .get_size = ovpn_get_size, .fill_info = ovpn_fill_info, };