From patchwork Thu Aug 6 11:13:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5206 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:77c3:b0:87d:ab56:3700 with SMTP id r3csp7524996mau; Thu, 6 Aug 2026 04:13:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RoheoE6ch76XM+fuTd8QATe3yQNKUNXIs0MEEO851cPPoGS+bupV3rtTHCzFjiA1t9NQaimKHsQ2iQ=@openvpn.net X-Received: by 2002:a05:6830:410a:b0:7eb:3af8:8c1a with SMTP id 46e09a7af769-7f1e5e9bd00mr9782356a34.9.1786014816439; Thu, 06 Aug 2026 04:13:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1786014816; cv=none; d=google.com; s=arc-20260327; b=IoXTItb01vRCDQmYcBS3h+xZOUz6et9k/pCK5S9t7zdihr6V32wryllOBJ0PUrO3dM 1PMQRjBXeyQoV3aSkdflfUcsWa7nmhy8359n4c5xsqyZEZCZITEQRhPq19dloUIFVJBW tUbJvg/Uh1lQo5wn/J3YMGwYwGZkSdjuwApw3kk7uQUaD43E6iKQeNjIjXNb7bpVIF6X Ogs/TWHaxTZg+ojPZ6W6zNJzSZNWGxrlExok/v6H1mi4t268MAxMT4GIRPhxaaDU0jMj brLxyWCA3Y3bH2gSKkJI8aN36q5q60gx+x1eekwPv7lxHtqz82tOx3sQ0zhi2DTiQrPf XVxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=ty+36ocN55AA5KbpleBqsIp0ppGUHgfzHM2OlBf+ZCc=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=qgmNB3ZSaodiisLJfgz0ugY/6nAJ5ssuVQQeFZoiFD3I5ZZlsfWIx9Qb5tHg+uNt+L l+/zkTqI0SNjQUDG9JMtbiIY0OZPVWqv/JIuwgPvXNPbOvXYSBndgj3LY1bz//2TJakT 6q803oXYKFpFoHeEG4ZG3T5CJ/sQOgIyXE7Vvvw1Pyo3p6RrIQ8RucVd/scuhW9NejfN ix1k8SI/oMYmV61zQObb51jXTscA1Un+ZApm992psh5MR16L8XrC443xL0jBHQ0gkwjn IFzK99s4bGUrFFdAIwQV8ZWh7DpCxsXmntE5LQwcUj0pkPG0gdW7/JFn0XxSIGNkTrS5 c75g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jUjcJXkk; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="eIjOt/n1"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gcgT3HuM; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7f1df663dd4si6410245a34.94.2026.08.06.04.13.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Aug 2026 04:13:36 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jUjcJXkk; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="eIjOt/n1"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gcgT3HuM; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ty+36ocN55AA5KbpleBqsIp0ppGUHgfzHM2OlBf+ZCc=; b=jUjcJXkkoIPHg33gwIpfflW2P2 Gc6HuSXCGaB5r3x43CdyjRtQV0Y3lvxndfV953d10ITKdz3QKuRhxCo70i39G8IgSjYxmDy81nmP/ zFa7tFh+lWbnlVjnS9n29hRPhzdlbLcpgsJE43qfUndzNe6NTcuVXPeUaAbUt/cbzh+E=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wrw2X-0003Rk-JN; Thu, 06 Aug 2026 11:13:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wrw2W-0003RZ-BI for openvpn-devel@lists.sourceforge.net; Thu, 06 Aug 2026 11:13:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YX7h4g07VTrO5X1VbMqaMgQU+UlEG6u/S0zf8vgw36o=; b=eIjOt/n14+1Cf2XJBf/rDMi1wh h2qvouSU+aAJGRBNcaeqqiP4MaTXb784QxAYEVwN566u3NgYvQITLglf1gQTjNgwKBo9SJeEA7Iik PqWEbV3KHado56OSgV+F6tgir6mFgFrD5Sfj5KVPcWmOd7RonP8oiGjwWFILqI8pxnNg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YX7h4g07VTrO5X1VbMqaMgQU+UlEG6u/S0zf8vgw36o=; b=gcgT3HuMBkB78LPlA5bWtOAz9Z xwd4W5qXUugq1MEEGizykYKRLbzJ80kcrdFxGS94dPSL7lG/Hb9WQbSBT+xtapt+9jzjx1OoK706X NSSwIQkYSAjQ4oOnJhTjpAMEkeZvOts75wj1AXog4/edRDNYAJ52msjSUgQv4YUtQcV8=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wrw2Y-0001fE-5g for openvpn-devel@lists.sourceforge.net; Thu, 06 Aug 2026 11:13:32 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 676BDNMZ032163 for ; Thu, 6 Aug 2026 13:13:23 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 676BDNMP032162 for openvpn-devel@lists.sourceforge.net; Thu, 6 Aug 2026 13:13:23 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 6 Aug 2026 13:13:17 +0200 Message-ID: <20260806111323.32150-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe Commit 5978a46e3 (master)/3402f9aa0 (release/2.7) removed the local prototype/function get_random in test_misc and use the global prototype in crypto.h. This made get_random return uint64_t instead of uint32_t. Adjust the calls in test_list accordingly. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wrw2Y-0001fE-5g Subject: [Openvpn-devel] [PATCH v1] Make test_misc compile with -Werror again. X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1872772272001792053 X-GMAIL-MSGID: 1872772272001792053 From: Arne Schwabe Commit 5978a46e3 (master)/3402f9aa0 (release/2.7) removed the local prototype/function get_random in test_misc and use the global prototype in crypto.h. This made get_random return uint64_t instead of uint32_t. Adjust the calls in test_list accordingly. On master the general hash rewrite/cleanup completely removes the iv argument from hash_init and therefore only 2.7 requires this patch. Change-Id: I1a6a0ca8beba3214b21047755246ceeb30141c2a Signed-off-by: Arne Schwabe Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1839 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.7. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1839 This mail reflects revision 1 of this Change. Signed-off-by line for the author was added as per our policy. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/tests/unit_tests/openvpn/test_misc.c b/tests/unit_tests/openvpn/test_misc.c index b9e2db0..a9c3845 100644 --- a/tests/unit_tests/openvpn/test_misc.c +++ b/tests/unit_tests/openvpn/test_misc.c @@ -170,8 +170,8 @@ */ struct gc_arena gc = gc_new(); - struct hash *hash = hash_init(10000, get_random(), word_hash_function, word_compare_function); - struct hash *nhash = hash_init(256, get_random(), word_hash_function, word_compare_function); + struct hash *hash = hash_init(10000, (uint32_t)get_random(), word_hash_function, word_compare_function); + struct hash *nhash = hash_init(256, (uint32_t)get_random(), word_hash_function, word_compare_function); printf("hash_init n_buckets=%u mask=0x%08x\n", hash->n_buckets, hash->mask);