From patchwork Thu Aug 13 18:09:21 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5233 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:5508:b0:87d:ab56:3700 with SMTP id e8csp1223387mah; Thu, 13 Aug 2026 11:09:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RpNtPfUflRRsYVVpIqRJ4nfVUDbImfRT5IrWDERmDTWiFtLllWFIDnljqUxULrGeAlhwWhxI/mQ6Cs=@openvpn.net X-Received: by 2002:a05:6808:19a8:b0:487:530f:5754 with SMTP id 5614622812f47-4b227b86cf9mr7568664b6e.20.1786644580643; Thu, 13 Aug 2026 11:09:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1786644580; cv=none; d=google.com; s=arc-20260327; b=AD8enABntZd3C4PcX1Edxow900qcWrVigSygT/942ZAdLFlLf6vQXoYEdChmGiRmn6 AM8cjYXaAt/UjLS3o7a5F+Grj1LzgBVHEFFVLwnzN5hCV0p+CeCv5FpFDnzEP21qg8zH YoCUaUR021l+j3sM3+4yzqoOOC/x0QrkN3ihAuRxARqlPU6wcGzNFd9HuEuzyLNfeJaA VF+rk5ullT1WeJPg9kpK3kRqA0NLusSATMVzO8J6oAmo6fZRgRLy0kuvkynbMn3Eg5DN lAZqdgZOI5l2aJ+Lih7CPkRgS6SSQyca+s8MlRrHUbytAa+YJQS2o26i5pohz6gSwxt8 9YLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=pEbzpVPu8KRnGdaFnjChrqj9E/ilNY7DJK8hEqOHGN8=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=AOqPDluE37vn7om0v/tdMHiuGDP8YXoPFmvgCves+51zh6/m1mqpiMvimCkgVY8OAX MvPaDJkPtSt9mESCBQqZ2+UKerQKs2FSmHZ0kWmQBZQ+Fdi1/Ef5f89b4eu2EceeOk3X 8/eAMs6s/5VN9MVF58pXpzql1l8aKziISRWeAdXUmjVT86X4XCVqoMRQD2+BFHUBLsOd aQX0sSw6MWJ5g9t0f3FIdTNB1iNQn2vOMHd9KbN0WE+PWz9PXqqaQ1YmTmz83RIk0v1t invvwv+fnaZgRMP+jTKeR3dtmN9vRAYiQtCMTdMM6cyHWbzmrsa06tPR1HUZ1LV4h5Zx PquQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=BgmK57B3; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Vh6NFjCv; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=W10Ua1NV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-4b22cca17a3si5136597b6e.15.2026.08.13.11.09.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Aug 2026 11:09:40 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=BgmK57B3; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Vh6NFjCv; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=W10Ua1NV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pEbzpVPu8KRnGdaFnjChrqj9E/ilNY7DJK8hEqOHGN8=; b=BgmK57B3wpmvUSmZxwShBo32Sm haer1YF9URqEA97JgTXxd8EUYH7gudVXkvaSmVfs5p9CyisDnzjpiEp2a4n2MCabOSF+JJUNZlWNW 3tuJP3GqjLYwH9XDVuGBN3HKbE8CjPLo70UTc/ShrtT1UiLdIyC8nomJqyAScVMZs6eI=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wuZs0-0000ez-F9; Thu, 13 Aug 2026 18:09:37 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wuZrz-0000es-5v for openvpn-devel@lists.sourceforge.net; Thu, 13 Aug 2026 18:09:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E+8c/sxXyx4507mrKDU833XCjMsgi4CuObshLgbhryQ=; b=Vh6NFjCv5NFu9ABcxa/rhZCHgP osxWnO77L+20QrwW0jJzwtc1VavszK50vyx9QfqF2DMLGTnJJp0OLrsowZ6UCwVQYQSBrJi+6SzjG B44T6Ti099hz8sdISTtVRDs9Hb8UsrOSlsouS4QxGhd/t1pJkxeY4ueAvKcFR30NsH98=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=E+8c/sxXyx4507mrKDU833XCjMsgi4CuObshLgbhryQ=; b=W10Ua1NVKnY4CHQ1e3vWtUuJmq B0lr9CXc1st1eTxUMtpngdrsuAMpUaCttvVCxl+0KNAz+IcHcVeSGrfBmXLuLzEzj3PnG/lIvRUOO jJ2Rl4uvlWgIQm0nb49KFm9d57rFzrot5vS1TSXmxMP++b1hYHE352TUimI0TR8h8DYw=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wuZs1-0001aB-Oo for openvpn-devel@lists.sourceforge.net; Thu, 13 Aug 2026 18:09:35 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67DI9RFa003276 for ; Thu, 13 Aug 2026 20:09:27 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67DI9Rvs003275 for openvpn-devel@lists.sourceforge.net; Thu, 13 Aug 2026 20:09:27 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 13 Aug 2026 20:09:21 +0200 Message-ID: <20260813180927.3263-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld This file includes various headers but then doesn't use anything from them. It does not include the header (buffer.h) it actually uses. Change-Id: Ie44556f5ece28b54cc657fa86261b827efb42467 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wuZs1-0001aB-Oo Subject: [Openvpn-devel] [PATCH v1] win32-util.h: Fix includes X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1873432627913774381 X-GMAIL-MSGID: 1873432627913774381 From: Frank Lichtenheld This file includes various headers but then doesn't use anything from them. It does not include the header (buffer.h) it actually uses. Change-Id: Ie44556f5ece28b54cc657fa86261b827efb42467 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1779 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1779 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/src/openvpn/win32-util.h b/src/openvpn/win32-util.h index 4849ea9..fb83762 100644 --- a/src/openvpn/win32-util.h +++ b/src/openvpn/win32-util.h @@ -24,11 +24,7 @@ #ifndef OPENVPN_WIN32_UTIL_H #define OPENVPN_WIN32_UTIL_H -#include - -#include "mtu.h" -#include "openvpn-msg.h" -#include "argv.h" +#include "buffer.h" /* Convert a string from UTF-8 to UCS-2 */ WCHAR *wide_string(const char *utf8, struct gc_arena *gc);