From patchwork Thu Aug 20 09:16:09 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5261 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:4319:b0:87d:ab56:3700 with SMTP id q25csp1568671mae; Thu, 20 Aug 2026 02:16:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RqMpBkbiyrcVVq4qBGFuRWXHo0LOLgHr+NddqeTHT3drbvZ2m80ULOc+LvtR7PAljKheNHnGJKvnJk=@openvpn.net X-Received: by 2002:a05:6808:c29a:b0:4a4:2424:eb0e with SMTP id 5614622812f47-4b2bcc5fc9fmr10644137b6e.20.1787217389553; Thu, 20 Aug 2026 02:16:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787217389; cv=none; d=google.com; s=arc-20260327; b=HJOjGQXqZdO2YVoVukbh4RMoNvZ4ZySXzVANaYOGqyxD0SXc7uOCGzQPwBM0uz/H9M hmCL3jXAUQYWTypFzqRW9EvAQYAn0wchiCoBFcS1GgtfZH1zkGacM1SWNOvedK1lCQJI 54dIQ93BBv9UbE9m2g9UIW2+jkSKKv3WQ277d46Ib63sSpBEKDMRbhQHr0RDA0i2a1RZ IVa3iSwW8LF4Om3s+qNM8ybUwHORNuq0uR4Jct+VkM8IdMndQxptxD/TrFm0jPCSZ0rW UBu3yFUSGJUJaL4+fEWOPgyRrX4i5LB2cpaU1hPV4sUu4B/Fpuc0h0b5s7U5TfOutI8F Oxpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=RFlhMvQ9zn+jGhGVIZkyzxefKhsO07j7RnZNum9FVe4=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=ZQ06E9MNh+5TxQUDekBk6ibAC9dWPWqGmBj+HwlArHr5QvVzOg02A4d3+Kfgg875gy cxBvC0UmVKttnYGXzyKX0bTx3FoLk+kX3yiYsDA8tijhtWHLBnMO5ienLw9v1DkPT3RB paBfH14pcL3z5t2SKSqqtF+EPVI9WPVAMpCODY4Mkk05BT3n9gMmZ5dHKf2sr2KQ/xKW 74QuoAmAoRiXB1pKrCpBXqRT8upeySz5Ar/Y2nJT2DxgoenVuHtonAOfY+zI5l3p7eyF noOu9bJAU2LZ9WgY4TzEGFqP79eqPvI0zQNIoRu6VZ+pNzivPsUkGhXa8GB+QbmYg1At MKyA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=KWhEn0E7; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Zmq4MDGP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Yaltox2h; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-4b2d871fb9esi2100418b6e.90.2026.08.20.02.16.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Aug 2026 02:16:29 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=KWhEn0E7; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Zmq4MDGP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Yaltox2h; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RFlhMvQ9zn+jGhGVIZkyzxefKhsO07j7RnZNum9FVe4=; b=KWhEn0E7KygBGSCaROzslWooJh Zru4SN9fTAt0xyilY5GJ6D8jgcTNoxNMrFQ9CblAFi0f4WmUYEL//lfW82ghLGljrF4GdF4sIgQTV IJ2BCB59SItDiD124aPgVHTLsrWC+y7A1XA7oc/b3iVG84t6cmUXcYWvZoaMlMUCTRuQ=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wwysv-0003T4-9n; Thu, 20 Aug 2026 09:16:26 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wwysu-0003Sx-3s for openvpn-devel@lists.sourceforge.net; Thu, 20 Aug 2026 09:16:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9KRsbAmzW1Jt8PZEubB1vOQSP3PgXBHfiQtVuUsVZeI=; b=Zmq4MDGPIbR6lg52oAZ3jlaiDH Zeu9nDv0ZpTKquSehxSkgRWA3/URGJa7NrmPLfMQ9vcYPCfFr8bkDhbjpVA3m3NefyXUBCngxEUF1 zhY9TA7xzmDmMkVzpJaSP/9Uoo+qt4+Gjk52K33Dir9V+parvLBGniiOv2zlP+RJyKwo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9KRsbAmzW1Jt8PZEubB1vOQSP3PgXBHfiQtVuUsVZeI=; b=Yaltox2hNvn4pjiZrfbl4exWV3 w/uZErRERROM1NMNv024mCers61CGU/2j7vol7NT2jqXN6b4m7l79h7etLSkyCdnq5DCAN6757hFv z/N5KFmaOFvEIRjEtjnXs6YtFcnMWL87s+flAnVm/NzhMcqyzO8YHzTfhBePb6dz1wwc=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wwyso-000871-JM for openvpn-devel@lists.sourceforge.net; Thu, 20 Aug 2026 09:16:25 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67K9GFRX004672 for ; Thu, 20 Aug 2026 11:16:15 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67K9GFCe004671 for openvpn-devel@lists.sourceforge.net; Thu, 20 Aug 2026 11:16:15 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 20 Aug 2026 11:16:09 +0200 Message-ID: <20260820091615.4656-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld And apply the changes. Change-Id: Id4d04bebdb8b2cb56e8dd16a386c41fdb95c0413 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wwyso-000871-JM Subject: [Openvpn-devel] [PATCH v4] reformat-shell.sh: Add --simplify argument X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1874033260998666069 X-GMAIL-MSGID: 1874033260998666069 From: Frank Lichtenheld And apply the changes. Change-Id: Id4d04bebdb8b2cb56e8dd16a386c41fdb95c0413 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1794 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1794 This mail reflects revision 4 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/dev-tools/reformat-shell.sh b/dev-tools/reformat-shell.sh index dbbdaa9..d76eae7 100755 --- a/dev-tools/reformat-shell.sh +++ b/dev-tools/reformat-shell.sh @@ -5,7 +5,7 @@ set -u -FORMAT_ARGS="--indent=4 --func-next-line --case-indent" +FORMAT_ARGS="--simplify --indent=4 --func-next-line --case-indent" FORMAT_CMD="shfmt --list --write" # hardcoded to --posix due to .in filename and invalid shebang diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in index 305441be..230a273 100755 --- a/tests/t_client.sh.in +++ b/tests/t_client.sh.in @@ -155,7 +155,7 @@ fail() { output "FAIL: $@\n" - fail_count=$(($fail_count + 1)) + fail_count=$((fail_count + 1)) } # print "all interface IP addresses" + "all routes" @@ -386,7 +386,7 @@ ovpn_init_check=0 ovpn_init_success=1 fi - ovpn_init_check=$(($ovpn_init_check - 1)) + ovpn_init_check=$((ovpn_init_check - 1)) done opid=$(cat $pidfile) diff --git a/tests/t_lpback.sh b/tests/t_lpback.sh index 058206f..ec0a220 100755 --- a/tests/t_lpback.sh +++ b/tests/t_lpback.sh @@ -59,13 +59,13 @@ ;; esac e=1 - tests_failed=$(($tests_failed + 1)) + tests_failed=$((tests_failed + 1)) else case $V in 0 | 1) ;; # no per-test output for 'OK' *) echo "OK" ;; # print all esac - tests_passed=$(($tests_passed + 1)) + tests_passed=$((tests_passed + 1)) fi } diff --git a/tests/t_net.sh b/tests/t_net.sh index 17e028e..d63f648 100755 --- a/tests/t_net.sh +++ b/tests/t_net.sh @@ -162,7 +162,7 @@ # remove interface for good $RUN_SUDO ip link del $IFACE -for i in $(seq $(($LAST_AUTO_TEST + 1)) ${LAST_TEST}); do +for i in $(seq $((LAST_AUTO_TEST + 1)) ${LAST_TEST}); do $RUN_SUDO $UNIT_TEST $i if [ $? -ne 0 ]; then echo "unit-test $i errored out" diff --git a/tests/t_server_null_client.sh b/tests/t_server_null_client.sh index 3203cc2..9f4168b 100755 --- a/tests/t_server_null_client.sh +++ b/tests/t_server_null_client.sh @@ -164,7 +164,7 @@ continue fi if $RUN_SUDO kill -0 $server_pid >/dev/null 2>&1; then - servers_up=$(($servers_up + 1)) + servers_up=$((servers_up + 1)) fi done