From patchwork Mon Aug 24 16:15:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5269 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:4306:b0:87d:ab56:3700 with SMTP id q6csp4626458mae; Mon, 24 Aug 2026 09:15:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RrCwYemj41hPJYodISjdbvIeQ/Z8h+l3eSUgiOvgvpV1PkeFGn/aTyMb11eALDs0SjZ9ut1BGSbi6A=@openvpn.net X-Received: by 2002:a05:6820:220a:b0:6b0:4170:59ad with SMTP id 006d021491bc7-6b15939ad12mr22860562eaf.24.1787588146180; Mon, 24 Aug 2026 09:15:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787588146; cv=none; d=google.com; s=arc-20260327; b=NwmWuUjbKCOzNMT52SMSxqrCp1gzI1gD7Y6WkAv7tS52nbVuSVUiKAWmI8uUMpB1d3 ZzN/SNIzyZjvUHMeZqsDXppxGGH5Z8/rUwy405xksq58Pu/8kxVi5E+dnWtdXQ19rB58 WPz4gMEXDLX7GrihMFZKbko30sGNE9iqA6SfCA5GYZrByxvKyKu4SQgmied7iIZdiGe9 Fwv+u6hKZWy9pgfY/HDhzi6TZhoN2INowdP/RTZlROFeLVWe7qWoad0uNb6eIqZB8bMs np5shQrgqmNE+Mq/zqbPJw3zmyqW4vyWZ3NV1lHCOx901sntfuyzym0no+Q4er4nCV5k oFkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=jwcGTrezQpED/rMmm5JCAvXgtAfDNcGcgTRabHh3+ZU=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=SXIIigNAoAQqGrKGe0+r2h+RLe9N2dUCrWJgM5VgDU6CrurviOtQfqVeeUZZQ+w7kP Qmfj9KPJJQ8UxuBRcT0tcZDy3hWrDhRO1gSpBbjTYNvyTeYlTLa9NONuvubu5U407+0I pBvsu0XcM3LpAe108mOmCG3C4F754UM6n9SQuC/uJrMc13ezIFqXKhxb5awEdpQc43zS yarkQ5Yk1gcCu2E9TyUbZ0iMZnOEcq5P3xpu+Y+K1g2QYC/KyBfBJzKGgraSR3tMhNba JDj8PgbxWonZmkhqv3+JQk8SIxD9VEWeXQVir04uG+mMgxRxYUXO5EPhte4k/GmFlAGp dbIw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jODKzyAg; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XFtbfPr3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TWtYqVfn; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-463836d4142si10405753fac.333.2026.08.24.09.15.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2026 09:15:46 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jODKzyAg; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XFtbfPr3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TWtYqVfn; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jwcGTrezQpED/rMmm5JCAvXgtAfDNcGcgTRabHh3+ZU=; b=jODKzyAgK5NO4QbaSHOAf7+M+T joutFTfhmG8er0O4NYupOoNqbXDtWVSBFtVI43YVYCNgUnHBVupRsa9RI3Nn4jJUvlRnhNgyXnP8k dFDsm4v6eIpmgZHZlmbwbqsybB6Q5v+3l5zGiHVnL/P2gF9oEnJLLjYqKf0PKcFYnkag=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wyXKo-00031Y-Vh; Mon, 24 Aug 2026 16:15:43 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wyXKn-00031E-MM for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 16:15:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hJ9JyzUEVBZdeW79a12p4xWM7pPi+Kxxaedh8yYQZXU=; b=XFtbfPr36Njy92TnbdzvHQFenu x4THNW0dMF3vJo085v4kScHbHixHQPp8B0OmAgyr4rLniMXD523K6ODwSw7wkBbtElSWms0p90LVT y/6VC7XivreN3YzwmkhgVf9SZuByrRSYE+Nek5zXzqo2QDfGZse6uxk7qn0W6IBD/E/Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hJ9JyzUEVBZdeW79a12p4xWM7pPi+Kxxaedh8yYQZXU=; b=TWtYqVfnQlP9QkOrRC1+UByGOi 91G/4Kgc7mqkCe7x7TFqtPazlx/QPyTHHW2hMg2wz6a8Cup6EX+J2TkUXwVAEyS7O+I5CZ/h8uiTZ WQYfU2T5TmawzeMmfdd3uNWaOuVYbimxqCXiZI9Oql86hvBKPqkFBmCaSGwSsmfH5L60=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wyXKQ-0001Zv-S2 for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 16:15:19 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67OGFCoW001750 for ; Mon, 24 Aug 2026 18:15:12 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67OGFCGQ001749 for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 18:15:12 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 24 Aug 2026 18:15:05 +0200 Message-ID: <20260824161512.1720-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld This function was removed in commit 1625d927fc79e2926015ded06a01fd8e460a4bc7, but the declaration and the non-Windows definition were left behind. Identified by cppcheck. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wyXKQ-0001Zv-S2 Subject: [Openvpn-devel] [PATCH v1] dco_win: Remove unused dco_start_tun declaration X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1874422027523885009 X-GMAIL-MSGID: 1874422027523885009 From: Frank Lichtenheld This function was removed in commit 1625d927fc79e2926015ded06a01fd8e460a4bc7, but the declaration and the non-Windows definition were left behind. Identified by cppcheck. Change-Id: I395cc722d53201d775c20ae3cf9d50149bfc90ed Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1863 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1863 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/dco_win.h b/src/openvpn/dco_win.h index ac3ce33..a92e5ad 100644 --- a/src/openvpn/dco_win.h +++ b/src/openvpn/dco_win.h @@ -65,8 +65,6 @@ void dco_p2p_new_peer(HANDLE handle, OVERLAPPED *ov, struct link_socket *sock, struct signal_info *sig_info); -void dco_start_tun(struct tuntap *tt); - bool dco_win_supports_multipeer(void); void dco_win_add_iroute_ipv4(dco_context_t *dco, in_addr_t dst, unsigned int netbits, @@ -79,13 +77,5 @@ void dco_win_del_iroute_ipv6(dco_context_t *dco, struct in6_addr dst, unsigned int netbits); -#else /* if defined(ENABLE_DCO) && defined(_WIN32) */ - -static inline void -dco_start_tun(struct tuntap *tt) -{ - ASSERT(false); -} - #endif /* defined(_WIN32) */ #endif /* ifndef DCO_H */