From patchwork Mon Aug 24 16:15:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5270 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:4306:b0:87d:ab56:3700 with SMTP id q6csp4627043mae; Mon, 24 Aug 2026 09:16:11 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RpSCmx5PdEO1Bdmgm+lYNzvQmpbps/dFdSVbX6Z8hGrgebUcfj6X592HeM8wjWwc38cgeGtKImIR3o=@openvpn.net X-Received: by 2002:a05:6820:e1a9:b0:69d:9dfb:7928 with SMTP id 006d021491bc7-6b16b2f7f06mr13782606eaf.3.1787588171049; Mon, 24 Aug 2026 09:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787588171; cv=none; d=google.com; s=arc-20260327; b=ZE2YlgpMR74z7JCvt786Xm4KrqHg8gJwqevgVOANgAAEoWH1L1LHrPwDPBkJ5nqPbA hvhTPb9ArpiZnxU3NBEOQCMUIBkmWLYEisEe/fBDX1EM845nqqps+awoKRTtQS7ebKsN zmYnwgRr6TMBBzV3qKBMoucWAzOvtW0kI5YjnE9Me8tqDItIK07qepKyODicvaU5A141 e2fNwD+IGK5aS+2VdhgY510JiI9VKlQ6Gg4KlAD6G7PbRpgqLprdMRIDqiKuAd5Il/FD MoUP9z2liH5fNRRP6UojM6ulQEQKUt9Op8zffZSMDWYTksLMFw0mo5DK1PpEMnZG1GYk BMBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=omuSs9nNLpIqy7+RG5VBNmoLNzKKlu37mC+bgCmtDXs=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=A3BI29c+Eq+yZFrs8MsA/wlTSapwOEKr5XYO+B2Fa61jsgm9Iu3bwwjyVsmIrfGoC7 1PDM0aC+it1jb7KJ73KABv0w1Rk8HO1UIbXaGVwC77gV+HGzBEJsNedCchk4mbfqIwDu F3eFRffOshM/tkRY7GhNz8RtGE85WzBH3o8WEg2V2dC/4DRY62i4NYsU9FdDnh7DfL60 +jfv2+NqHPc7XpsK83CF0Iu4QqqZfX9yWE8UmUhdu1CmvL/T0hQG4uO52uBW53b0JNca GRzGZSG71ixV/jVjrewj/AEpoOUTc86u5xnSTrdctPsVLSi/A3AKEEmb1A5NhgIgYhyT ifbA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=lYDF0ldF; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=PKI9BEpP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=cb97GHwH; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7f48fc81d36si7814722a34.67.2026.08.24.09.16.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2026 09:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=lYDF0ldF; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=PKI9BEpP; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=cb97GHwH; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=omuSs9nNLpIqy7+RG5VBNmoLNzKKlu37mC+bgCmtDXs=; b=lYDF0ldFTBMwI8EmNWPQbXrjlW eyq8GN8Wj7vGEJPtTSTPoO8Uf37Bib8dxGSCCXfD28+9NoyJYiTa0HmJ6c6k3qrvLEiFtKtmLv0wY Zy3Oo1bCcSQr9S+eMB655Z/x7/0Q2MsFOVgRTypws5lcOTixWhtditShTjzlQEVWTXII=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wyXLE-00034f-4g; Mon, 24 Aug 2026 16:16:08 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wyXLD-00034Y-1V for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 16:16:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SVjf+h7XPW3lyMl3kfVFWMzzvI48t6BHV65A3I99XwM=; b=PKI9BEpPKS0kfhQJysNusap0hO dVE04cPMAugjXn3pwxcrc9qNOV0zpwO3R/g77pDbKs2tRExyGMf54NyeT0wq12euMK4MaH8YANF5s Y5v/qgepEsR30cnd7JXzrTt90ikJ7wVhGLp8X/XFhFz/a5MLMDegx4jUn1BvG1cDOv3U=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SVjf+h7XPW3lyMl3kfVFWMzzvI48t6BHV65A3I99XwM=; b=cb97GHwHhQx7Hire8dEjz0xNFP woAtv9WPww6Wuv1dAPNj2b4mZD4GuJpEsIaJTODbXURoskXsEY4u5BZ0OFDNJJhrsz21xT3GJU/6E 4/r/2SEyLHrvPuLgroUAsUEiWNn+L67l+HgDXzupeiY1HlW6IhI5rqLKHNR6e1j2nX/g=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wyXLB-0007PK-Co for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 16:16:06 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67OGFwj4001892 for ; Mon, 24 Aug 2026 18:15:58 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67OGFwoW001891 for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 18:15:58 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 24 Aug 2026 18:15:52 +0200 Message-ID: <20260824161558.1869-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld This has never been used in the git history. It is also equivalent to just using CLEAR(). Identified by cppcheck. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wyXLB-0007PK-Co Subject: [Openvpn-devel] [PATCH v1] event: Remove unused function event_set_return_init X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1874422054043678364 X-GMAIL-MSGID: 1874422054043678364 From: Frank Lichtenheld This has never been used in the git history. It is also equivalent to just using CLEAR(). Identified by cppcheck. Change-Id: I2cf5da2aa6fbb68116c7b6ef587a6494acae0b54 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1867 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1867 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/event.h b/src/openvpn/event.h index 40ed161..b784dfe 100644 --- a/src/openvpn/event.h +++ b/src/openvpn/event.h @@ -190,13 +190,6 @@ return ret; } -static inline void -event_set_return_init(struct event_set_return *esr) -{ - esr->rwflags = 0; - esr->arg = NULL; -} - #ifdef _WIN32 static inline void