From patchwork Mon Aug 24 16:16:34 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5271 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:4306:b0:87d:ab56:3700 with SMTP id q6csp4628393mae; Mon, 24 Aug 2026 09:17:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+Row0TIxTv8TNU7K/5ucmulvdlmntDEV/jROL4EsfmkZdEP27IW/PwTW/niQc6mXTzQ5OORAaqQPl2c=@openvpn.net X-Received: by 2002:a05:6870:210d:b0:45e:d2bc:7b74 with SMTP id 586e51a60fabf-4637fa703b6mr17670395fac.8.1787588236722; Mon, 24 Aug 2026 09:17:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787588236; cv=none; d=google.com; s=arc-20260327; b=IexwQuQPeORoi4kIqID3fsNkA3KbrVGxtL2+wxu8vPMfexzhCy8oiYyiGLtPzUrIE+ S5EFl1m90e43s4pt1HTS6AMVNU63W/EPRIU+m97nJdL70BPKz4erl8mxOT93h7040GcE nszhim6KsiU5TlT7TYLBluGmrAc01GPA0bf+3iFuhORLGLVVwM8oPGlChBMvKAi1Q7a6 Imt5NlfIXC4G+8xwPFdaVzlkdEqyHTJ2XsqPmk/uP4VH2OjDrS60e3IhbgOU7uXIaBfR uCKQn5T0vNAR6xzHZGevhe6WWZ2ysnIwpN2MwxjK+JZfMm9enhniimgUSyBabPjXTSud i//g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=3FWcG4Aio1FDuDCPqS5risDEdOIS9f5kzLr1RKx+LeY=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=gAj/pynWBuOEnmL6y6A8P8F0TUjRpzTOl4GRD+JXWH6mspGaAAryXVZpQwrpfEd52m ue6QIeteCzBn30WQzrAquBCH5RzIvvRBAp5IcAqW5LAAzNQBcZk6WZzFGe3PKmk8waRj 1exkjj5tf713ygQFEZJ5Pt9jdTGESBIqUygDV9Uyw3Z8hDdb1S96UuIk0sezqK7qDi49 n7iog8OVap/MiJnHezpDcUjQpNeuHGfF7Z4LFH/rOu2AosAy6QjnvT9WdwTBIN8OqW25 ZIJLwhRUIjaB6Fx1Td5fmJvaDK91dVwFAA/13z2xgIOJZMKMlFhJPZPfSUD9VLY6z2jh 10wA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=XcTldIsW; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VtxfC6hG; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CxFsHIoy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4638317f673si9561011fac.42.2026.08.24.09.17.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2026 09:17:16 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=XcTldIsW; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VtxfC6hG; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CxFsHIoy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3FWcG4Aio1FDuDCPqS5risDEdOIS9f5kzLr1RKx+LeY=; b=XcTldIsWfug7dN7nRL/Jt/p/Cu ELc0etBOVh2ILOyJdlhyMQG8sKNDA2OBwLezxoo8CUWBmZThBbHad482hgCwSnakPQclXszHZ4rzj RdiVaYVoTuKlOGUDe2qCkzF6ZnwzFAchi6fYJHEMkl4V6vBgpJfwelfxhCqpxtYfZnXc=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wyXMK-0005Rz-JG; Mon, 24 Aug 2026 16:17:14 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wyXMJ-0005RJ-W5 for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 16:17:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OCA3WTPsmBTf9mpQPWlf6BH2+1kOKY3+2oLHyQ5o0wg=; b=VtxfC6hG2SMj1GTii/VafIkzVK I/ttD2WwZec1uYwhS3wc4+rA94Lv9OrG42W6nPPzWtiVecAxqjBExCDDetNLZ94Yox8k2QauK0TQW iGCMTACdfnqqwIVFTktjWaEQgOkdKbX1I62prAR9ixjI1gunqwlxZbPxZ+wtNIvbLe1w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OCA3WTPsmBTf9mpQPWlf6BH2+1kOKY3+2oLHyQ5o0wg=; b=CxFsHIoyTGxpwK6GLTY1DPph0X 90qq7QtEZD0DPiqFnCGXtskYlC/PnaR1LsVjyxEKJTCIgy2GwotWm8WHEYjz5C1ClS680JLYu+LjV pGfhoIIenVRoNztSlSzt5AKiv67xvkiIXHMXEBzWvCpRnj7UH1aYd9lFL4CHcDU9bu/4=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wyXLr-0007R6-FX for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 16:16:48 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67OGGfNf002007 for ; Mon, 24 Aug 2026 18:16:41 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67OGGe1I002006 for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 18:16:40 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 24 Aug 2026 18:16:34 +0200 Message-ID: <20260824161640.1971-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld These have never been used in the git history. Probably OpenVPN 1.x remnants. Identified by cppcheck. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wyXLr-0007R6-FX Subject: [Openvpn-devel] [PATCH v1] interval: Remove unused usec_timer functions X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1874422122488097691 X-GMAIL-MSGID: 1874422122488097691 From: Frank Lichtenheld These have never been used in the git history. Probably OpenVPN 1.x remnants. Identified by cppcheck. Change-Id: Icfb109714b42cab0af34f21f8fc8972059091c8e Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1862 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1862 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/interval.h b/src/openvpn/interval.h index f6d3503..59051bd 100644 --- a/src/openvpn/interval.h +++ b/src/openvpn/interval.h @@ -255,47 +255,4 @@ */ bool event_timeout_trigger(struct event_timeout *et, struct timeval *tv, int et_const_retry); -/* - * Measure time intervals in microseconds - */ - -#define USEC_TIMER_MAX 60 /* maximum interval size in seconds */ - -#define USEC_TIMER_MAX_USEC (USEC_TIMER_MAX * 1000000) - -struct usec_timer -{ - struct timeval start; - struct timeval end; -}; - -#ifdef HAVE_GETTIMEOFDAY - -static inline void -usec_timer_start(struct usec_timer *obj) -{ - CLEAR(*obj); - openvpn_gettimeofday(&obj->start, NULL); -} - -static inline void -usec_timer_end(struct usec_timer *obj) -{ - openvpn_gettimeofday(&obj->end, NULL); -} - -#endif /* HAVE_GETTIMEOFDAY */ - -static inline bool -usec_timer_interval_defined(struct usec_timer *obj) -{ - return obj->start.tv_sec && obj->end.tv_sec; -} - -static inline int -usec_timer_interval(struct usec_timer *obj) -{ - return tv_subtract(&obj->end, &obj->start, USEC_TIMER_MAX); -} - #endif /* INTERVAL_H */