From patchwork Mon Aug 24 18:04:48 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5275 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:4306:b0:87d:ab56:3700 with SMTP id q6csp4758418mae; Mon, 24 Aug 2026 11:05:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+Rq7YKYmuhmqWJeS07uLDuu+EAi4hz6Kwtk2WABa32WO9yflg3N0qaqsbjCht1pR2PUTvGqWQPPBZ2Q=@openvpn.net X-Received: by 2002:a05:6808:16a7:b0:4a4:2424:eb0e with SMTP id 5614622812f47-4b2ef473409mr26249139b6e.20.1787594707128; Mon, 24 Aug 2026 11:05:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787594707; cv=none; d=google.com; s=arc-20260327; b=dk4Kbd3woiL36e5XcbClzfhRKXKB0XIVYvNqJomdi67G4sPljICAPbSPNXOWxEm6ia 5Tb1SNug3oCDMrve8uhpPrG2SQU8/DTAUBX/BshK8xQ9+oBVgH0sIXZU+4jDxXYY6Zi2 4ZjQt5L+6N+uv9ENIcwe8LMdnEEHmv53hr+UCzF12M109I8CvZUC0mMMsfxWsNGGvMB9 MkFHIuef7IaABs5opXAgG5RT+Lq6Vc17aD1pibZy0ZaesTvIdPZtrdocSxnt48UM4fos 2GE8lLwZ624jCQJpKyRuLQxiE34k3FpPds4l5pg4Dn78PO167Ae5+JRYaoxbSQGQy8Mk w5Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=ry5esWBDNmJvSJ2FwaDN2KOrBu6dz9lDmpnbGum5Z78=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=VOJg9E2karF7ukJO9Cc8y9Yj3OJqMTxv747kcVHeUiuF92EYIoGVIbylL1UlnTZZog Wm8upiaa6rIMYJm2JBcK6ZKKRZ4TzgD27YUHdhFcvgpkcLE0O939gezk+RKmzijJAaB/ WPdCru5UcNOFehQFWWlZLRv/9AEQ95qSDp6S5SvJenB84LeeBz/tux7gQ4CKuFI3beq8 WhDZjok17QQCBX/e5UUOtoE1xYax/G/X1exXN+3CB84/9ugqfhRGbpnQuSBtB4dq8+qL KkXvNLVmtVrfBrDYLAfkClOEIvzLPg5ciqs5mTvKh3TMEQlFcSlYdYQfe6fqlKcbg5jw 0l+Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jjOKD4ae; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=b7KKW9ku; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=L57rFo5L; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-4b32c6a2cd1si6885641b6e.48.2026.08.24.11.05.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2026 11:05:07 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jjOKD4ae; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=b7KKW9ku; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=L57rFo5L; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ry5esWBDNmJvSJ2FwaDN2KOrBu6dz9lDmpnbGum5Z78=; b=jjOKD4aeIlmBAiuHOgJ71CEucZ HAMXXdllr680NMAtIvU99s6W82Hp8AkCPt/V1yfbn4kTMXnZmbVt2inykvH9QwipmrxZuOAT4awpp mrscfBV61CeBBS36j5rnFVd/7XtlZurgUhm7mf1nR5fadUh6SIMAd3h/NxS72DoKuobg=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wyZ2e-0004zD-2n; Mon, 24 Aug 2026 18:05:04 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wyZ2d-0004z2-8o for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 18:05:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=q4eWgSMItE/mTtr6+tRU/MWWuVEtl1CcZ3XNPp0ylrw=; b=b7KKW9kuYJt351rlltxSaJnarE xUKqgFFHM4BZr+Kd9/jIdB76p0slCea4SGU3dOGXWYK5BfZn6kwW7uNssor8VlQhxstBTukjM4Wxb mKRgEPcGy2xZ0bfTe9wGPWZOsP1EVOAyiZsFlJxNsYfSPbHDPw7byxIMVHGaxUItjBJM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=q4eWgSMItE/mTtr6+tRU/MWWuVEtl1CcZ3XNPp0ylrw=; b=L57rFo5Lur36tQbizlr84aoBGF IU6DAuFc2nZxD09dsl/Urq511yA1/oLZ6ZjlLu48fz9yhP3tS3eT/wW5C0WnxyQ4WZrY5OubX5PbG H0tg7bXHXT+AqPD5TaAHaGsaWnF5p2B4bdoPAgZef8s9TkpubKBJ6UL+hbiyG5ObPB3w=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wyZ2b-000633-V7 for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 18:05:03 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67OI4t6M012212 for ; Mon, 24 Aug 2026 20:04:55 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67OI4td6012211 for openvpn-devel@lists.sourceforge.net; Mon, 24 Aug 2026 20:04:55 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 24 Aug 2026 20:04:48 +0200 Message-ID: <20260824180454.12181-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Heiko Hund The interface name is UTF-8 encoded. In order to log it correctly, it needs to be converted to UTF-16 first. Change-Id: Iec392a47123d618c0dbc3a5241c39da4ac83d880 Signed-off-by: Heiko Hund Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openv [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wyZ2b-000633-V7 Subject: [Openvpn-devel] [PATCH v1] openvpnserv: fix log lines format string X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1874428907518971227 X-GMAIL-MSGID: 1874428907518971227 From: Heiko Hund The interface name is UTF-8 encoded. In order to log it correctly, it needs to be converted to UTF-16 first. Change-Id: Iec392a47123d618c0dbc3a5241c39da4ac83d880 Signed-off-by: Heiko Hund Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1861 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1861 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 32c1b9c..b120fa2 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -1224,19 +1224,25 @@ err = InterfaceLuid(itf_name, &luid); if (err) { - MsgToEventLog(M_ERR, L"%S: failed to convert itf alias '%s'", __func__, itf_name); + PWSTR wide_name = utf8to16(itf_name); + MsgToEventLog(M_ERR, L"%S: failed to convert itf alias '%s'", __func__, wide_name); + free(wide_name); goto out; } err = ConvertInterfaceLuidToGuid(&luid, &guid); if (err) { - MsgToEventLog(M_ERR, L"%S: Failed to convert itf '%s' LUID", __func__, itf_name); + PWSTR wide_name = utf8to16(itf_name); + MsgToEventLog(M_ERR, L"%S: Failed to convert itf '%s' LUID", __func__, wide_name); + free(wide_name); goto out; } if (StringFromIID(&guid, &iid_str) != S_OK) { - MsgToEventLog(M_ERR, L"%S: Failed to convert itf '%s' IID", __func__, itf_name); + PWSTR wide_name = utf8to16(itf_name); + MsgToEventLog(M_ERR, L"%S: Failed to convert itf '%s' IID", __func__, wide_name); + free(wide_name); err = ERROR_OUTOFMEMORY; goto out; }