From patchwork Fri Sep 25 13:07:10 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5407 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:5189:b0:8b3:6e77:b38b with SMTP id g9csp157173mae; Fri, 25 Sep 2026 06:07:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBwcb7vVu3cfNqgzV+Ol/cMNIj/oVBg3Tr1qtQyOPGdyGu3i+kKsgWcjxsM2F7M3m+LtsNce8FKcFAM=@openvpn.net X-Received: by 2002:a05:6808:3518:b0:4d6:93c3:3e90 with SMTP id 5614622812f47-4d72f34747cmr5269720b6e.67.1790341649215; Fri, 25 Sep 2026 06:07:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790341649; cv=none; d=google.com; s=arc-20260327; b=oMK3ZXZQBl6qhgLxdT9Dt4mmjsVKS5NNHGlVivh3Z/xIQlb7BK0yJIuFdz4ReXidSx YZZYxxgQfLcwA6FpLjkJa2Soe+Mt83Q914AWzeerjBD3U2WpEEEGJWf8deFSCEQFtDFT qyGl/aY+GxZh+7skp3PE1n2mpjhHjo4SG60ESzbQWSLINN6ng9J+nubDjdnPVG04xgFY mjIYqQfdoLabj5LV3betRpcHDXqWf99RSXU3a5E2Le07LVnp+qgPB69OZ0UhjD/i6vX8 CGzDrQl0OlV1Jl4n89kfPoQmih2YULFzjwK0LaMrikOs52kIVtfVUHslO9Eqypzmavyy RSuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=mKR58Y35GPL/l5nHnqyIb7eM81kC72lDr9kv9zwBFHY=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=OdZAKTf0wwIUqinTopBCx4AFrEDvXCGwNTr0IsMsE3O9FkA9lXgYVg1HeMXy5ABQNC ly3T1wEqo0hxKfa6kCUBLT1g5iw7l13mx8VWiDneO6p7eOVjcegXIIjXHBDKiZI3iUkB /Hs9mKQy6FG1XbD/TslfhgPnKTUTO9i1KrPFAffv8PhK53HstsRmJktXoMOxhoBFMlPH dqw8nZFRgQ3ENs6tYTbCs57Dqnm+g91BGQITMvXCP3HbuQkh6dIt2VK/CA5vWy5TAjGz LTKxfbZHcNiPqq8eiV8FnjaaNHsjRDjVBe28N7UDf54Ce+ohZ6dw7YbnxupKsNoz42Nc v50g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Q6YsYlce; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=M3BjdA3n; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jDRu4A8D; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-4dbf3006fe2si3510381b6e.99.2026.09.25.06.07.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Sep 2026 06:07:29 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Q6YsYlce; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=M3BjdA3n; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jDRu4A8D; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mKR58Y35GPL/l5nHnqyIb7eM81kC72lDr9kv9zwBFHY=; b=Q6YsYlcecf4h7oRZ0Mcj0soF3Q X0ldLjP9/MillHZGbZQuP2b3Qmu6Ft0CojPbUUgbem6BG0IOmT2F2Bui4kFNXZaFiJnEuTwI5v9q0 A1wOs7DzQK1dgybNI2tQijNHArLxLN/R0Vy+Mh1ye0Aae4HKROeV+BmXF2fzpnDEPRck=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xA5e7-0007N1-SF; Fri, 25 Sep 2026 13:07:24 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xA5e7-0007Mu-5S for openvpn-devel@lists.sourceforge.net; Fri, 25 Sep 2026 13:07:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RHOpY5C6ry8G32YVKyaWY4VuGYtbfZCDtySZF3ozS2g=; b=M3BjdA3ndVO37yhgfstvDX7SeE GmLVZG3IDPcCVW0XmpYBc//tzc1kAONvWXztKI0y027qwGf83kznlDTjf9w6bFYm1iGE66hhTYMht gC9Z/qNTLzEEKbz0jPQsRH8P9mEKzNsbt+uKLawZOPR9yQZhsqXK+EMXJM0FvUzd1lp4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RHOpY5C6ry8G32YVKyaWY4VuGYtbfZCDtySZF3ozS2g=; b=jDRu4A8DMsPB4VsXu3acy5N2jj S58YxFGehDN+Ixl4trNOwTguqMjoU1TqE9finU0KmMu57N84EWDpOXl4g35DMaeakC/xmFXSnl/qz hVUp9e+9jRMWkA1eLkT6HVehU0JmW2YxRzd5g2ZsxRCZeJg2KXUV9TnVMZIju8D79oUM=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xA5e6-0007Hn-Oe for openvpn-devel@lists.sourceforge.net; Fri, 25 Sep 2026 13:07:23 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 68PD7FWf009864 for ; Fri, 25 Sep 2026 15:07:15 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 68PD7FoN009863 for openvpn-devel@lists.sourceforge.net; Fri, 25 Sep 2026 15:07:15 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 25 Sep 2026 15:07:10 +0200 Message-ID: <20260925130715.9850-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Antonio Quartulli This function is used only in multi.c and can therefore be declared as static. Change-Id: Id999691f74d291f4b902b8ca224a12d9bc7e6046 Signed-off-by: Antonio Quartulli Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xA5e6-0007Hn-Oe Subject: [Openvpn-devel] [PATCH v1] multi: make multi_add_mbuf static X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1877309285014413971 X-GMAIL-MSGID: 1877309285014413971 From: Antonio Quartulli This function is used only in multi.c and can therefore be declared as static. Change-Id: Id999691f74d291f4b902b8ca224a12d9bc7e6046 Signed-off-by: Antonio Quartulli Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1951 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1951 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 3e72b92..c1ceb34 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -2833,7 +2833,7 @@ * Add a mbuf buffer to a particular * instance. */ -void +static void multi_add_mbuf(struct multi_context *m, struct multi_instance *mi, struct mbuf_buffer *mb) { if (multi_output_queue_ready(m, mi)) diff --git a/src/openvpn/multi.h b/src/openvpn/multi.h index 6cb86c7..ac6cb78f 100644 --- a/src/openvpn/multi.h +++ b/src/openvpn/multi.h @@ -354,8 +354,6 @@ struct multi_instance *multi_get_queue(struct mbuf_set *ms); -void multi_add_mbuf(struct multi_context *m, struct multi_instance *mi, struct mbuf_buffer *mb); - void multi_ifconfig_pool_persist(struct multi_context *m, bool force); bool multi_process_signal(struct multi_context *m);