From patchwork Sat Oct 3 17:54:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5431 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:2999:b0:8b3:6e77:b38b with SMTP id f25csp1969840max; Sat, 3 Oct 2026 10:54:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxEtTlEE7rRSmK0xTDzZ7nFx3f1z7U6YzoWg67/Bp2mHjECTaHBu/uTQSNxfQ7k6iw3JhA1Z+aNRQQ=@openvpn.net X-Received: by 2002:a05:6830:4116:b0:7f4:e011:6b3f with SMTP id 46e09a7af769-823fcd187c6mr3405002a34.14.1791050060884; Sat, 03 Oct 2026 10:54:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791050060; cv=none; d=google.com; s=arc-20260327; b=H90vKksi49Ku1mEd1LRjH79svzhAAWXR+MtG0fb+K8njo/TuRdRTUAMtuPYHf3XRha eoIoCntfGVYQg8X9BMAnzYBLQUftd05LiXdMNIs73JZgNOfRSvrP7mQQo0Ere8PqutIO uZDNoRHM6eMgYUp4iQqL0DtRq1d5QCdSBYI3bwm/3GihF/pauV7CIXQwnZ/7E2ymJVWT 4LK0qNuDzzggQpXfhm4ihts46aj+a9eCWri3zsCus3mMIJlR0IIRVhnwpqswbJSS1XWo /XWfznQnjhl7jZFaMLQdqf/mIcZJqZD2qidCs/1pZOkgAKRmjAXr74HP7Y13ewDF8JzR 19jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=el54fU32al+cGZe2DWNDO4JhnU6hUjkCl++f/YHOTvE=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=GdZXRpkC8dfARV/kcdEYqwx7UJ096XGhtsd7pCSaf253UypGhvcDjwutOfigBNneQW xpYuJfDPQlzDszfVRSeOqB1+OIekZzAyySyXsKyJrfWrjAEQ8UU7OxMHBSYVyyQkjynS lBwLs3i0LtAizng4qiEzUffzuZNTVgW7xsGwaSuGMcEcmPWfx4x3J9EkpFJPlCbbaCs7 r88892tHhnQpt2/FebyQOrFToJ+C1L62kH9L+CHi1zNZp9Q+5j2bmCjQ9cNJtZnQJNO3 f/X2xUphJntwjOWmG9YhfLdcIMn7fqJgtqlZY6iS2DglB5/idpRFtM7qPbLGyA2jyA6W TN0w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=QPjs6TWl; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=AMz3ogPn; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IB3ZcQOH; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-82279e73551si11108270a34.100.2026.10.03.10.54.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Oct 2026 10:54:20 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=QPjs6TWl; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=AMz3ogPn; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IB3ZcQOH; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=el54fU32al+cGZe2DWNDO4JhnU6hUjkCl++f/YHOTvE=; b=QPjs6TWlieUAr+UY6hwW6n/jSb skwqWKwrPCiLFI7/JoXushlrm8KuYaNBbMaDl6EiMMZhibIENQFzin/Qv9aXAUpS9zfJrLctOQ6gt yt4CGEHSQH8SZf4G+azA1bboMNCxAWr6GfP2k1ReC21Wsko2r6AgLE49ySyK9zQgPDOI=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xD3wA-0007Qz-E7; Sat, 03 Oct 2026 17:54:18 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xD3w8-0007Qt-JJ for openvpn-devel@lists.sourceforge.net; Sat, 03 Oct 2026 17:54:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7kL/qVjjuxchaZGdamYhDAJophMUbx3dculW/pH6k80=; b=AMz3ogPnmOIfRPN0YsQvtBpPKh ajbcnTy7DCJaROxW7vWEBkvCxIO9pQjqqRPfHPHFwwJijR+8GGgLcsJbTA2RAAH/CTnbGoVSDBBJo TvrC0fhkqV79gJkSnnzdFrzkVu6YJdrBNBwaudQx/iC2ufMnD1J30S7w9GN1OqPqyslI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7kL/qVjjuxchaZGdamYhDAJophMUbx3dculW/pH6k80=; b=IB3ZcQOH71wDCI+yI6PtWCsEfH yzo7300utFbQErXqsxOGFTPuHny26C6p+F0jEFYEHPx6loyIjE30h8pyHsWfoGywvPJcnJjZEDIIa Shfw3q1Y8ojfWdOPCmjNuZ66FexwYjCrWXQxZvBqky2T2vMEGs+RAK9MrjcoTmIsiZz8=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xD3w7-00077O-6h for openvpn-devel@lists.sourceforge.net; Sat, 03 Oct 2026 17:54:16 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 693Hs8U0006195 for ; Sat, 3 Oct 2026 19:54:08 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 693Hs8MW006194 for openvpn-devel@lists.sourceforge.net; Sat, 3 Oct 2026 19:54:08 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 3 Oct 2026 19:54:01 +0200 Message-ID: <20261003175407.6176-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld I reviewed all the occurrences of the two cppcheck errors constParameter and constParameterCallback. All of constParameterCallback occurences were bogus and I think in most cases they will be. So continue to ignore it completely but document that we considered it and it is not useful. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xD3w7-00077O-6h Subject: [Openvpn-devel] [PATCH v2] cppcheck: Review suppressions for constParameter and constParameterCallback X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1878052108994165416 X-GMAIL-MSGID: 1878052108994165416 From: Frank Lichtenheld I reviewed all the occurrences of the two cppcheck errors constParameter and constParameterCallback. All of constParameterCallback occurences were bogus and I think in most cases they will be. So continue to ignore it completely but document that we considered it and it is not useful. All existing cases of constParameter were bogus, but there might be useful hits in the future so I only suppress the existing occurrences. Change-Id: I76c310f9e69276d4f21a4ad31a24490553d6d5c4 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1966 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1966 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/dev-tools/cppcheck-suppressions.xml b/dev-tools/cppcheck-suppressions.xml index bd24c3b..33337cf 100644 --- a/dev-tools/cppcheck-suppressions.xml +++ b/dev-tools/cppcheck-suppressions.xml @@ -3,23 +3,20 @@ - constParameter - - - constParameterCallback - - unusedFunction usleepCalled - + missingIncludeSystem - nullPointerOutOfMemory @@ -27,9 +24,6 @@ nullPointerArithmeticOutOfMemory - getgrnamCalled @@ -62,6 +56,11 @@ badBitmaskCheck tests/unit_tests/openvpn/test_pkt.c + + + constParameterCallback + constParameterPointer @@ -74,6 +73,12 @@ src/openvpn/buffer.c buf + + + constParameter + src/openvpn/openvpn.c + wargv + constParameterPointer @@ -81,6 +86,10 @@ + constParameter + tests/unit_tests/openvpn*/test_* + + constParameterPointer tests/unit_tests/openvpn*/test_*