From patchwork Sun Oct 4 10:00:29 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5436 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:d40a:b0:8d1:1742:70ef with SMTP id mf10csp350425mab; Sun, 4 Oct 2026 03:00:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBwC3BFvd1mNagvuFry/2S8KApQZMTXT+taxXbN1mUGTvGpU6OIxLCCi8EjYtuDJNVOEf5agg9OAAyE=@openvpn.net X-Received: by 2002:a05:6870:6b99:b0:448:a3d6:c2d2 with SMTP id 586e51a60fabf-49e15d2cb1fmr6194488fac.10.1791108055635; Sun, 04 Oct 2026 03:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791108055; cv=none; d=google.com; s=arc-20260327; b=eNfqvWIMPQshHat3/0dRcCwVKDkUnAr4zoqlGVgm1cAPV+IOnVMoVyRXTX6hffAjRg E8N5KqVdIuD32o4/ZT8NID7pp4rMkzVF2JTI/Qk78KBphNBIcUk1tvSjoy16W+yzTQwf wsP7OA2VrajEr+yGNNW0cF9NaSnVdPjMTkuMLUP97+CzJf1SFgmb18XKDWs4bMBCOQle TSqptt8zT6rvqyZO0NkRDzFF9dvSNvclLTMY412WPmvp8Pkyh2SVHTTdX4hr65eyGTuX TcLX8BH12MYqMrN8LvFIe3EF87bFzTfbggkuFAc5TSEoczveozKdOHNtvOsdovGdA6Wv pOFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=lEX7gnWJSIsxrrCT6ieIfJexrm79UVuMoRSkGRRSaTo=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=IhdbpR4cWWxqPy6SH7wdoe53p558YZbKpDYZw43cOARk5o7vwDRnnfH1yxa4PWM6CZ I0+8OaXMAkD3zz+NBvX8ZqCOIOxzQGv6ClF20zzDdElJ145guGONja7xnM5tibhhYXu5 gpjzvfSb7/CgITJe+LjvG1i1VikotjeNUHsAFvx9FtAE5dqVWpeaUbmE8HbZ1WGuNlLe ieqO94r7XPE+cFZolNEV6xsN0Nf9t/Wcypk+Gmc5XhnWOTjhxaK35SzlkbRhB47AqASt RiXyujEBdnBHmktbVRCl/qzxLfEOLUljOFgoqHOTHlD0T93UM5Q2htBGijRuJjKHQa4D UOjQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Uq2hyzou; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UEZV5nN7; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=DwE2DrWf; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-49e16eb9e7esi11344229fac.126.2026.10.04.03.00.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Oct 2026 03:00:55 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Uq2hyzou; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UEZV5nN7; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=DwE2DrWf; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lEX7gnWJSIsxrrCT6ieIfJexrm79UVuMoRSkGRRSaTo=; b=Uq2hyzou8F+v+LkHF/PtUK9X40 46pqSA7xJXGsh/y3DSA8DyWFZR++ipdKRaIeteU0IIY812YrVGU6nKyxkUZfs1Mlf73k4GbfBYB6E xZZkDOWvCHlNn0shLYhzO//zsvyfuAEZxPGDo7dm8y+qRsvPwm9Ny7UaD7Sh/0NMiHo4=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xDJ1Z-0003pw-Pl; Sun, 04 Oct 2026 10:00:51 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xDJ1Y-0003pT-F3 for openvpn-devel@lists.sourceforge.net; Sun, 04 Oct 2026 10:00:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d3Xp1/6CSdcnh/GgE6kgZi2JBFPr2FgRXkogtuXO6Q4=; b=UEZV5nN7atXx2sEbJ4zLVOMkKr KUh0XtsVSyttxbSt+GuaK170NJL5b1R+SQwljjMKT15V86U3T34gUlznfhVuq0FquOTSC0LqhgM44 Pp6yhWG/hxaNBkQDPbOtPw+N1w5URNmctB+rvUrG8WqDM9uJc4KLgItRq0f0sZH1X3q8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d3Xp1/6CSdcnh/GgE6kgZi2JBFPr2FgRXkogtuXO6Q4=; b=DwE2DrWfEiAKh5oioMdopcqiGp HR/qj+I9vmgNzPPU91JX2FubO3bUATi/C4og/CyAY6gHoTwuPobwtU/mJZSdmD5MmVGhmjzR0se8B HKGbQdtlw8mgFIXeUTjCU2S5ZAT+zrtGpP1EDa6Naue/sFe8VbTsH/n3gL/4LiNDe4js=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xDJ1O-0003ea-NK for openvpn-devel@lists.sourceforge.net; Sun, 04 Oct 2026 10:00:47 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 694A0ZCC000885 for ; Sun, 4 Oct 2026 12:00:35 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 694A0ZJb000884 for openvpn-devel@lists.sourceforge.net; Sun, 4 Oct 2026 12:00:35 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 4 Oct 2026 12:00:29 +0200 Message-ID: <20261004100035.860-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe Certain handset manufacturers (like Samsung iirc) are handling 0.0.0.0/0 different from the split /1 routes, so push the 0.0.0.0/0 route to the OS. Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757 Signed-off-by: Arne Schwabe Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/890 [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xDJ1O-0003ea-NK Subject: [Openvpn-devel] [PATCH v3] Always use a 0.0.0.0/0 default on Android instead of def1 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1878112920475937867 X-GMAIL-MSGID: 1878112920475937867 From: Arne Schwabe Certain handset manufacturers (like Samsung iirc) are handling 0.0.0.0/0 different from the split /1 routes, so push the 0.0.0.0/0 route to the OS. Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757 Signed-off-by: Arne Schwabe Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/890 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/890 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/options.c b/src/openvpn/options.c index e3cd527..cbada6f 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -5615,7 +5615,14 @@ } else if (streq(p[j], "def1")) { +#ifndef TARGET_ANDROID + /* The hack that def1 uses to split 0.0.0.0 into 0.0.0.0/1 and + * 128.0.0.0/1 is not needed on Android and will even + * make some Android implementations (e.g. Samsung) + * misbehave, so silently ignore the flag and always use + * 0.0.0.0/0 instead */ options->routes->flags |= RG_DEF1; +#endif } else if (streq(p[j], "bypass-dhcp")) {