From patchwork Thu Oct 15 11:10:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5471 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:a68f:b0:8d7:ebbe:b250 with SMTP id wf15csp1611183mab; Thu, 15 Oct 2026 04:10:45 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzwNib7B+J78J+TwLtiXJMbJ3ujq3bRC50gso4IxY9tipqbr0zbxeUkG740la+bgm4KLq45hFNfhwQ=@openvpn.net X-Received: by 2002:a05:6830:4126:b0:81b:9724:8714 with SMTP id 46e09a7af769-830963f4801mr18936879a34.19.1792062645222; Thu, 15 Oct 2026 04:10:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792062645; cv=none; d=google.com; s=arc-20260327; b=YMkXI9jJ6WuRRXpDp6YLbzFntJD7jYHOLkh212cJZnyshLDbZ3JD/ZKHKWrVEe5YYW iTZSUKIh+inO3xBx9Ip1pA6u/wKdqHErj2ubPcxNqS96qO3eXLoZX8HPS3avFr1p1Cmh 8kKdbpwirOuANOJhtt6nCfq3urRcOgrw8tkzpf8UH5pJkrrrTSjjGJsGFdnxKocJneUt 7C9T0i6WCY84xcUrk+dIyioHckyAU6zBcTfkqrWwXgkc0PG7XP4x1a6Yva8Xgh9srqtW 2giXbhEARgVpesaZFM+v6nawigzMpaS6qKcVXPtveXtlLxoZC+5K4AlVEOU0WbQcH+td niaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=hp68xVLzrDYP/j5XyRkqK12za/PIYmhlct0tfEqWdfM=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=cXCpsaCRpawCx0W5db4tGcLiCFeiRhsbktwSAycGa6Qf7b4EaHXY6NQOxpAb63F1cJ PbB7LYhbFHE3AsBtzJNmnmj8luYGXyw+SeJaTc6h2vxvVbHf/Vv4q7Sgo1/K0rDDR6fb fE32KoLmVCCpmUi785Ofic09lIG+HEtfH3VTe8RaKsC7qWlIi/noH1+CjOuQtGO4Vq2a UEedGCdqkCM4uQxA5yjNzW0M870zmGedVzGVn+qbQgSUy1vLykuKTM6fuTqI7xHVyBZu UsT50QKAGjh9cA6S/dlffvSmU2qvyixPxlpCHRb5uzoJiRxyXVIxwFJ9wKA10xlRSGiD iLYQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=hyzb932t; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NOQCvhPZ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kRr0Jk4c; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-83ee9993252si5458275a34.9.2026.10.15.04.10.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2026 04:10:44 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=hyzb932t; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NOQCvhPZ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kRr0Jk4c; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hp68xVLzrDYP/j5XyRkqK12za/PIYmhlct0tfEqWdfM=; b=hyzb932tM09M+S1uW7M/aXvgNB hGOd7T3COJhFOS6/FPOUHni/CBoFjekBFt5aBP3NgcKceZWhYDzfk3+qC8XjbM/aD1lCn8OmKD93y cFDgnF8Kztlj0FSfIb0LIU49e5pJMtbWGU7XD7YyD2XjvuZXwvS7mM0BzOetWL+vTHws=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xHJM8-0007Ll-Rj; Thu, 15 Oct 2026 11:10:41 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xHJM7-0007LZ-3G for openvpn-devel@lists.sourceforge.net; Thu, 15 Oct 2026 11:10:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1n6xPmworAJKeGFTLru6Rn6R9yuXLI7Bmmii6hYLiYQ=; b=NOQCvhPZQVOIXdnKotntPBUOoS tNv3K+aOrjTYGHoklLgQ86NoTG+pfu9zwJeUIrlj5Ea6y3JrioyILA/7D15oAp2/UOEamtKJ8ngEX GPqsBxJar3LR8rtuLyd8V1hNrtP93/ffx/j4EA0oXF1/jkZs7Qsi+wgHuGVj++D2iUpc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1n6xPmworAJKeGFTLru6Rn6R9yuXLI7Bmmii6hYLiYQ=; b=kRr0Jk4cpDx529NV0tqoJ/4MFQ ZIwWACNHwbOaGkAXmMma/HDT7OSJzXg3TeezrOGkvqwAM051qYNiACSJO90jFMDe2qcTKXxLPGC87 p8bWjb/jPuI+SZUHttTUpZvuMYybuaIzqUGFW3FBOLxYiL9x1pSMtCZtIL8s4R1k5Qy0=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xHJM6-0004S0-My for openvpn-devel@lists.sourceforge.net; Thu, 15 Oct 2026 11:10:39 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 69FBAV3T022585 for ; Thu, 15 Oct 2026 13:10:31 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 69FBAVFY022584 for openvpn-devel@lists.sourceforge.net; Thu, 15 Oct 2026 13:10:31 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 15 Oct 2026 13:10:24 +0200 Message-ID: <20261015111030.22570-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld We had some patches recently that committed files without newline at EOF. Enforce consistency. Change-Id: I6294665e39ddf012f0a3943d0e356576f4fe02e1 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xHJM6-0004S0-My Subject: [Openvpn-devel] [PATCH v1] clang-format: Enable InsertNewlineAtEOF X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1879113880010916706 X-GMAIL-MSGID: 1879113880010916706 From: Frank Lichtenheld We had some patches recently that committed files without newline at EOF. Enforce consistency. Change-Id: I6294665e39ddf012f0a3943d0e356576f4fe02e1 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1999 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1999 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/.clang-format b/.clang-format index 0823739..23d224b 100644 --- a/.clang-format +++ b/.clang-format @@ -32,6 +32,7 @@ IndentWidth: '4' IndentWrappedFunctionNames: false InsertBraces: true +InsertNewlineAtEOF: true KeepEmptyLines: AtEndOfFile: false AtStartOfBlock: false diff --git a/src/compat/compat-strtok_r.c b/src/compat/compat-strtok_r.c index debcdd3..4240458 100644 --- a/src/compat/compat-strtok_r.c +++ b/src/compat/compat-strtok_r.c @@ -98,4 +98,4 @@ } /* NOTREACHED */ } -#endif \ No newline at end of file +#endif diff --git a/src/openvpn/schedule.c b/src/openvpn/schedule.c index 6c60dc2..ff243dc 100644 --- a/src/openvpn/schedule.c +++ b/src/openvpn/schedule.c @@ -389,4 +389,4 @@ { s->earliest_wakeup = NULL; /* invalidate cache */ schedule_remove_node(s, e); -} \ No newline at end of file +} diff --git a/src/openvpn/siphash.c b/src/openvpn/siphash.c index e31b708..b9fc5e3 100644 --- a/src/openvpn/siphash.c +++ b/src/openvpn/siphash.c @@ -46,4 +46,4 @@ } ret; siphash(k, length, hash_key, ret.out, sizeof(ret.out)); return ret.hash; -} \ No newline at end of file +} diff --git a/tests/unit_tests/openvpn/siphash_openssl.h b/tests/unit_tests/openvpn/siphash_openssl.h index 0f1d329..49c6a9d 100644 --- a/tests/unit_tests/openvpn/siphash_openssl.h +++ b/tests/unit_tests/openvpn/siphash_openssl.h @@ -61,4 +61,4 @@ */ bool siphash_openssl_available(void *sip_context); -#endif /* ifndef SIPHASH_OPENSSL_H */ \ No newline at end of file +#endif /* ifndef SIPHASH_OPENSSL_H */ diff --git a/tests/unit_tests/openvpn/test_schedule.h b/tests/unit_tests/openvpn/test_schedule.h index 55dc591..3705af9 100644 --- a/tests/unit_tests/openvpn/test_schedule.h +++ b/tests/unit_tests/openvpn/test_schedule.h @@ -24,4 +24,4 @@ /** Runs the schedule test */ void schedule_test(void **state); -#endif \ No newline at end of file +#endif