From patchwork Sun Oct 18 14:54:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5486 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:848c:b0:8dc:5c83:a4ec with SMTP id z12csp455992max; Sun, 18 Oct 2026 07:54:33 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvByrcMroG/BAGfQxndOw20mW6ZTalk49f43UUnUjoFH6kkBKDiQ4tHspWHp0CTn+BPwTNw1EB+vgMZc=@openvpn.net X-Received: by 2002:a05:6870:7083:b0:494:116a:b0f6 with SMTP id 586e51a60fabf-4a757a27c96mr3282249fac.21.1792335273410; Sun, 18 Oct 2026 07:54:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792335273; cv=none; d=google.com; s=arc-20260327; b=CEtC9Q0mIHffz1bOzJk+WTpaTWVTLiFGmAwROe1yeXzw98/ksxZU9Z+gc83pRp1zsD +W0yzOcrUC1io82TIpr8S0bGb3OUZn8WRD1RKZHZ/1nTv/R8oo+JQnar+Otn9mAZ4KDL dqaBVgOAEiV7gaRyIpAsSx2frvqFJzKJEOgTrnU7a1BP/97ZozbGyzpC8F+0t80IxttO 5kHw0O60PB+2tUT0hiZsxvnHwORQ0VgCQCdu0G+ZR48uT4pedYX+LxVmNejsFvAQcgZG mdw9cmiCqPTLZa9Ts3VcL7E2rWOSuyjxIlzMZjcK0oRJMQbymN/cFWWvQ6PJab9g8F6J B+aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=+1OfWQYhghm75AuJ7jXpE3zBh+pvm6hrqwWD7dXJuM0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Z7NOpN2cdteC/Mp29gu+NljR3Qnxz70ebHQhXMVwLtyKSWpLssEsbJmDuvF+eNV/Sw NDAPhWINaiR+mei4ZocQi96j2G062Y0JX5EFju2URgXez0SK1DJIokZm1urKl/nxjnDE ux92DBtO6COLwT9kNwpPrbpvn8tzNU+1iv8D27LEMAeeOaMMchw+wz8qVE1RAnupd9Nq o1XMYs4oP9pRHpyWVlS8ZzWK1yhHOYhobsofuMVW9vl598LVwwZ6JN/iF3RdM3nXz0Hp vlMXUN/abFHgoijEJV5wSUvyM4jKvtqi3XN0/JRRfIOLe06nau2Pjoz9v2WZg+Yx2kZr 5u/Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="JeqVBi2/"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HhfEN73N; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dCY4A5yp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4a73b8cda38si11451634fac.359.2026.10.18.07.54.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Oct 2026 07:54:33 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="JeqVBi2/"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HhfEN73N; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dCY4A5yp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+1OfWQYhghm75AuJ7jXpE3zBh+pvm6hrqwWD7dXJuM0=; b=JeqVBi2/E4Oa/AYU3i6LOJe3VS 9x2hdnIjKaRV4aHvgjCj7Gw675O1hKwFohZWo1emrduZ1V1UVHgBXcoiHI6E1VS0aflOByoZyQHOj GkrCyyA36N+JWnmnsHcsCi677/JkG8RkSOrZzI+YsJkZUsce2jpA3HKoIfW5W2iPqDVo=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xISHF-0000t3-0z; Sun, 18 Oct 2026 14:54:21 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xISHE-0000sw-1b for openvpn-devel@lists.sourceforge.net; Sun, 18 Oct 2026 14:54:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o4/NCngruOsLeNbzZbGAYm3GGoup3PMtyHEpfEWV5As=; b=HhfEN73NX/oJIczGfVRYfWPJYD a3SubiVzZyn7x1nY5OZQnwMdjZJYGZ/q1jJmWuS4bvwTNX16phC26ZzShehzBp/QfMXG4hchNyDmW LDnLQdazZ1MPth0ET8rYvodTvnVnFlkzNnH6qu5qjtuC8ljwHVuY9Q2YAQE8OLDwPnGU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=o4/NCngruOsLeNbzZbGAYm3GGoup3PMtyHEpfEWV5As=; b=dCY4A5ypGy4EjXRGSCd8HqWdqJ /0TUpO8Nq2iFNOL4uDD+R8EF9QGYDjVn0eeDWEXS0d8X5+EFKZ2h+R/Fk+4BHdRjXDAr/NxoXRSRE IREOnsqaTOKoNLD8zkYkImERjTE0AZojkac0DRzzgeOFwKIPynUHFKgB+yB2hmtBYp4s=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xISHD-0006qC-1D for openvpn-devel@lists.sourceforge.net; Sun, 18 Oct 2026 14:54:19 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 69IEsCit019788 for ; Sun, 18 Oct 2026 16:54:12 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 69IEsCj6019787 for openvpn-devel@lists.sourceforge.net; Sun, 18 Oct 2026 16:54:12 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 18 Oct 2026 16:54:06 +0200 Message-ID: <20261018145411.19775-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe - Replace bzero with CLEAR/memset memset is nowadays preferred to bzero Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xISHD-0006qC-1D Subject: [Openvpn-devel] [PATCH v2] Fix cppcheck warnings on macOS X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1879399751590949260 X-GMAIL-MSGID: 1879399751590949260 From: Arne Schwabe - Replace bzero with CLEAR/memset memset is nowadays preferred to bzero - add_route_ipv6: Fix %d used with unsigned int - add const to two variables that can be const Found-By: cppcheck on macOS Change-Id: I10ebb5821829bf738e58fec23f9f9dd65d4626d3 Signed-off-by: Arne Schwabe Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2014 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2014 This mail reflects revision 2 of this Change. Signed-off-by line for the author was added as per our policy. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 8e93404..0b1634c 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1862,7 +1862,7 @@ #elif defined(TARGET_ANDROID) char out[64]; - snprintf(out, sizeof(out), "%s/%d %s", network, r6->netbits, device); + snprintf(out, sizeof(out), "%s/%u %s", network, r6->netbits, device); status = management_android_control(management, "ROUTE6", out); @@ -3348,10 +3348,10 @@ rtm_addrs = RTA_DST | RTA_NETMASK | RTA_IFP; #endif - bzero(&m_rtmsg, sizeof(m_rtmsg)); - bzero(&so_dst, sizeof(so_dst)); - bzero(&so_mask, sizeof(so_mask)); - bzero(&rtm, sizeof(struct rt_msghdr)); + CLEAR(m_rtmsg); + CLEAR(so_dst); + CLEAR(so_mask); + CLEAR(rtm); rtm.rtm_type = RTM_GET; rtm.rtm_flags = RTF_UP | RTF_GATEWAY; @@ -3566,10 +3566,10 @@ rtm_addrs = RTA_DST | RTA_NETMASK | RTA_IFP; #endif - bzero(&m_rtmsg, sizeof(m_rtmsg)); - bzero(&so_dst, sizeof(so_dst)); - bzero(&so_mask, sizeof(so_mask)); - bzero(&rtm, sizeof(struct rt_msghdr)); + CLEAR(m_rtmsg); + CLEAR(so_dst); + CLEAR(so_mask); + CLEAR(rtm); rtm.rtm_type = RTM_GET; rtm.rtm_flags = RTF_UP; @@ -3654,7 +3654,7 @@ /* get gateway addr and interface name */ if (gate != NULL) { - struct sockaddr_in6 *s6 = (struct sockaddr_in6 *)gate; + const struct sockaddr_in6 *s6 = (struct sockaddr_in6 *)gate; struct in6_addr gw = s6->sin6_addr; #ifndef TARGET_SOLARIS diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index a226fc4..18c1cff 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -1833,7 +1833,7 @@ for (int i = 0; i < 256; ++i) { /* some platforms have a dedicated directory per driver */ - char *sep = ""; + const char *sep = ""; #if defined(TARGET_HAIKU) sep = "/"; #endif