From patchwork Thu Oct 22 17:04:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5499 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:848c:b0:8dc:5c83:a4ec with SMTP id z12csp5717917max; Thu, 22 Oct 2026 10:04:42 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxBJFI987lpsXcjXco/FsVowVFqP+WubCBF3LaamLBwYHYuUslfi/cUUymCemmebUXloce7FWIA9uo=@openvpn.net X-Received: by 2002:a05:6820:3287:b0:6f8:82ac:cc72 with SMTP id 006d021491bc7-70b88abe4a0mr8405eaf.69.1792688682063; Thu, 22 Oct 2026 10:04:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792688682; cv=none; d=google.com; s=arc-20260327; b=P4jpxz2UJEQ4IyUzSSf3qkUfv78OgETljsnc0k079KUB3ujoWenqf6VaoF7qbyJyyf 96sJ0ga/9hzvQYqetUw7nMPh822XAJ9vcxz6a0wtmuDrzwJwHc4ydr88xJuiebeRENkm MCzcwTgfU2ZF0vGM7y9AazvBQxAS6kwPPXXqDjhd+4pUxJRziVWXqF5UZncYGefnqF1U sTnqRKZyro0Rcn2hxUgrnH1FV8c9cdWd/k0LbO8YpazTysvkI8Qf3mXNhScQJlyZC3RL u7fF913DCZCt1IHkdw7wZXrcJewSS73RvHSsX9eyCeEFxH8F0ec6R69UWHt7G4iq6lEm A22w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=MUYorAWgUPC18Xf2qLOXf3v9c2MRXWKTNQMUQBbfrRM=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=i22L6S/gZ1Qwk9FiwfAk3wnZVw9aOnE+pfcigwdpKMcOVoKPNg4UCmJqvJyxpzr3KJ /Zw3l64RBRtmNw9w/D78uSfP5SLRZInLqgg2l2TzK2UmKGGpqB8C4ZTA13PgeYU5yRJv qMVB3QI0i8aPooyfd//8coWZUCnEwr2AaVfIyslHeC1cXxEEhEn7oIWdx5h/DkWY9lJB BnXGBSEAf7U8vnRqAh+JL8EJzAQS741babvVsyJyr6d0/LQTNF7FKQm8o1mmylvJpSHo OEygv2PqN4lWrfAxSICJsD/YGj1vgMBrWp67a/gACYQ+DRFq7PP1ZZrvV/dnIvKuLgqU yP8Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=l2RapIqh; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XDKsbcMM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=PzYeEE+H; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-709058afefdsi7568861eaf.74.2026.10.22.10.04.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2026 10:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=l2RapIqh; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XDKsbcMM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=PzYeEE+H; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=MUYorAWgUPC18Xf2qLOXf3v9c2MRXWKTNQMUQBbfrRM=; b=l2RapIqhr5M4BT xy1HK/1ilxCK4eyKvNkyWpEPZ2lnzb4JIS7BlwvBamlgKqtzKCKpB1L93Wu6YzezS5kjOuGcXDC4N swGgX9yWR/Ah8f4P5JOU7wMMX0HTyG/Um/CfVzfY8Ha0/YOr60c6c6aU5KaE+xEUUNiIIVedYV/pW dpU=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xJwDY-000000004ky-2IW1; Thu, 22 Oct 2026 17:04:40 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJwDV-000000004kh-3CJX for openvpn-devel@lists.sourceforge.net; Thu, 22 Oct 2026 17:04:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cPzVY0ZVH2UBF/Q+Z3VcsH16AGKZdfsa5DOmU7WcrQI=; b=XDKsbcMMQ1StOp4eligN8l9yy5 5KNAx2DfFyb1FBedP+HYMKfFuRwWV/s0VM7rqwszReTalwtqvQG90+W/ZojwOhtLpWHLQ3utVKVGX x3cjA4P0JoY8dTv+TbQcQ1NEuwFKGl/4PgXgLOsMGlDA90vq5uVLRPUxsiqF1jRmNLRI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cPzVY0ZVH2UBF/Q+Z3VcsH16AGKZdfsa5DOmU7WcrQI=; b=PzYeEE+HGL8c/nFcgQVIhuKCf8 An2tgcFg4nQ7yBma5JvD3O2RYwc92XLLfSqLwFG0KMKizKph1Hso1OAwe0bTLSoavuSwrbO5UyJso UEdMQXKB6e46fg0jw+xeSosj1/whjG56DVQxcKdKeWt0pZgcZeHhqf4jgqRwXKhzCQ0g=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xJwDD-0000000063Q-40rR for openvpn-devel@lists.sourceforge.net; Thu, 22 Oct 2026 17:04:21 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 69MH4But020869 for ; Thu, 22 Oct 2026 19:04:11 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 69MH4Bmf020868 for openvpn-devel@lists.sourceforge.net; Thu, 22 Oct 2026 19:04:11 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 22 Oct 2026 19:04:05 +0200 Message-ID: <20261022170411.20830-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe FreeBSD has no /bin/bash, while macOS has an old 3.2.57 version from 2007. Also work around the differences in readlink and different methods to get the number of cpu cores. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xJwDD-0000000063Q-40rR Subject: [Openvpn-devel] [PATCH v1] Make run-cppcheck.sh run on FreeBSD and macOS X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1879770327745404872 X-GMAIL-MSGID: 1879770327745404872 From: Arne Schwabe FreeBSD has no /bin/bash, while macOS has an old 3.2.57 version from 2007. Also work around the differences in readlink and different methods to get the number of cpu cores. Change-Id: I41bc0fcd475944f3c4701705a46f5a911480b283 Signed-off-by: Arne Schwabe Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2018 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2018 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/dev-tools/run-cppcheck.sh b/dev-tools/run-cppcheck.sh index 3c71c83..58609b2 100755 --- a/dev-tools/run-cppcheck.sh +++ b/dev-tools/run-cppcheck.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash set -eu @@ -17,12 +17,18 @@ disable_arg="--disable=information" fi -SCRIPT_DIR=$(dirname $(readlink -e "${BASH_SOURCE[0]}")) +if [ $(uname) = "Darwin" ] || [ $(uname) = "FreeBSD" ]; then + SCRIPT_DIR=$(dirname $(readlink -f "${BASH_SOURCE[0]}")) + num_procs=$(sysctl -n hw.ncpu) +else + SCRIPT_DIR=$(dirname $(readlink -e "${BASH_SOURCE[0]}")) + num_procs=$(nprocs) +fi : ${SOURCE_DIR:=$SCRIPT_DIR/..} : ${BUILD_DIR:=$PWD} : ${INCLUDE_FLAGS:=} CPPCHECK_DIR="${BUILD_DIR}/cppcheck_build_dir" -COMMON_ARGS="-j$(nproc) ${verbosity_arg} \ +COMMON_ARGS="-j${num_procs} ${verbosity_arg} \ -DMBEDTLS_SSL_PROTO_TLS1_3 -DMBEDTLS_SSL_KEYING_MATERIAL_EXPORT \ -I./include/ -I./tests/unit_tests/openvpn/ \ -I./src/compat/ -I./src/openvpn/ -I./src/openvpnserv/ -I./src/plugins/auth-pam/ \