From patchwork Tue Oct 27 12:44:02 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5512 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:78dc:b0:8dc:5c83:a4ec with SMTP id e28csp129826max; Tue, 27 Oct 2026 05:44:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBz/KaRE4yQGB35MTpsRyMpaYAtNZDsdCFy3hHigH8dFeOIiOhATlcilutFtIohTnmn/EpR9iL63feA=@openvpn.net X-Received: by 2002:a05:6808:150b:b0:4dd:18c7:544d with SMTP id 5614622812f47-55c0028e19emr5697380b6e.31.1793105058657; Tue, 27 Oct 2026 05:44:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793105058; cv=none; d=google.com; s=arc-20260327; b=HlxOEe5xXuVYsgBf2e4jhkBg0mOS4SV+6MfvEiV8Mdsr2P/hDpiopRjiiAL1GoHrxN BV19NR2xW1yfNGRkZorDEo8EiBalUa9QrMTzWuUEgawKdv7cwUyrNm6I3fH+DUUbDQzw RDoqCqgVJwelRvGc+XQ0UBcWZ6/0u9pOCAjQT5ZG+wnrHrqGvDhuZsYgXC1O5+sb24t9 7wJQUsMTmXpL6NXAGQmrWHvfca+U/BgLSjy3ACrLjQutby+XmBy+kN9MYS1mVewrh9Bq Tz3e8gYTs1Typ3+jOT7b3i+JZ5s3uKV5uQz3A3qf+lVbY1xff11nABPzofivqEH3xx5V ceEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=5C3gv5w2sJJnUqhm+E9GGKWheYy7yXyif3PX73CPw2c=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=gOPle+DMGtxyYgwqusyTEYi7FkBhtroSMSu7ALDKXIruuGW/CtsTCPg1Mx/L+MGlIu q7O0Tuugq00yrtzquq6CXi7dwhGlqpfJsOY+XXGw0AxL6a2C2JsIpTdlZZJzTDTTcN86 RPD9sOvy2+/Dgy+jCvvGJ65vjC2mPJgV79nc6+WZTTAGQfztjDMEbCqKE/fqZNCFqGh0 2bJyt0Rv6oCc///ajNcFPwkYBCW/EZ1f3tlXINgzcQC23jq1O1G2VJeJnaCPtexCIeqW nyvX9hJODcL0mdVvhvq5OeK6g/msSithtdPEM9r2o+JHgXQjOf2pSympxku3EIyd+/IZ Awlw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Pr8SddmJ; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=OB0T64b0; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gXtqMByV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-55c043c8853si13434927b6e.64.2026.10.27.05.44.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2026 05:44:18 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Pr8SddmJ; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=OB0T64b0; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gXtqMByV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=5C3gv5w2sJJnUqhm+E9GGKWheYy7yXyif3PX73CPw2c=; b=Pr8SddmJlKjWtH CUTnU1Tr6T2U5SAQQhfCIyW8jvDA/CK+LJksCbyzZnZd0mCQ+Ja9fCKwZt7BHnWm1sqMlR6UXNgLY TSk0Gu72qHnUAucCjzsLXXa7MMuPbdN2XI8pdPtyqfpqjjbkRRN6sLq6foUJsagavbzKeP7aZAyH5 WiQ=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xLgXJ-000000008B4-0CTz; Tue, 27 Oct 2026 12:44:17 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xLgXI-000000008Ay-1Zyt for openvpn-devel@lists.sourceforge.net; Tue, 27 Oct 2026 12:44:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MPTouUUW5iMyRT1y9zWj7nCE28qoj5bCdQMMAMtORw4=; b=OB0T64b0as4ycjc79eHOeFTW/0 JAJXOTOjCiapm1+PxvxNCEOX06MmA7qWKH3/lJkbjWOqqlQbC2+iNo7wWV+WZesgWdogzH4xyOUli EKKsP4qD3H/yNehhJ6YPEP7c0t3c8R4Um75Q08gSMm/ZCkInreGXX6m4FGzFdds5LqBc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MPTouUUW5iMyRT1y9zWj7nCE28qoj5bCdQMMAMtORw4=; b=gXtqMByV3OPZklV6nAqOzrL8cX Fyq+U6yHrb3y/E07tbuI+t64n2R7lkPFeKCAIKsuYhYttY/iNfwUoJnc7krvLjcr58uXRr6yE4V2X Wz8d34hA91tz2efngaRDJwomYyg0EQxe2QDz6VRu32ghWDxf4Uv1NxC57SMP1XyiHUEY=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xLgXH-000000005gI-1mn7 for openvpn-devel@lists.sourceforge.net; Tue, 27 Oct 2026 12:44:16 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 69RCi8pE000561 for ; Tue, 27 Oct 2026 13:44:08 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 69RCi82A000560 for openvpn-devel@lists.sourceforge.net; Tue, 27 Oct 2026 13:44:08 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 27 Oct 2026 13:44:02 +0100 Message-ID: <20261027124408.526-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Gianmarco De Gregori multi_io_action() only polls before writes: reads are dispatched with poll false, both from the event loop and when chaining a tun read after a write. The TA_TUN_READ and TA_SOCKET_READ cases of multi [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xLgXH-000000005gI-1mn7 Subject: [Openvpn-devel] [PATCH v1] multi_io: drop the read cases from multi_io_wait_lite() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1880206930124353577 X-GMAIL-MSGID: 1880206930124353577 From: Gianmarco De Gregori multi_io_action() only polls before writes: reads are dispatched with poll false, both from the event loop and when chaining a tun read after a write. The TA_TUN_READ and TA_SOCKET_READ cases of multi_io_wait_lite() are never reached. Change-Id: I1abb10515665e1d6351689d2c2dd9d4aba8bb98e Signed-off-by: Gianmarco De Gregori Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2044 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2044 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/src/openvpn/multi_io.c b/src/openvpn/multi_io.c index ac730b4..56216d4 100644 --- a/src/openvpn/multi_io.c +++ b/src/openvpn/multi_io.c @@ -235,18 +235,6 @@ switch (action) { - case TA_TUN_READ: - looking_for = TUN_READ; - tun_input_pending = NULL; - io_wait(c, IOW_READ_TUN); - break; - - case TA_SOCKET_READ: - looking_for = SOCKET_READ; - tun_input_pending = NULL; - io_wait(c, IOW_READ_LINK); - break; - case TA_TUN_WRITE: looking_for = TUN_WRITE; tun_input_pending = NULL;